[Bug c++/66748] New: Crash with abi_tag attribute

[Bug c++/66748] New: Crash with abi_tag attribute

[ismail at donmez dot ws]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

            Bug ID: 66748
           Summary: Crash with abi_tag attribute
           Product: gcc
           Version: 5.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ismail at donmez dot ws
  Target Milestone: ---

λ cat t.cpp 
enum __attribute__((abi_tag("foo"))) E {};

λ g++ -c t.cpp
t.cpp:1:41: internal compiler error: Segmentation fault
 enum __attribute__((abi_tag("foo"))) E {};
                                         ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugs.opensuse.org/> for instructions.

λ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/5/lto-wrapper
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada,go
--enable-checking=release --with-gxx-include-dir=/usr/include/c++/5
--enable-ssp --disable-libssp --disable-libvtv --enable-libmpx --disable-plugin
--with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux'
--disable-libgcj --with-slibdir=/lib64 --with-system-zlib --enable-__cxa_atexit
--enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --enable-linker-build-id
--enable-linux-futex --program-suffix=-5 --without-system-libunwind
--enable-multilib --with-arch-32=i586 --with-tune=generic
--build=x86_64-suse-linux --host=x86_64-suse-linux
Thread model: posix
gcc version 5.1.1 20150622 [gcc-5-branch revision 224722] (SUSE Linux)
>From gcc-bugs-return-491329-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jul 03 07:59:40 2015
Return-Path: <gcc-bugs-return-491329-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 50962 invoked by alias); 3 Jul 2015 07:59:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 43794 invoked by uid 48); 3 Jul 2015 07:59:35 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66745] [6 Regression] ice in check_unstripped_args
Date: Fri, 03 Jul 2015 07:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: target_milestone
Message-ID: <bug-66745-4-qcqKbNBUpR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66745-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66745-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg00219.txt.bz2
Content-length: 292

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf745

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-03
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.5
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I think just

--- gcc/cp/tree.c
+++ gcc/cp/tree.c
@@ -3654,13 +3654,15 @@ handle_abi_tag_attribute (tree* node, tree name, tree
args,
                 name, *node);
          goto fail;
        }
-      else if (CLASSTYPE_TEMPLATE_INSTANTIATION (*node))
+      else if (CLASS_TYPE_P (*node)
+              && CLASSTYPE_TEMPLATE_INSTANTIATION (*node))
        {
          warning (OPT_Wattributes, "ignoring %qE attribute applied to "
                   "template instantiation %qT", name, *node);
          goto fail;
        }
-      else if (CLASSTYPE_TEMPLATE_SPECIALIZATION (*node))
+      else if (CLASS_TYPE_P (*node)
+              && CLASSTYPE_TEMPLATE_SPECIALIZATION (*node))
        {
          warning (OPT_Wattributes, "ignoring %qE attribute applied to "
                   "template specialization %qT", name, *node);

should do; testing this.

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Patch posted.

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Jul  8 10:36:26 2015
New Revision: 225541

URL: https://gcc.gnu.org/viewcvs?rev=225541&root=gcc&view=rev
Log:
        PR c++/66748
        * tree.c (handle_abi_tag_attribute): Check for CLASS_TYPE_P before
        accessing TYPE_LANG_SPECIFIC node.

        * g++.dg/abi/abi-tag15.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/abi/abi-tag15.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/tree.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Thu Jul 16 13:25:25 2015
New Revision: 225877

URL: https://gcc.gnu.org/viewcvs?rev=225877&root=gcc&view=rev
Log:
        PR c++/66748
        * tree.c (handle_abi_tag_attribute): Check for CLASS_TYPE_P before
        accessing TYPE_LANG_SPECIFIC node.

        * g++.dg/abi/abi-tag15.C: New test.

Added:
    branches/gcc-5-branch/gcc/testsuite/g++.dg/abi/abi-tag15.C
Modified:
    branches/gcc-5-branch/gcc/cp/ChangeLog
    branches/gcc-5-branch/gcc/cp/tree.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Thu Jul 16 13:33:12 2015
New Revision: 225878

URL: https://gcc.gnu.org/viewcvs?rev=225878&root=gcc&view=rev
Log:
        PR c++/66748
        * tree.c (handle_abi_tag_attribute): Check for CLASS_TYPE_P before
        accessing TYPE_LANG_SPECIFIC node.

        * g++.dg/abi/abi-tag15.C: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/g++.dg/abi/abi-tag15.C
Modified:
    branches/gcc-4_9-branch/gcc/cp/ChangeLog
    branches/gcc-4_9-branch/gcc/cp/tree.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug c++/66748] Crash with abi_tag attribute

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66748

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.