[Bug c++/66758] New: [concepts] ICE compiler deeply confused by simple-seeming concept definition

[Bug c++/66758] New: [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

            Bug ID: 66758
           Summary: [concepts] ICE compiler deeply confused by
                    simple-seeming concept definition
           Product: gcc
           Version: c++-concepts
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: eric.niebler at gmail dot com
  Target Milestone: ---

Created attachment 35906
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35906&action=edit
preprocessed source

Compile attachment with "/usr/local/gcc-concepts/bin/g++.exe -std=c++1z -Tp -c
foundational.cpp.i"

Result:

/cygdrive/c/Users/eric/Code/cmcstl2/include/stl2/concepts/foundational.hpp:30:19:
internal compiler error: Segmentation fault
   Destructible<T>() &&
                   ^

/cygdrive/c/Users/eric/Code/cmcstl2/include/stl2/concepts/foundational.hpp:30:19:
internal compiler error: Aborted
g++: internal compiler error: Aborted (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


Hard for me to guess what the problem could be. A cursory attempt to reduce the
error caused it to go away.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #1 from Eric Niebler <eric.niebler at gmail dot com> ---
Created attachment 35907
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35907&action=edit
preprocessed source, bug #2(?)

This might be the same bug, but the error is different. It yields:
/cygdrive/c/Users/eric/Code/cmcstl2/include/stl2/concepts/foundational.hpp:33:27:
internal compiler error: in tsubst_pack_expansion, at cp/pt.c:10578
     T{ stl2::forward<Args>(args)... };
                           ^

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Fri Jul 10 07:26:01 2015
New Revision: 225651

URL: https://gcc.gnu.org/viewcvs?rev=225651&root=gcc&view=rev
Log:
        PR c++/66758
        * gcc/cp/parser.c (cp_parser_requirement_parameter_list):Use grokparms.
        * gcc/cp/constraint.cc (fixup_constraint_vars): Remove.
        (tsubst_constraint_variables): Don't call it.
        (declare_constraint_vars): Constraint vars aren't a TREE_LIST anymore.
        (finish_requires_expr): Likewise.
        * gcc/cp/cxx-pretty-print.c (pp_cxx_parameter_declaration_clause):
        Likewise.
        * gcc/cp/decl.c (grokparms): No longer static.
        * gcc/cp/cp-tree.h: Declare it.

Added:
    branches/c++-concepts/gcc/testsuite/g++.dg/concepts/req13.C
Modified:
    branches/c++-concepts/ChangeLog.concepts
    branches/c++-concepts/gcc/cp/constraint.cc
    branches/c++-concepts/gcc/cp/cp-tree.h
    branches/c++-concepts/gcc/cp/cxx-pretty-print.c
    branches/c++-concepts/gcc/cp/decl.c
    branches/c++-concepts/gcc/cp/parser.c

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #4 from Eric Niebler <eric.niebler at gmail dot com> ---
Created attachment 35948
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35948&action=edit
Preprocessed source, bug the third

The previous fix caused the code in attachment #3 to stop working.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

Eric Niebler <eric.niebler at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--- Comment #5 from Eric Niebler <eric.niebler at gmail dot com> ---
The previous fix caused the code in the third attachment to stop working.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Fri Jul 10 22:11:22 2015
New Revision: 225696

URL: https://gcc.gnu.org/viewcvs?rev=225696&root=gcc&view=rev
Log:
        PR c++/66758
        * gcc/cp/pt.c (tsubst_constraint_variables): Clear
        cp_unevaluated_operand.

Added:
    branches/c++-concepts/gcc/testsuite/g++.dg/concepts/req14.C
Modified:
    branches/c++-concepts/ChangeLog.concepts
    branches/c++-concepts/gcc/cp/constraint.cc

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Eric Niebler from comment #4)
> The previous fix caused the code in attachment #3 [details] to stop working.

Fixed.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #8 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Fri Jul 10 22:45:41 2015
New Revision: 225704

URL: https://gcc.gnu.org/viewcvs?rev=225704&root=gcc&view=rev
Log:
        PR c++/66758
        PR c++/66832
        * gcc/cp/parser.c (cp_parser_requires_expression): Call grokparms here.
        (cp_parser_requirement_parameter_list): Not here.

Added:
    branches/c++-concepts/gcc/testsuite/g++.dg/concepts/req15.C
Modified:
    branches/c++-concepts/ChangeLog.concepts
    branches/c++-concepts/gcc/cp/parser.c

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #9 from Eric Niebler <eric.niebler at gmail dot com> ---
Created attachment 35950
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35950&action=edit
Bug number 4

ICE ICE baby

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[eric.niebler at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

Eric Niebler <eric.niebler at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--- Comment #10 from Eric Niebler <eric.niebler at gmail dot com> ---
Lest I seem ungrateful, thank you for your work so far. I'm still ICE-ing the
compiler, though. See the fourth attachment.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Eric Niebler from comment #9)
> Created attachment 35950 [details]
> Bug number 4
> 
> ICE ICE baby

Fixed.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #12 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jason Merrill from comment #11)
> Fixed.

in r225710.

[Bug c++/66758] [concepts] ICE compiler deeply confused by simple-seeming concept definition

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66758

--- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Thu Jul 23 23:14:32 2015
New Revision: 226129

URL: https://gcc.gnu.org/viewcvs?rev=226129&root=gcc&view=rev
Log:
        PR c++/66758
        * cxx-pretty-print.c (pp_cxx_parameterized_constraint): Constraint
        vars aren't a TREE_LIST anymore.

Modified:
    branches/c++-concepts/ChangeLog.concepts
    branches/c++-concepts/gcc/cp/cxx-pretty-print.c