public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug jit/66783] No error-checking for creating structs containing opaque structs
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
@ 2015-07-07 19:30 ` dmalcolm at gcc dot gnu.org
2015-07-08 14:42 ` dmalcolm at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2015-07-07 19:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783
--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Tue Jul 7 19:29:58 2015
New Revision: 225523
URL: https://gcc.gnu.org/viewcvs?rev=225523&root=gcc&view=rev
Log:
PR jit/66783: prevent use of opaque structs
gcc/jit/ChangeLog:
PR jit/66783
* jit-recording.h: Within namespace gcc:jit::recording...
(type::has_known_size): New virtual function.
(struct_has_known_size): New function.
* libgccjit.c (gcc_jit_context_new_field): Verify that the type
has a known size.
(gcc_jit_context_new_global): Likewise.
(gcc_jit_function_new_local): Likewise.
gcc/testsuite/ChangeLog:
PR jit/66783
* jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c: New
test case.
* jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c:
New test case.
* jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c:
New test case.
* jit.dg/test-error-mismatching-types-in-call.c (create_code):
Avoid using an opaque struct for local "f".
Added:
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
Modified:
trunk/gcc/jit/ChangeLog
trunk/gcc/jit/jit-recording.h
trunk/gcc/jit/libgccjit.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/jit.dg/test-error-mismatching-types-in-call.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug jit/66783] No error-checking for creating structs containing opaque structs
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
2015-07-07 19:30 ` [Bug jit/66783] No error-checking for creating structs containing opaque structs dmalcolm at gcc dot gnu.org
@ 2015-07-08 14:42 ` dmalcolm at gcc dot gnu.org
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2015-07-08 14:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783
--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Wed Jul 8 14:41:59 2015
New Revision: 225557
URL: https://gcc.gnu.org/viewcvs?rev=225557&root=gcc&view=rev
Log:
PR jit/66783: improve error messages
gcc/jit/ChangeLog:
PR jit/66783
* libgccjit.c (gcc_jit_context_new_field): Show name of field in
"unknown size" error message.
(gcc_jit_struct_set_fields): Show name of struct in error message.
(gcc_jit_context_new_global): Show name of global in
"unknown size" error message.
(gcc_jit_function_new_local): Likewise for local.
gcc/testsuite/ChangeLog:
PR jit/66783
* jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
(verify_code): Update expected error message.
* jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
(verify_code): Likewise.
* jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
(verify_code): Likewise.
Modified:
trunk/gcc/jit/ChangeLog
trunk/gcc/jit/libgccjit.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug jit/66783] No error-checking for creating structs containing opaque structs
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
@ 2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
2015-07-17 19:49 ` dmalcolm at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2015-07-09 21:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783
--- Comment #4 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #3)
> Root cause found: it's because of the langhook:
> LANG_HOOKS_GET_ALIAS_SET
> which it looks like I need to implement for libgccjit.
Ooops, wrong bug; ignore this comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug jit/66783] No error-checking for creating structs containing opaque structs
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
2015-07-07 19:30 ` [Bug jit/66783] No error-checking for creating structs containing opaque structs dmalcolm at gcc dot gnu.org
2015-07-08 14:42 ` dmalcolm at gcc dot gnu.org
@ 2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
2015-07-17 19:49 ` dmalcolm at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2015-07-09 21:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783
--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Root cause found: it's because of the langhook:
LANG_HOOKS_GET_ALIAS_SET
which it looks like I need to implement for libgccjit.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug jit/66783] No error-checking for creating structs containing opaque structs
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
@ 2015-07-17 19:49 ` dmalcolm at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: dmalcolm at gcc dot gnu.org @ 2015-07-17 19:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783
David Malcolm <dmalcolm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2015-07-17
Ever confirmed|0 |1
--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Keeping this open until it's committed to the gcc-5-branch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-17 19:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-66783-4@http.gcc.gnu.org/bugzilla/>
2015-07-07 19:30 ` [Bug jit/66783] No error-checking for creating structs containing opaque structs dmalcolm at gcc dot gnu.org
2015-07-08 14:42 ` dmalcolm at gcc dot gnu.org
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
2015-07-09 21:02 ` dmalcolm at gcc dot gnu.org
2015-07-17 19:49 ` dmalcolm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).