From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-491779-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4426 invoked by alias); 8 Jul 2015 14:42:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 2834 invoked by uid 55); 8 Jul 2015 14:42:31 -0000
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug jit/66783] No error-checking for creating structs containing opaque structs
Date: Wed, 08 Jul 2015 14:42:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: jit
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dmalcolm at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66783-4-LmjVj6gTdV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66783-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66783-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg00669.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Wed Jul  8 14:41:59 2015
New Revision: 225557

URL: https://gcc.gnu.org/viewcvs?rev=225557&root=gcc&view=rev
Log:
PR jit/66783: improve error messages

gcc/jit/ChangeLog:
        PR jit/66783
        * libgccjit.c (gcc_jit_context_new_field): Show name of field in
        "unknown size" error message.
        (gcc_jit_struct_set_fields): Show name of struct in error message.
        (gcc_jit_context_new_global): Show name of global in
        "unknown size" error message.
        (gcc_jit_function_new_local): Likewise for local.

gcc/testsuite/ChangeLog:
        PR jit/66783
        * jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
        (verify_code): Update expected error message.
        * jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
        (verify_code): Likewise.
        * jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
        (verify_code): Likewise.

Modified:
    trunk/gcc/jit/ChangeLog
    trunk/gcc/jit/libgccjit.c
    trunk/gcc/testsuite/ChangeLog
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c