[Bug jit/66783] No error-checking for creating structs containing opaque structs

[Bug jit/66783] No error-checking for creating structs containing opaque structs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Tue Jul  7 19:29:58 2015
New Revision: 225523

URL: https://gcc.gnu.org/viewcvs?rev=225523&root=gcc&view=rev
Log:
PR jit/66783: prevent use of opaque structs

gcc/jit/ChangeLog:
        PR jit/66783
        * jit-recording.h: Within namespace gcc:jit::recording...
        (type::has_known_size): New virtual function.
        (struct_has_known_size): New function.
        * libgccjit.c (gcc_jit_context_new_field): Verify that the type
        has a known size.
        (gcc_jit_context_new_global): Likewise.
        (gcc_jit_function_new_local): Likewise.

gcc/testsuite/ChangeLog:
        PR jit/66783
        * jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c: New
        test case.
        * jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c:
        New test case.
        * jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c:
        New test case.
        * jit.dg/test-error-mismatching-types-in-call.c (create_code):
        Avoid using an opaque struct for local "f".

Added:
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
Modified:
    trunk/gcc/jit/ChangeLog
    trunk/gcc/jit/jit-recording.h
    trunk/gcc/jit/libgccjit.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/jit.dg/test-error-mismatching-types-in-call.c

[Bug jit/66783] No error-checking for creating structs containing opaque structs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Author: dmalcolm
Date: Wed Jul  8 14:41:59 2015
New Revision: 225557

URL: https://gcc.gnu.org/viewcvs?rev=225557&root=gcc&view=rev
Log:
PR jit/66783: improve error messages

gcc/jit/ChangeLog:
        PR jit/66783
        * libgccjit.c (gcc_jit_context_new_field): Show name of field in
        "unknown size" error message.
        (gcc_jit_struct_set_fields): Show name of struct in error message.
        (gcc_jit_context_new_global): Show name of global in
        "unknown size" error message.
        (gcc_jit_function_new_local): Likewise for local.

gcc/testsuite/ChangeLog:
        PR jit/66783
        * jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
        (verify_code): Update expected error message.
        * jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
        (verify_code): Likewise.
        * jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c
        (verify_code): Likewise.

Modified:
    trunk/gcc/jit/ChangeLog
    trunk/gcc/jit/libgccjit.c
    trunk/gcc/testsuite/ChangeLog
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_field-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_global-opaque-struct.c
   
trunk/gcc/testsuite/jit.dg/test-error-gcc_jit_function_new_local-opaque-struct.c

[Bug jit/66783] No error-checking for creating structs containing opaque structs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

--- Comment #4 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #3)
> Root cause found: it's because of the langhook:
>   LANG_HOOKS_GET_ALIAS_SET
> which it looks like I need to implement for libgccjit.

Ooops, wrong bug; ignore this comment

[Bug jit/66783] No error-checking for creating structs containing opaque structs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Root cause found: it's because of the langhook:
  LANG_HOOKS_GET_ALIAS_SET
which it looks like I need to implement for libgccjit.

[Bug jit/66783] No error-checking for creating structs containing opaque structs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66783

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-07-17
     Ever confirmed|0                           |1

--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Keeping this open until it's committed to the gcc-5-branch