public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "derodat at adacore dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/66790] Invalid uninitialized register handling in REE Date: Thu, 24 Sep 2015 07:42:00 -0000 [thread overview] Message-ID: <bug-66790-4-v4G3q0yHeW@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-66790-4@http.gcc.gnu.org/bugzilla/> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4338 bytes --] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66790 --- Comment #38 from Pierre-Marie de Rodat <derodat at adacore dot com> --- (In reply to Paolo Bonzini from comment #35) > Is this comment obsolete? The IN bitmap is all set at first. Yes, indeed: I removed the part you quoted. (In reply to Paolo Bonzini from comment #35) > Otherwise looks good. Thank you! Does this include the DF_LIVE fix? (In reply to Bernd Schmidt from comment #36) > This looks better. I still don't quite understand why you're treating > MUST_CLOBBER and MAY_CLOBBER defs differently in simulate. It looks > like a MUST_CLOBBER produces a bit in gen which I think is not what is > wanted. > > Anything wrong with writing this simply as follows? (In reply to Paolo Bonzini from comment #37) > Bernd is right that you have a missing 'else'. Pastos strike back! I updated df_mir_simulate_one_insn according to your suggestion: thank you. Besides, Eric told me live that instead of artificially clearing the entry basic blockâs IN set, we could use the confluence_0 for that. I did this and took this opportunity to minimize code duplication: the df_mir_init function now just calls df_mir_reset. > And, not as a requirement for your patch, but as a point for > discussion - do we want a special all_ones_bitmap that doesn't take up > memory for purposes like this? It would add two additional tests to > each bitmap_{and,ior} operation. Good point, although what would the following yield, then? bitmap_clear (res); bitmap_set_bit (res, 1); bitmap_and_into (res, all_ones_bitmap); I mean: we would need to represent bitmaps will all bits set but one (and by extension: all but several). Anyway, here's the updated patch, bootstrapped and regtested again on x86_64-linux (plus a new testcase in gnat.dg). By the way, there's still the MIR name, as we did not reach a consensus about a better name. >From gcc-bugs-return-497953-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Sep 24 07:43:20 2015 Return-Path: <gcc-bugs-return-497953-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org> Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 67305 invoked by alias); 24 Sep 2015 07:43:20 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-bugs.gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/> List-Post: <mailto:gcc-bugs@gcc.gnu.org> List-Help: <mailto:gcc-bugs-help@gcc.gnu.org> Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 67070 invoked by uid 48); 24 Sep 2015 07:43:16 -0000 From: "derodat at adacore dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/66790] Invalid uninitialized register handling in REE Date: Thu, 24 Sep 2015 07:43:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: rtl-optimization X-Bugzilla-Version: 6.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: derodat at adacore dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: <bug-66790-4-tbZk24sK2t@http.gcc.gnu.org/bugzilla/> In-Reply-To: <bug-66790-4@http.gcc.gnu.org/bugzilla/> References: <bug-66790-4@http.gcc.gnu.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-09/txt/msg01931.txt.bz2 Content-length: 544 https://gcc.gnu.org/bugzilla/show_bug.cgi?idf790 Pierre-Marie de Rodat <derodat at adacore dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36377|0 |1 is obsolete| | --- Comment #39 from Pierre-Marie de Rodat <derodat at adacore dot com> --- Created attachment 36384 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id6384&actioníit Updated candidate patch
next prev parent reply other threads:[~2015-09-24 7:42 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-07 16:05 [Bug rtl-optimization/66790] New: " derodat at adacore dot com 2015-07-07 16:06 ` [Bug rtl-optimization/66790] " derodat at adacore dot com 2015-07-07 16:06 ` derodat at adacore dot com 2015-07-07 16:06 ` derodat at adacore dot com 2015-07-29 13:06 ` rguenth at gcc dot gnu.org 2015-07-30 9:54 ` derodat at adacore dot com 2015-07-31 8:17 ` derodat at adacore dot com 2015-07-31 8:18 ` derodat at adacore dot com 2015-09-10 14:16 ` ebotcazou at gcc dot gnu.org 2015-09-10 14:26 ` derodat at adacore dot com 2015-09-10 14:40 ` ebotcazou at gcc dot gnu.org 2015-09-10 14:44 ` derodat at adacore dot com 2015-09-16 11:45 ` bernds at gcc dot gnu.org 2015-09-16 17:52 ` ebotcazou at gcc dot gnu.org 2015-09-16 22:54 ` bernds at gcc dot gnu.org 2015-09-17 10:21 ` ebotcazou at gcc dot gnu.org 2015-09-17 10:39 ` bernds at gcc dot gnu.org 2015-09-17 11:27 ` bonzini at gnu dot org 2015-09-17 12:52 ` zadeck at naturalbridge dot com 2015-09-17 12:53 ` ebotcazou at gcc dot gnu.org 2015-09-17 14:41 ` zadeck at naturalbridge dot com 2015-09-17 15:36 ` ebotcazou at gcc dot gnu.org 2015-09-17 15:36 ` ebotcazou at gcc dot gnu.org 2015-09-17 15:36 ` ebotcazou at gcc dot gnu.org 2015-09-21 16:32 ` derodat at adacore dot com 2015-09-21 17:04 ` bernds at gcc dot gnu.org 2015-09-22 8:40 ` bonzini at gnu dot org 2015-09-22 9:03 ` ebotcazou at gcc dot gnu.org 2015-09-22 9:14 ` bonzini at gnu dot org 2015-09-23 10:04 ` derodat at adacore dot com 2015-09-23 10:05 ` derodat at adacore dot com 2015-09-23 10:23 ` bonzini at gnu dot org 2015-09-23 10:25 ` bernds at gcc dot gnu.org 2015-09-23 10:26 ` bonzini at gnu dot org 2015-09-24 7:42 ` derodat at adacore dot com [this message] 2015-10-01 5:44 ` derodat at adacore dot com 2015-10-03 10:45 ` bernds at gcc dot gnu.org 2015-10-12 14:47 ` derodat at adacore dot com 2015-10-19 23:48 ` pmderodat at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-66790-4-v4G3q0yHeW@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).