[Bug middle-end/66891] New: ICE in expand_call, at calls.c:3407

[Bug middle-end/66891] New: ICE in expand_call, at calls.c:3407

[alasdairsinc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

            Bug ID: 66891
           Summary: ICE in expand_call, at calls.c:3407
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: alasdairsinc at gmail dot com
  Target Milestone: ---

Created attachment 35992
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35992&action=edit
-save-temps for affected file from wine

I got the following ICE when compiling Wine with the latest trunk rev 225852.
-O0 compiles without error, O1 and O2 both give and ICE.

[ams@hal comctl32]$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/ams/src/gcc/install/libexec/gcc/x86_64-unknown-linux-gnu/6.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc/configure --enable-languages=c,c++
--prefix=/home/ams/src/gcc/install
Thread model: posix
gcc version 6.0.0 20150715 (experimental) (GCC)

[ams@hal comctl32]$ gcc -m32 -oblah -g -O2 propsheet.i -c
../../../wine-git/dlls/comctl32/propsheet.c: In function ‘PROPSHEET_DoCommand’:
../../../wine-git/dlls/comctl32/propsheet.c:3126:10: internal compiler error:
in expand_call, at calls.c:3407
      if (PROPSHEET_Apply(hwnd, wID == IDOK ? 1: 0) == FALSE)
          ^
0x6e191f expand_call(tree_node*, rtx_def*, int)
        ../../gcc/gcc/calls.c:3406
0x7ebe04 expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
expand_modifier, rtx_def**, bool)
        ../../gcc/gcc/expr.c:10362
0x7f9432 store_expr_with_bounds(tree_node*, rtx_def*, int, bool, tree_node*)
        ../../gcc/gcc/expr.c:5398
0x7fba55 expand_assignment(tree_node*, tree_node*, bool)
        ../../gcc/gcc/expr.c:5170
0x6ef386 expand_call_stmt
        ../../gcc/gcc/cfgexpand.c:2350
0x6ef386 expand_gimple_stmt_1
        ../../gcc/gcc/cfgexpand.c:3239
0x6ef386 expand_gimple_stmt
        ../../gcc/gcc/cfgexpand.c:3400
0x6f11fc expand_gimple_basic_block
        ../../gcc/gcc/cfgexpand.c:5412
0x6f7b86 execute
        ../../gcc/gcc/cfgexpand.c:6023
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-492392-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 03:10:04 2015
Return-Path: <gcc-bugs-return-492392-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23581 invoked by alias); 16 Jul 2015 03:10:04 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23461 invoked by uid 48); 16 Jul 2015 03:09:59 -0000
From: "anders.granlund.0 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66892] New: Fix of core language defect 355 has status c++11 but is not implemented yet
Date: Thu, 16 Jul 2015 03:10:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: anders.granlund.0 at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-66892-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01282.txt.bz2
Content-length: 705

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf892

            Bug ID: 66892
           Summary: Fix of core language defect 355 has status c++11 but
                    is not implemented yet
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: anders.granlund.0 at gmail dot com
  Target Milestone: ---

The following core language defect has status c++11 but is not implemented yet:

http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#355

Without implementing this fix gcc doesn't fully support c++11 syntax.

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-16
                 CC|                            |trippels at gcc dot gnu.org,
                   |                            |uros at gcc dot gnu.org
          Component|middle-end                  |rtl-optimization
            Summary|ICE in expand_call, at      |[6 Regression] ICE in
                   |calls.c:3407                |expand_call, at
                   |                            |calls.c:3407
     Ever confirmed|0                           |1

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Started with r225807.

int a;
__attribute__((__stdcall__)) void fn1();
static void fn2() {
  for (;;)
    ;
}
void fn3() {
  fn1(0);
  fn2(a == 0);
}

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-*-*
   Target Milestone|---                         |6.0

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com

--- Comment #2 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fun with global variables ...

Patch in testing:

--cut here--
Index: calls.c
===================================================================
--- calls.c     (revision 225857)
+++ calls.c     (working copy)
@@ -3144,6 +3144,10 @@ expand_call (tree exp, rtx target, int ignore)

       compute_argument_addresses (args, argblock, num_actuals);

+      /* Stack is properly aligned, pops can't safely be deferred during
+        the evaluation of the arguments.  */
+      NO_DEFER_POP;
+
       /* Precompute all register parameters.  It isn't safe to compute
         anything once we have started filling any specific hard regs.
         TLS symbols sometimes need a call to resolve.  Precompute
@@ -3151,6 +3155,8 @@ expand_call (tree exp, rtx target, int ignore)
         to avoid unaligned stack in the called function.  */
       precompute_register_parameters (num_actuals, args, &reg_parm_seen);

+      OK_DEFER_POP;
+
       /* Perform stack alignment before the first push (the last arg).  */
       if (argblock == 0
           && adjusted_args_size.constant > reg_parm_stack_space
--cut here--
>From gcc-bugs-return-492411-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 09:10:48 2015
Return-Path: <gcc-bugs-return-492411-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8407 invoked by alias); 16 Jul 2015 09:10:48 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7777 invoked by uid 48); 16 Jul 2015 09:10:43 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66814] ICE: gcc.target/i386/avx512f-klogic-2.c
Date: Thu, 16 Jul 2015 09:10:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ubizjak at gmail dot com
X-Bugzilla-Target-Milestone: 5.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: target_milestone
Message-ID: <bug-66814-4-HX7UXbDeCJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66814-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66814-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01300.txt.bz2
Content-length: 423

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf814

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.2                         |5.3

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 5.2 is being released, adjusting target milestone to 5.3.

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
*** Bug 66898 has been marked as a duplicate of this bug. ***

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

--- Comment #4 from uros at gcc dot gnu.org ---
Author: uros
Date: Fri Jul 17 06:32:58 2015
New Revision: 225918

URL: https://gcc.gnu.org/viewcvs?rev=225918&root=gcc&view=rev
Log:
        PR rtl-optimization/66891
        * calls.c (expand_call): Wrap precompute_register_parameters with
        NO_DEFER_POP/OK_DEFER_POP to prevent deferred pops.

testsuite/ChangeLog:

        PR target/66891
        * gcc.target/i386/pr66891.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr66891.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/calls.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-*-*                  |x86
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-492599-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jul 17 06:55:55 2015
Return-Path: <gcc-bugs-return-492599-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 115005 invoked by alias); 17 Jul 2015 06:55:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 114960 invoked by uid 48); 17 Jul 2015 06:55:50 -0000
From: "antoshkka at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/58265] [lwg/2063] std::string move assignment should be noexcept
Date: Fri, 17 Jul 2015 06:55:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: antoshkka at gmail dot com
X-Bugzilla-Status: SUSPENDED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-58265-4-Ctkc5XDHoe@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58265-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58265-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01489.txt.bz2
Content-length: 576

https://gcc.gnu.org/bugzilla/show_bug.cgi?idX265

Antony Polukhin <antoshkka at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antoshkka at gmail dot com

--- Comment #7 from Antony Polukhin <antoshkka at gmail dot com> ---
Wht's the status of this issue?

Issue still exists in GCC 5.1. Latest wording
http://cplusplus.github.io/LWG/lwg-defects.html#2063 insists on making move
assignment conditionally noexcept.

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

--- Comment #6 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu Jul 23 18:51:56 2015
New Revision: 226119

URL: https://gcc.gnu.org/viewcvs?rev=226119&root=gcc&view=rev
Log:
        Backport from mainline:
        2015-07-17  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/66891
        * calls.c (expand_call): Wrap precompute_register_parameters with
        NO_DEFER_POP/OK_DEFER_POP to prevent deferred pops.

        2015-07-15  Uros Bizjak  <ubizjak@gmail.com>

        PR target/58066
        * config/i386/i386.md (*tls_global_dynamic_64_<mode>): Depend on
SP_REG.
        (*tls_local_dynamic_base_64_<mode>): Ditto.
        (*tls_local_dynamic_base_64_largepic): Ditto.
        (tls_global_dynamic_64_<mode>): Update expander pattern.
        (tls_local_dynamic_base_64_<mode>): Ditto.

        2015-07-15  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/58066
        * calls.c (expand_call): Precompute register parameters before stack

testsuite/ChangeLog:

        Backport from mainline:
        2015-07-17  Uros Bizjak  <ubizjak@gmail.com>

        PR target/66891
        * gcc.target/i386/pr66891.c: New test.


Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.target/i386/pr66891.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/calls.c
    branches/gcc-5-branch/gcc/config/i386/i386.md
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/66891] [6 Regression] ICE in expand_call, at calls.c:3407

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66891

--- Comment #7 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu Jul 30 08:53:48 2015
New Revision: 226389

URL: https://gcc.gnu.org/viewcvs?rev=226389&root=gcc&view=rev
Log:
        Backport from mainline:
        2015-07-17  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/66891
        * calls.c (expand_call): Wrap precompute_register_parameters with
        NO_DEFER_POP/OK_DEFER_POP to prevent deferred pops.

        2015-07-15  Uros Bizjak  <ubizjak@gmail.com>

        PR target/58066
        * config/i386/i386.md (*tls_global_dynamic_64_<mode>): Depend on
SP_REG.
        (*tls_local_dynamic_base_64_<mode>): Ditto.
        (*tls_local_dynamic_base_64_largepic): Ditto.
        (tls_global_dynamic_64_<mode>): Update expander pattern.
        (tls_local_dynamic_base_64_<mode>): Ditto.

        2015-07-15  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/58066
        * calls.c (expand_call): Precompute register parameters before stack
        alignment is performed.

        2014-05-08  Wei Mi  <wmi@google.com>

        PR target/58066
        * config/i386/i386.c (ix86_compute_frame_layout): Update
        preferred_stack_boundary for call, expanded from tls descriptor.
        * config/i386/i386.md (*tls_global_dynamic_32_gnu): Update RTX
        to depend on SP register.
        (*tls_local_dynamic_base_32_gnu): Ditto.
        (*tls_local_dynamic_32_once): Ditto.
        (tls_global_dynamic_64_<mode>): Set
        ix86_tls_descriptor_calls_expanded_in_cfun.
        (tls_local_dynamic_base_64_<mode>): Ditto.
        (tls_global_dynamic_32): Set
        ix86_tls_descriptor_calls_expanded_in_cfun. Update RTX
        to depend on SP register.
        (tls_local_dynamic_base_32): Ditto.

testsuite/ChangeLog:

        Backport from mainline:
        2015-07-17  Uros Bizjak  <ubizjak@gmail.com>

        PR target/66891
        * gcc.target/i386/pr66891.c: New test.

        2014-05-18  Wei Mi  <wmi@google.com>

        PR target/58066
        * gcc.target/i386/pr58066.c: Replace pattern matching of .cfi
        directive with rtl insns. Add effective-target fpic and
        tls_native.

        2014-05-08  Wei Mi  <wmi@google.com>

        PR target/58066
        * gcc.target/i386/pr58066.c: New test.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr58066.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr66891.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/i386/i386.c
    branches/gcc-4_9-branch/gcc/config/i386/i386.md
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog