[Bug c++/66896] New: ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[Bug c++/66896] New: ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

            Bug ID: 66896
           Summary: ipa-prop.c:2479 runtime error: member call on null
                    pointer of type 'struct ipa_polymorphic_call_context'
           Product: gcc
           Version: 5.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zeccav at gmail dot com
  Target Milestone: ---

//must be compiled with -O2 , or "-O[1] -fdevirtualize"
//ipa-prop.c:2479:30: runtime error: member call on null pointer of type
'struct ipa_polymorphic_call_context'
//gcc ipa-prop.c source line "dst_ctx->combine_with (ctx);"
//because dst_ctx is NULL
//double checked with "gcc_assert(dst_ctx);"
void f2 (void *);
void f3 ();

struct A
{
  int *a;
  A ();
  ~A () { a3 (); }
  int a1 (int * p) { if (!p) f3 (); f2 (p); }
  void a3 () { if (*a) a1 (a); }
};

struct B : A {~B () { a3 ();}};

struct F {};

struct G : F {B g;};

void foo () {G g;}

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 35994
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35994&action=edit
Suggested patch
>From gcc-bugs-return-492529-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 09:45:24 2015
Return-Path: <gcc-bugs-return-492529-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 128598 invoked by alias); 16 Jul 2015 09:45:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 128523 invoked by uid 48); 16 Jul 2015 09:45:20 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/7651] Define -Wextra strictly in terms of other warning flags
Date: Thu, 16 Jul 2015 09:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: target_milestone
Message-ID: <bug-7651-4-gf6NU2OJNf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-7651-4@http.gcc.gnu.org/bugzilla/>
References: <bug-7651-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01419.txt.bz2
Content-length: 449

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7651

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.3                         |---

--- Comment #33 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
non-regressions should not have target milestones.
>From gcc-bugs-return-492530-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 09:57:19 2015
Return-Path: <gcc-bugs-return-492530-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32974 invoked by alias); 16 Jul 2015 09:57:18 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32922 invoked by uid 48); 16 Jul 2015 09:57:14 -0000
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/66760] [4.9/5/6 Regression] compile time regression in IPA inline analysis on PR26854 testcase
Date: Thu, 16 Jul 2015 09:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: compile-time-hog, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jamborm at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66760-4-bNC4IaSBBz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66760-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66760-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01420.txt.bz2
Content-length: 309

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf760

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I have committed the patch to trunk as r225838 but unfortunately
forgot to mention the bug in the commit message.  If there are no
issues, I will backport it to the gcc 5 branch next week.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Author: marxin
Date: Thu Jul 16 14:48:18 2015
New Revision: 225887

URL: https://gcc.gnu.org/viewcvs?rev=225887&root=gcc&view=rev
Log:
Fix PR ipa/66896.

        * g++.dg/ipa/pr66896.c: New test.
        PR ipa/66896.
        * ipa-prop.c (update_jump_functions_after_inlining): Create properly
        dst_ctx if it does not exist.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-prop.c
    trunk/gcc/testsuite/ChangeLog
>From gcc-bugs-return-492550-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 14:52:23 2015
Return-Path: <gcc-bugs-return-492550-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 46730 invoked by alias); 16 Jul 2015 14:52:23 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 46696 invoked by uid 48); 16 Jul 2015 14:52:19 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/66737] ld: warning: -z bndplt ignored
Date: Thu, 16 Jul 2015 14:52:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66737-4-RX5Rjugksk@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66737-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66737-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01440.txt.bz2
Content-length: 952

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf737

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Ilya Enkovich from comment #4)
> OK then.  Testing this patch now:
>
> diff --git a/gcc/config/i386/linux-common.h b/gcc/config/i386/linux-common.h
> index 63dd8d8..232acea 100644
> --- a/gcc/config/i386/linux-common.h
> +++ b/gcc/config/i386/linux-common.h
> @@ -70,9 +70,15 @@ along with GCC; see the file COPYING3.  If not see
>  #endif
>  #endif
>
> +#if TARGET_64BIT_DEFAULT
> +#define MPX_ARCH_64 "!m32:"
> +#else
> +#define MPX_ARCH_64 "m64:"
> +#endif
> +
>  #ifndef MPX_SPEC
>  #define MPX_SPEC "\
> - %{mmpx:%{fcheck-pointer-bounds:%{!static:" LINK_MPX "}}}"
> + %{mmpx:%{fcheck-pointer-bounds:%{!static:%{" MPX_ARCH_64 LINK_MPX "}}}}"
>  #endif
>
>  #ifndef LIBMPX_SPEC

I don't think it is correct.  Please see SPEC_64 and SPEC_32 defined
in gnu-user64.h.  You should define MPX_SPEC with SPEC_64 and SPEC_32.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Author: marxin
Date: Thu Jul 16 14:53:08 2015
New Revision: 225888

URL: https://gcc.gnu.org/viewcvs?rev=225888&root=gcc&view=rev
Log:
Fix PR ipa/66896.

        * g++.dg/ipa/pr66896.c: New test.
        PR ipa/66896.
        * ipa-prop.c (update_jump_functions_after_inlining): Create properly
        dst_ctx if it does not exist.

Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/ipa-prop.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
>From gcc-bugs-return-492553-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 14:55:11 2015
Return-Path: <gcc-bugs-return-492553-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 53165 invoked by alias); 16 Jul 2015 14:55:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 52829 invoked by uid 48); 16 Jul 2015 14:55:06 -0000
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'
Date: Thu, 16 Jul 2015 14:55:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.1.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: marxin at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: marxin at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-66896-4-ZpnBCnRs3M@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66896-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66896-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01443.txt.bz2
Content-length: 464

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed in both trunk and gcc-5 branch.
>From gcc-bugs-return-492554-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 16 15:06:25 2015
Return-Path: <gcc-bugs-return-492554-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 86620 invoked by alias); 16 Jul 2015 15:06:25 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 86556 invoked by uid 48); 16 Jul 2015 15:06:17 -0000
From: "ienkovich at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/66737] ld: warning: -z bndplt ignored
Date: Thu, 16 Jul 2015 15:06:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ienkovich at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66737-4-rL0iAJD0Jf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66737-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66737-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01444.txt.bz2
Content-length: 405

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf737

--- Comment #6 from Ilya Enkovich <ienkovich at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #5)
> I don't think it is correct.  Please see SPEC_64 and SPEC_32 defined
> in gnu-user64.h.  You should define MPX_SPEC with SPEC_64 and SPEC_32.

It should be OK since we don't support MPX for other than m32 and m64.  Will
try with SPEC_64 also.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #5 from Vittorio Zecca <zeccav at gmail dot com> ---
Yes I applied the fix and it now works on all the gcc testsuite.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #6 from Vittorio Zecca <zeccav at gmail dot com> ---
I just found the same issue at line 2479:
dst_ctx->combine_with (ctx);
dst_ctx is again NULL
Maybe the same patch should be applied here? Namely:
if (!dst_ctx)
                        {
                          vec_safe_grow_cleared
(args->polymorphic_call_contexts,
                                                 count);
                          dst_ctx =
ipa_get_ith_polymorhic_call_context (args, i);
                        }
immediately before?
Do you need a reproducer?
This is compiling pythia software.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu.org

--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #6)
> I just found the same issue at line 2479:

As even the the gcc-5 branch is changing slightly, line numbers on
their own are not are not the best indicator of the position of the
code you refer to.

> dst_ctx->combine_with (ctx);
> dst_ctx is again NULL
> Maybe the same patch should be applied here? Namely:
> if (!dst_ctx)
>                         {
>                           vec_safe_grow_cleared
> (args->polymorphic_call_contexts,
>                                                  count);
>                           dst_ctx =
> ipa_get_ith_polymorhic_call_context (args, i);
>                         }
> immediately before?

I have looked at both occurrences of dst_ctx->combine_with (ctx) in
function update_jump_functions_after_inlining and they are all
guarded with the code just as you describe.

> Do you need a reproducer?

Yes please, I cannot see the error you describe.  Thanks.

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #8 from Vittorio Zecca <zeccav at gmail dot com> ---
Created attachment 36052
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36052&action=edit
To be compiled with -O2

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #9 from Vittorio Zecca <zeccav at gmail dot com> ---
At line 2473 of ipa-prop.c I have

if (!ctx.useless_p ())
I changed it into 

if (!ctx.useless_p () || !dst_ctx)

Now the sanitizer runtime error message disappears.
I am attaching another source, gccerr20-bis.C, that used to force
update_jump_functions_after_inlining to reference a NULL pointer dst_ctx

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #10 from Martin Jambor <jamborm at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #8)
> Created attachment 36052 [details]
> To be compiled with -O2

This compiles fine for me (with -O2) both with the current trunk and
the current gcc 5 branch.

(In reply to Vittorio Zecca from comment #9)
> At line 2473 of ipa-prop.c I have
> 
> if (!ctx.useless_p ())
> I changed it into 
> 
> if (!ctx.useless_p () || !dst_ctx)
> 
> Now the sanitizer runtime error message disappears.

What sanitizer error?

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #11 from Vittorio Zecca <zeccav at gmail dot com> ---
I have a version of gcc 5.2.0 compiled with the -fsanitize=undefined option.
This sanitized version gave me a runtime error due to dereferencing
the pointer dst_ctx
which was NULL. After the change I suggested the message disappeared.

You may double check my finding, as I did myself, by putting

assert(dst_ctx)

before its dereferencing in ipa-prop.c as in

assert(dst_ctx),dst_ctx->combine_with (ctx);

It happens twice in isa-prop.c

Then try it with the two C codes I sent, with option -O2

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #12 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #11)
> I have a version of gcc 5.2.0 compiled with the -fsanitize=undefined option.
> This sanitized version gave me a runtime error due to dereferencing
> the pointer dst_ctx
> which was NULL. After the change I suggested the message disappeared.
> 
> You may double check my finding, as I did myself, by putting
> 
> assert(dst_ctx)
> 
> before its dereferencing in ipa-prop.c as in
> 
> assert(dst_ctx),dst_ctx->combine_with (ctx);
> 
> It happens twice in isa-prop.c
> 
> Then try it with the two C codes I sent, with option -O2

Hello.

I double-checked that there's no other NULL dereferencing in ipa-prop.c.

Can you please confirm that gcc-5-branch works correctly?

Thanks,
Martin
>From gcc-bugs-return-494196-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Aug 05 16:16:16 2015
Return-Path: <gcc-bugs-return-494196-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 121097 invoked by alias); 5 Aug 2015 16:16:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 121009 invoked by uid 55); 5 Aug 2015 16:16:12 -0000
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/64921] [4.9/5/6 Regression] FAIL: gfortran.dg/class_allocate_18.f90
Date: Wed, 05 Aug 2015 16:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mikael at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: mikael at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64921-4-WyYi5Kniqd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64921-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64921-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg00338.txt.bz2
Content-length: 758

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd921

--- Comment #27 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Wed Aug  5 16:15:40 2015
New Revision: 226636

URL: https://gcc.gnu.org/viewcvs?rev"6636&root=gcc&view=rev
Log:
Fix random class_allocate_18.f90 failure

        PR fortran/64921
gcc/fortran/
        * class.c (generate_finalization_wrapper): Set finalization
        procedure symbol's always_explicit attribute.
gcc/testsuite/
        * gfortran.dg/class_allocate_20.f90: New.


Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/class_allocate_20.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/class.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug ipa/66896] ipa-prop.c:2479 runtime error: member call on null pointer of type 'struct ipa_polymorphic_call_context'

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896

--- Comment #13 from Vittorio Zecca <zeccav at gmail dot com> ---
I see only two NULL dereferencing in ipa-prop.c my lines 2479 and 2545
same statement

dst_ctx->combine_with (ctx);

Did you take care of both of them?