[Bug fortran/66927] New: [6.0 regression] ICE in gfc_conf_procedure_call

[Bug fortran/66927] New: [6.0 regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

            Bug ID: 66927
           Summary: [6.0 regression] ICE in gfc_conf_procedure_call
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: juergen.reuter at desy dot de
  Target Milestone: ---

An ICE happens when trying to allocate an allocatable array with explicit array
bounds in combination with a source expression:

gfortran  -c processes.f90
processes.f90:31:0:

          source = t3%int_born%func ())
1
internal compiler error: in gfc_conv_procedure_call, at
fortran/trans-expr.c:5754

processes.f90:31:0: internal compiler error: Abort trap: 6

with the following code (maybe can be reduced even a little further):

module processes
  implicit none
  private

  type :: t1_t
     real :: p = 0.0
  end type t1_t

  type :: t2_t
     private
     type(t1_t), dimension(:), allocatable :: p
   contains
     procedure :: func => t2_func
  end type t2_t

  type :: t3_t
    type(t2_t), public :: int_born
  end type t3_t

contains

  function t2_func (int) result (p)
    class(t2_t), intent(in) :: int
    type(t1_t), dimension(:), allocatable :: p
  end function t2_func

  subroutine evaluate (t3)
    class(t3_t), intent(inout) :: t3
    type(t1_t), dimension(:), allocatable :: p_born    
    allocate (p_born(1:size(t3%int_born%func ())), &
         source = t3%int_born%func ())
  end subroutine evaluate

end module processes

[Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #1 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Forgot: my gcc svn revision is r224763.
>From gcc-bugs-return-492727-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 18 09:51:14 2015
Return-Path: <gcc-bugs-return-492727-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 128321 invoked by alias); 18 Jul 2015 09:51:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 128287 invoked by uid 55); 18 Jul 2015 09:51:09 -0000
From: "uros at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66922] wrong code for bit-field struct at -O1 and above on x86_64-linux-gnu
Date: Sat, 18 Jul 2015 09:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: uros at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66922-4-RyOBsutZSz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66922-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66922-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01617.txt.bz2
Content-length: 688

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf922

--- Comment #2 from uros at gcc dot gnu.org ---
Author: uros
Date: Sat Jul 18 09:50:37 2015
New Revision: 225980

URL: https://gcc.gnu.org/viewcvs?rev"5980&root=gcc&view=rev
Log:
        PR target/66922
        * config/i386/i386.c (ix86_expand_pextr): Reject extractions
        from misaligned positions.
        (ix86_expand_pinsr): Reject insertions to misaligned positions.

testsuite/ChangeLog:

        PR target/66922
        * gcc.target/i386/pr66922.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr66922.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-18
     Ever confirmed|0                           |1

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Revision r223090 (2015-05-12) is OK, revision r223694 (2015-05-26) gives the
ICE.

[Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #3 from vehre at gcc dot gnu.org ---
F2008, C633 says:

(R631) If allocate-object is an array either allocate-shape-spec-list shall
appear or source-expr shall appear and have the same rank as allocate-object.
If allocate-object is scalar, allocate-shape-spec-list shall not appear.

So you can fix your code, by removing the array-description from the object to
allocate. I am aware, that this kind of code is motivated by former gfortran
not being able to take the array-spec from the source= expression. But now it
is.

[Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #4 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Actually, we are using now

allocate (obj(1:size (func ()))
obj = func ()

as you are saying 
allocate (obj, source = func ())
had problems in gfortran 4.7.X. 
So the issue is not a problem for our code(s). 

But you are saying that the code triggering the ICE violates the Fortran
standard?
>From gcc-bugs-return-492731-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 18 10:15:32 2015
Return-Path: <gcc-bugs-return-492731-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 72443 invoked by alias); 18 Jul 2015 10:15:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 72397 invoked by uid 48); 18 Jul 2015 10:15:28 -0000
From: "vehre at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call
Date: Sat, 18 Jul 2015 10:15:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vehre at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-66927-4-u4plBNf9U4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01621.txt.bz2
Content-length: 795

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf927

vehre at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vehre at gcc dot gnu.org

--- Comment #5 from vehre at gcc dot gnu.org ---
I am not that bold anymore to interpret the nasty standard. I wanted to
express, that the allocate(obj, source=func()) is now sufficient.

I made some bad experience trying to interpret the standard and was told off
not to do so. Therefore, I will not say "yes, it violates the standard" nor
"no, it doesn't".

Given there are many programs, that use the work-around you've shown, I am
unsure what to do here. But you are right, ICE'ing is a no go.

[Bug fortran/66927] [6.0 regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #6 from vehre at gcc dot gnu.org ---
This fixes the issue:

diff --git a/gcc/fortran/trans-stmt.c b/gcc/fortran/trans-stmt.c
index 6409f7f..181cbce 100644
--- a/gcc/fortran/trans-stmt.c
+++ b/gcc/fortran/trans-stmt.c
@@ -5189,7 +5189,9 @@ gfc_trans_allocate (gfc_code * code)
          /* Get the descriptor for all arrays, that are not allocatable or
             pointer, because the latter are descriptors already.  */
          attr = gfc_expr_attr (code->expr3);
-         if (code->expr3->rank != 0 && !attr.allocatable && !attr.pointer)
+         if (code->expr3->rank != 0 && ((!attr.allocatable && !attr.pointer)
+                                  || (code->expr3->expr_type == EXPR_FUNCTION
+                                      && code->expr3->ts.type != BT_CLASS)))
            gfc_conv_expr_descriptor (&se, code->expr3);
          else
            gfc_conv_expr_reference (&se, code->expr3);

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |6.0
   Target Milestone|---                         |6.0
            Summary|[6.0 regression] ICE in     |[6 Regression] ICE in
                   |gfc_conf_procedure_call     |gfc_conf_procedure_call

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

vehre at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |vehre at gcc dot gnu.org

--- Comment #7 from vehre at gcc dot gnu.org ---
Currently checking whether the bug can be fixed more elegantly.

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #8 from vehre at gcc dot gnu.org ---
More elaborate patch available at:

https://gcc.gnu.org/ml/fortran/2015-09/msg00142.html

This patch also handles functions for source= that return a class object.

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #9 from vehre at gcc dot gnu.org ---
Author: vehre
Date: Sun Oct 25 12:28:57 2015
New Revision: 229294

URL: https://gcc.gnu.org/viewcvs?rev=229294&root=gcc&view=rev
Log:
gcc/fortran/ChangeLog:

2015-10-25  Andre Vehreschild  <vehre@gcc.gnu.org>

        PR fortran/66927
        PR fortran/67044
        * trans-array.c (build_array_ref): Modified call to 
        gfc_get_class_array_ref to adhere to new interface.
        (gfc_conv_expr_descriptor): For one-based arrays that
        are filled by a loop starting at one the start index of the
        source array has to be mangled into the offset.
        * trans-expr.c (gfc_get_class_array_ref): When the tree to get
        the _data component is present already, add a way to supply it.
        (gfc_copy_class_to_class): Allow to copy to a derived type also.
        * trans-stmt.c (gfc_trans_allocate): Do not conv_expr_descriptor
        for functions returning a class or derived object. Get the
        reference instead.
        * trans.h: Interface change of gfc_get_class_array_ref.

gcc/testsuite/ChangeLog:

2015-10-25  Andre Vehreschild  <vehre@gmx.de>

        PR fortran/66927
        PR fortran/67044
        * gfortran.dg/allocate_with_source_10.f08: New test.
        * gfortran.dg/allocate_with_source_11.f08: New test.
        * gfortran.dg/class_array_15.f03: Changed count of expected
        _builtin_frees to 11. One step of temporaries is spared, therefore
        the allocatable component of that temporary is not to be freeed.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/class_array_15.f03

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #10 from vehre at gcc dot gnu.org ---
Author: vehre
Date: Sun Oct 25 13:02:32 2015
New Revision: 229295

URL: https://gcc.gnu.org/viewcvs?rev=229295&root=gcc&view=rev
Log:
Added missing testcases of r229294 for patch of
PR fortran/66927.


Added:
    trunk/gcc/testsuite/gfortran.dg/allocate_with_source_10.f08
    trunk/gcc/testsuite/gfortran.dg/allocate_with_source_11.f08

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #11 from H.J. Lu <hjl.tools at gmail dot com> ---
On Linux/ia32, I got

spawn [open ...]^M
*** Error in `./allocate_with_source_10.exe': free(): invalid next size (fast):
0x09dcebc8 ***

Program received signal SIGSEGV: Segmentation fault - invalid memory reference.

Backtrace for this error:
#0  0xf7766bdf in ???
#1  0x456e2e68 in ???
#2  0x456e5a03 in ???
#3  0x456e7c5e in ???
#4  0x45658960 in ???
#5  0x4565ebf2 in ???
#6  0x4565a4e3 in ???
#7  0x4565e481 in ???
#8  0x457a35fb in ???
#9  0x4565a4e3 in ???
#10  0x457a36f0 in ???
#11  0x45777192 in ???
#12  0x45777424 in ???
#13  0x45688969 in ???
#14  0x456dbf12 in ???
#15  0x456e4899 in ???
#16  0x456e7f3f in ???
#17  0x804916e in ???
#18  0x80492a2 in ???
#19  0x80492e2 in ???
#20  0x456896f4 in ???
#21  0x8048780 in ???
FAIL: gfortran.dg/allocate_with_source_10.f08   -O0  execution test

GCC is configured with

--prefix=/usr/6.0.0 --enable-clocale=gnu --with-system-zlib --enable-shared
--with-demangler-in-ld --enable-libmpx i686-linux --with-fpmath=sse
--enable-languages=c,c++,fortran,java,lto,objc

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #12 from vehre at gcc dot gnu.org ---
I can confirm that issue. Don't know how to fix it yet, though. Looks like the
scalarizer is not coping correctly with a AS_DEFERRED array.

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[vehre at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #13 from vehre at gcc dot gnu.org ---
Author: vehre
Date: Mon Oct 26 13:03:22 2015
New Revision: 229353

URL: https://gcc.gnu.org/viewcvs?rev=229353&root=gcc&view=rev
Log:
gcc/fortran/ChangeLog:

2015-10-26  Andre Vehreschild  <vehre@gcc.gnu.org>

        PR fortran/66927
        * trans-array.c (evaluate_bound): For deferred length arrays get the
        bounds directly from the descriptor, i.e., prevent using constant
        zero lower bound from the gfc_conv_array_lbound () routine.
        (gfc_conv_section_startstride): Hand deferred array status to
        evaluate_bound ().
        (gfc_conv_expr_descriptor): Same.



Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-array.c

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #14 from Jürgen Reuter <juergen.reuter at desy dot de> ---
These changes seem to break our code. Will provide an example in a minute.
>From gcc-bugs-return-500627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 26 23:27:54 2015
Return-Path: <gcc-bugs-return-500627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 19217 invoked by alias); 26 Oct 2015 23:27:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19192 invoked by uid 55); 26 Oct 2015 23:27:50 -0000
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/68065] Size calculations for VLAs can overflow
Date: Mon, 26 Oct 2015 23:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: joseph at codesourcery dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-68065-4-2CrHyqJx2V@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-68065-4@http.gcc.gnu.org/bugzilla/>
References: <bug-68065-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02182.txt.bz2
Content-length: 817

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh065

--- Comment #4 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Mon, 26 Oct 2015, ch3root at openwall dot com wrote:

> The core issue is an overflow in size computations which is not limited to VLA.
> You can as easily get a crash with non-VLA-array+sizeof+malloc:
>
> #define N /* complex computation leading to.. */ (UINT_MAX / sizeof(int) + 2)
>   int (*p)[N];

That sounds like a completely separate bug.  Please file a separate bug in
Bugzilla for it.  Any construction of a non-VLA type whose size is half or
more of the address space should receive a compile-time error, like you
get if you don't use a pointer here.

VLA size overflow, however, is undefined behavior at runtime, not compile
time, hence a matter for ubsan.

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #15 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Here it it:
{{{
module lexers
  implicit none
  private
  type :: template_t
     private
     character(256) :: charset1
     integer :: len1
  end type template_t

contains

  subroutine match_quoted (tt, s, n)
    type(template_t), intent(in) :: tt
    character(*), intent(in) :: s
    integer, intent(out) :: n
    character(tt%len1) :: ch1
    ch1 = tt%charset1
  end subroutine match_quoted

end module lexers
}}}
I believe this comes from your commit, so I don't open up a new ticket. Would
be cool if this can be solved quickly.
>From gcc-bugs-return-500629-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 26 23:51:39 2015
Return-Path: <gcc-bugs-return-500629-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12960 invoked by alias); 26 Oct 2015 23:51:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12832 invoked by uid 48); 26 Oct 2015 23:51:35 -0000
From: "ch3root at openwall dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/68107] New: Non-VLA type whose size is half or more of the address space constructed via a pointer
Date: Mon, 26 Oct 2015 23:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ch3root at openwall dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-68107-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02184.txt.bz2
Content-length: 1146

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh107

            Bug ID: 68107
           Summary: Non-VLA type whose size is half or more of the address
                    space constructed via a pointer
           Product: gcc
           Version: 5.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ch3root at openwall dot com
  Target Milestone: ---

Due to an overflow in size calculation the following (seemingly reasonable)
program compiles fine, allocates too small array and crashes in a loop:

#include <stdint.h>
#include <stdlib.h>
#include <stdio.h>

#define N (SIZE_MAX / sizeof(int) + 2)

int main(void)
{
  int (*p)[N];
  printf("%zu\n", sizeof *p);
  p = malloc(sizeof *p);
  if (!p)
    return 1;
  for (size_t i = 0; i < N; i++)
    (*p)[i] = 1;

  return 0;
}

According to https://gcc.gnu.org/bugzilla/show_bug.cgi?idh065#c4 : "Any
construction of a non-VLA type whose size is half or more of the address space
should receive a compile-time error, like you get if you don't use a pointer
here."

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #16 from kargl at gcc dot gnu.org ---
(In reply to Jürgen Reuter from comment #15)
> Here it it:
> {{{
> module lexers
>   implicit none
>   private
>   type :: template_t
>      private
>      character(256) :: charset1
>      integer :: len1
>   end type template_t
> 
> contains
> 
>   subroutine match_quoted (tt, s, n)
>     type(template_t), intent(in) :: tt
>     character(*), intent(in) :: s
>     integer, intent(out) :: n
>     character(tt%len1) :: ch1
>     ch1 = tt%charset1
>   end subroutine match_quoted
> 
> end module lexers
> }}}
> I believe this comes from your commit, so I don't open up a new ticket.
> Would be cool if this can be solved quickly.

I doubt that it is related to Andre's patch as nothing in the above
code uses ALLOCATE.  The error messages is also one that I just
introduced.  So, submit a PR.
>From gcc-bugs-return-500637-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 27 01:00:53 2015
Return-Path: <gcc-bugs-return-500637-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 111950 invoked by alias); 27 Oct 2015 01:00:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 111922 invoked by uid 48); 27 Oct 2015 01:00:49 -0000
From: "juergen.reuter at desy dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/68108] New: [6.0 regression] erroneous error message 'scalar integer expression expected'
Date: Tue, 27 Oct 2015 01:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: juergen.reuter at desy dot de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-68108-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02192.txt.bz2
Content-length: 1100

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh108

            Bug ID: 68108
           Summary: [6.0 regression] erroneous error message 'scalar
                    integer expression expected'
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: juergen.reuter at desy dot de
  Target Milestone: ---

The following code doesn't compile anymore but used to at least until ca.
r227300 of gcc:
module lexers
  implicit none
  private
  type :: template_t
     private
     character(256) :: charset1
     integer :: len1
  end type template_t

contains

  subroutine match_quoted (tt, s, n)
    type(template_t), intent(in) :: tt
    character(*), intent(in) :: s
    integer, intent(out) :: n
    character(tt%len1) :: ch1
    ch1 = tt%charset1
  end subroutine match_quoted

end module lexers
This leads to the error message:
lexers.f90:16:14:
   character(tt%len1) :: ch1
Error: Scalar INTEGER expression expected at (1)

[Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call

[juergen.reuter at desy dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #17 from Jürgen Reuter <juergen.reuter at desy dot de> ---
Done, 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68108
>From gcc-bugs-return-500639-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 27 01:08:57 2015
Return-Path: <gcc-bugs-return-500639-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 117447 invoked by alias); 27 Oct 2015 01:08:57 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 117392 invoked by uid 55); 27 Oct 2015 01:08:53 -0000
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call
Date: Tue, 27 Oct 2015 01:08:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sgk at troutmask dot apl.washington.edu
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: vehre at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66927-4-AyRYAc7z5p@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02194.txt.bz2
Content-length: 488

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #18 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Tue, Oct 27, 2015 at 01:01:37AM +0000, juergen.reuter at desy dot de wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927
> 
> --- Comment #17 from Jürgen Reuter <juergen.reuter at desy dot de> ---
> Done, 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68108
> 

I may have a patch already written.  Need to run testsuite.
>From gcc-bugs-return-500640-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 27 01:09:24 2015
Return-Path: <gcc-bugs-return-500640-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 118291 invoked by alias); 27 Oct 2015 01:09:23 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 118227 invoked by uid 55); 27 Oct 2015 01:09:18 -0000
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66927] [6 Regression] ICE in gfc_conf_procedure_call
Date: Tue, 27 Oct 2015 01:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sgk at troutmask dot apl.washington.edu
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: vehre at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66927-4-EiwSsMTSzp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66927-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02195.txt.bz2
Content-length: 488

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927

--- Comment #19 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Tue, Oct 27, 2015 at 01:01:37AM +0000, juergen.reuter at desy dot de wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66927
> 
> --- Comment #17 from Jürgen Reuter <juergen.reuter at desy dot de> ---
> Done, 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68108
> 

I may have a patch already written.  Need to run testsuite.
>From gcc-bugs-return-500641-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 27 01:11:41 2015
Return-Path: <gcc-bugs-return-500641-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 40694 invoked by alias); 27 Oct 2015 01:11:40 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 35605 invoked by uid 48); 27 Oct 2015 01:11:36 -0000
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/68108] [6.0 regression] erroneous error message 'scalar integer expression expected'
Date: Tue, 27 Oct 2015 01:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: kargl at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: kargl at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on cc assigned_to everconfirmed
Message-ID: <bug-68108-4-sIjTNHelF9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-68108-4@http.gcc.gnu.org/bugzilla/>
References: <bug-68108-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02196.txt.bz2
Content-length: 1485

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh108

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-10-27
                 CC|                            |kargl at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |kargl at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from kargl at gcc dot gnu.org ---
This looks like fallout from my patch for PR fortran/67805.

2015-10-24  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/67805
        * array.c (gfc_match_array_constructor): Check for error from type
        spec matching.
        * decl.c (char_len_param_value): Check for valid of charlen parameter.
        Reap dead code dating to 2008.
        match.c (gfc_match_type_spec): Special case the keyword use in REAL.

Tentative patch

Index: decl.c
==================================================================--- decl.c      (revision 229390)
+++ decl.c      (working copy)
@@ -754,7 +754,8 @@ char_len_param_value (gfc_expr **expr, b

       gfc_reduce_init_expr (e);

-      if ((e->ref && e->ref->u.ar.type != AR_ELEMENT)
+      if ((e->ref && e->ref->type == REF_ARRAY
+          && e->ref->u.ar.type != AR_ELEMENT)
          || (!e->ref && e->expr_type == EXPR_ARRAY))