public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "keith.marshall at mailinator dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/66936] io/unix.c gratuitously uses S_IRWXG and S_IRWXO on the basis that umask() is available
Date: Sun, 19 Jul 2015 21:04:00 -0000 [thread overview]
Message-ID: <bug-66936-4-IDEzIgUIAZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-66936-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66936
--- Comment #6 from Keith Marshall <keith.marshall at mailinator dot com> ---
(In reply to kargl from comment #4)
> Update title. The code in question is
>
> #ifdef HAVE_UMASK
> /* Temporarily set the umask such that the file has 0600 permissions. */
> mode_mask = umask (S_IXUSR | S_IRWXG | S_IRWXO);
> #endif
>
> MinGW appears to define HAVE_UMASK, but MinGW seems to lack
> a correctly written umask(3).
Just for the record: MinGW has had access to Microsoft's umask() implementation
for a very long time; HAVE_UMASK has always been defined, when compiling the
mingw32 builds of GCC. However, this particular block of code is encapsulated
within an outer #ifdef HAVE_MKSTEMP block, and it is only recently that MinGW
has provided an implementation of mkstemp(), (Microsoft do not offer one),
which has caused HAVE_MKSTEMP to become defined, so exposing this (presumably
long-standing) bug.
next prev parent reply other threads:[~2015-07-19 21:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 15:14 [Bug libfortran/66936] New: io/unix.c gratuitously uses S_IRWXG and S_IRWXO on the basis that mkstemp() " keith.marshall at mailinator dot com
2015-07-19 15:44 ` [Bug libfortran/66936] " kargl at gcc dot gnu.org
2015-07-19 17:29 ` keith.marshall at mailinator dot com
2015-07-19 18:05 ` sgk at troutmask dot apl.washington.edu
2015-07-19 18:05 ` kargl at gcc dot gnu.org
2015-07-19 19:52 ` [Bug libfortran/66936] io/unix.c gratuitously uses S_IRWXG and S_IRWXO on the basis that umask() " kargl at gcc dot gnu.org
2015-07-19 20:50 ` keith.marshall at mailinator dot com
2015-07-19 21:04 ` keith.marshall at mailinator dot com [this message]
2015-07-19 21:42 ` kargl at gcc dot gnu.org
2015-07-19 22:17 ` keith.marshall at mailinator dot com
2015-07-20 9:19 ` pinskia at gcc dot gnu.org
2015-07-20 15:26 ` keith.marshall at mailinator dot com
2015-08-06 16:57 ` fxcoudert at gcc dot gnu.org
2015-08-06 18:11 ` sgk at troutmask dot apl.washington.edu
2015-08-06 18:14 ` fxcoudert at gcc dot gnu.org
2015-08-09 8:53 ` fxcoudert at gcc dot gnu.org
2015-08-09 16:02 ` sgk at troutmask dot apl.washington.edu
2015-08-09 16:44 ` fxcoudert at gcc dot gnu.org
2015-08-09 16:47 ` fxcoudert at gcc dot gnu.org
2015-08-18 17:56 ` keith.marshall at mailinator dot com
2015-08-18 19:58 ` fxcoudert at gcc dot gnu.org
2015-08-18 20:03 ` fxcoudert at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-66936-4-IDEzIgUIAZ@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).