[Bug c++/66954] New: function multiversioning fails for target "aes"

[Bug c++/66954] New: function multiversioning fails for target "aes"

[jens.maurer at gmx dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66954

            Bug ID: 66954
           Summary: function multiversioning fails for target "aes"
           Product: gcc
           Version: 5.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jens.maurer at gmx dot net
  Target Milestone: ---

I would like to switch implementations depending on whether the (Intel) CPU has
AES instructions or not.  Simplified testcase:


__attribute__((target("default")))
void foo()
{ }

__attribute__((target("aes")))
void foo()
{ }

int main()
{
  void (*f)() = &foo;
}


yields

> g++ target-aes.cc 
target-aes.cc: In function '<built-in>':
target-aes.cc:7:6: error: No dispatcher found for aes
 void foo()
      ^

[Bug target/66954] function multiversioning fails for target "aes"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66954

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-*-*, i?86-*-*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-21
          Component|c++                         |target
     Ever confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug target/66954] function multiversioning fails for target "aes"

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66954

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com
   Target Milestone|---                         |6.0

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-493046-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jul 22 18:09:22 2015
Return-Path: <gcc-bugs-return-493046-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13535 invoked by alias); 22 Jul 2015 18:09:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13515 invoked by uid 48); 22 Jul 2015 18:09:19 -0000
From: "pavel at zhukoff dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/66972] New: Ada.Directories doesn't recognize dangling symlinks
Date: Wed, 22 Jul 2015 18:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pavel at zhukoff dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-66972-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-07/txt/msg01936.txt.bz2
Content-length: 1115

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf972

            Bug ID: 66972
           Summary: Ada.Directories doesn't recognize dangling symlinks
           Product: gcc
           Version: 5.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pavel at zhukoff dot net
  Target Milestone: ---

If symlink is broken Ada.Directories.Exists returns False (actually it's
because stat64 returns ENOENT in __gnat_stat).

Easy to reproduce:
mkdir 'test' && cd 'test' && touch target && ln -s target link && rm target &&
cd - && ./del

where del is:
with Ada.Directories;
procedure del is
begin
  Ada.Directories.Delete_Tree ("test");
end del;


The problem is even worse if Ada.Direcotiries.Delete_Tree was called and
symlink's target was deleted before the symlink itself.
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory tree rooted at ".uuid" could not
be deleted


The similar issue was reported already but closed with UNCONFIRMED:
https://gcc.gnu.org/bugzilla/show_bug.cgi?idc222

[Bug target/66954] function multiversioning fails for target "aes"

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66954

--- Comment #4 from uros at gcc dot gnu.org ---
Author: uros
Date: Tue Aug 11 17:53:41 2015
New Revision: 226784

URL: https://gcc.gnu.org/viewcvs?rev=226784&root=gcc&view=rev
Log:
libgcc/ChangeLog:

        PR target/66954
        * config/i386/cpuinfo.c (enum processor_features): Add FEATURE_PCLMUL.
        (get_available_features): Handle FEATURE_PCLMUL.

gcc/ChangeLog:

        PR target/66954
        * config/i386/i386.c (get_builtin_code_for_version): Add P_PCLMUL
        to enum feature_priority and feature_list.
        (fold_builtin_cpu): Add F_PCLMUL to enum processor_features
        and isa_names_table.

gcc/testsuite/ChangeLog:

        PR target/66954
        * g++.dg/ext/mv25.C: New test.


Added:
    trunk/gcc/testsuite/g++.dg/ext/mv25.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/i386/cpuinfo.c