[Bug target/66956] New: [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[Bug target/66956] New: [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

            Bug ID: 66956
           Summary: [avr] Using 32*32=64 multiplicatiion (umulsidi3) for
                    32=32*32 without MUL.
           Product: gcc
           Version: 5.2.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gjl at gcc dot gnu.org
  Target Milestone: ---
            Target: avr

Created attachment 36020
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36020&action=edit
mul32.c

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-07-21
           Assignee|unassigned at gcc dot gnu.org      |gjl at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Compile that test case with

$ avr-gcc -Os mul32.c -S

Result is something like:

mul_u32:
        rcall __umulsidi3
        mov r22,r18
        mov r23,r19
        mov r24,r20
        mov r25,r21
        ret

mul_s32:
        rcall __mulsidi3
        mov r22,r18
        mov r23,r19
        mov r24,r20
        mov r25,r21
        ret

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

--- Comment #2 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Author: gjl
Date: Tue Jul 21 17:25:48 2015
New Revision: 226046

URL: https://gcc.gnu.org/viewcvs?rev=226046&root=gcc&view=rev
Log:
        PR target/66956
        * config/avr/avr-dimode.md (<extend_u>mulsidi3_insn)
        (<extend_u>mulsidi3): Don't use if !AVR_HAVE_MUL.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-dimode.md

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

--- Comment #3 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Author: gjl
Date: Tue Jul 21 17:29:47 2015
New Revision: 226047

URL: https://gcc.gnu.org/viewcvs?rev=226047&root=gcc&view=rev
Log:
        Backport from 2015-07-21 trunk r226046.
        PR target/66956
        * config/avr/avr-dimode.md (<extend_u>mulsidi3_insn)
        (<extend_u>mulsidi3): Don't use if !AVR_HAVE_MUL.


Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/avr/avr-dimode.md

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

--- Comment #4 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Author: gjl
Date: Tue Jul 21 17:31:22 2015
New Revision: 226048

URL: https://gcc.gnu.org/viewcvs?rev=226048&root=gcc&view=rev
Log:
        Backport from 2015-07-21 trunk r226046.
        PR target/66956
        * config/avr/avr-dimode.md (<extend_u>mulsidi3_insn)
        (<extend_u>mulsidi3): Don't use if !AVR_HAVE_MUL.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/avr/avr-dimode.md

[Bug target/66956] [avr] Using 32*32=64 multiplicatiion (umulsidi3) for 32=32*32 without MUL.

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66956

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.9.4
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.3
      Known to fail|                            |4.9.3, 5.2.1

--- Comment #5 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Fixed in 5.3, 4.9.4.