[Bug middle-end/67034] New: [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[Bug middle-end/67034] New: [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

            Bug ID: 67034
           Summary: [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
                CC: aoliva at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa2.0w-hp-hpux11.11
            Target: hppa2.0w-hp-hpux11.11
             Build: hppa2.0w-hp-hpux11.11

Executing on host: /test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/ 
-fno-diagnostics-show-caret -fdiagnostics-color=never    -O0  -w -c   -o
pr39928-1
.o /test/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/pr39928-1.c   
(timeout
 = 300)
spawn /test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/
-fno-diagnostics-show-caret -fdiagnostics-color=never -O0 -w -c -o pr39928-1.o
/test/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/pr39928-1.c/test/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/pr39928-1.c:
In function '
vq_nbest':/test/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/compile/pr39928-1.c:6:1:
internal compiler error: in emit_move_insn, at expr.c:3552
libbacktrace could not find executable to openPlease submit a full bug report,

This is with r226194.

  gcc_assert (mode != BLKmode
              && (GET_MODE (y) == mode || GET_MODE (y) == VOIDmode));

(gdb) bt
Python Exception <type 'exceptions.ImportError'> Failed to load
/home/gnu/lib/python2.7/lib-dynload/itertools.sl: 
#0  _Z14emit_move_insnP7rtx_defS0_ (x=0x7aebd1f0, y=0x7aebd450)
    at ../../gcc/gcc/expr.c:3552
#1  0x0092426c in
_ZL21assign_parm_setup_regP20assign_parm_data_allP9tree_nodeP20assign_parm_data_one
(all=0x7eff0c78, parm=0x7aeb4190, data=0x7eff0d60)
    at ../../gcc/gcc/function.c:3322
#2  0x00926c5c in _ZL12assign_parmsP9tree_node (fndecl=0x7aeb5080)
    at ../../gcc/gcc/function.c:3766
#3  0x0092e500 in _Z21expand_function_startP9tree_node (subr=0x7aeb5080)
    at ../../gcc/gcc/function.c:5192
#4  0x004bd08c in _ZN12_GLOBAL__N_111pass_expand7executeEP8function (
    this=0x404416d0, fun=0x7ae28068) at ../../gcc/gcc/cfgexpand.c:6105
#5  0x012969a4 in _Z16execute_one_passP8opt_pass (pass=0x404416d0)
    at ../../gcc/gcc/passes.c:2319
#6  0x01296df0 in _ZL19execute_pass_list_1P8opt_pass (pass=0x404416d0)
    at ../../gcc/gcc/passes.c:2372
#7  0x01296f14 in _Z17execute_pass_listP8functionP8opt_pass (fn=0x7ae28068, 
    pass=0x4043f240) at ../../gcc/gcc/passes.c:2383
#8  0x0056bd10 in _ZN11cgraph_node6expandEv (this=0x7aeb7000)
    at ../../gcc/gcc/cgraphunit.c:1920
#9  0x0056cf10 in _ZL15output_in_orderb (no_reorder=false)
    at ../../gcc/gcc/cgraphunit.c:2158
#10 0x0056dc5c in _ZN12symbol_table7compileEv (this=0x7ae28000)
    at ../../gcc/gcc/cgraphunit.c:2403
---Type <return> to continue, or q <return> to quit---
#11 0x0056e020 in _ZN12symbol_table25finalize_compilation_unitEv (
    this=0x7ae28000) at ../../gcc/gcc/cgraphunit.c:2496
#12 0x0150c9b0 in _ZL12compile_filev () at ../../gcc/gcc/toplev.c:569
#13 0x01511b9c in _ZL10do_compilev () at ../../gcc/gcc/toplev.c:2042
#14 0x0151224c in _ZN6toplev4mainEiPPc (this=0x7eff06c8, argc=15, 
    argv=0x7eff0554) at ../../gcc/gcc/toplev.c:2143
#15 0x01ec5650 in main (argc=15, argv=0x7eff0554) at ../../gcc/gcc/main.c:39
(gdb) p debug_rtx (x)
(mem/c:BLK (plus:SI (reg/f:SI 91 virtual-stack-vars)
        (const_int 8 [0x8])) [0 d+0 S16 A128])
$1 = 10
(gdb) p debug_rtx (y)
(mem/c:BLK (reg/v:SI 101) [0 d+0 S16 A128])
$2 = 10
(gdb) p mode
$3 = BLKmode

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-07-30
           Assignee|unassigned at gcc dot gnu.org      |aoliva at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
The ICE is fixed with the incremental patch in the git branch aoliva/pr64164. 
I had to introduce code to copy the incoming byref param to the location
assigned by out-of-SSA for the partition holding the default (incoming) SSA
version of the parameter.  I have only inspected the generated code visually to
tell whether the generated code did what I meant it to do, so I'd appreciate
some execution testing too.  John, if you can help with that, would you like
the asm for this one testcase, or is it easy enough for you to give the branch
a round of testing?  Thanks,

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

--- Comment #2 from dave.anglin at bell dot net ---
On 2015-07-30, at 2:18 PM, aoliva at gcc dot gnu.org wrote:

> John, if you can help with that, would you like
> the asm for this one testcase, or is it easy enough for you to give the branch
> a round of testing?

I'll give your branch a try in next round of testing, probably tomorrow.

Dave
--
John David Anglin       dave.anglin@bell.net

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

--- Comment #3 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
In case you haven't yet, don't bother.  The fix is faulty; at least on ppc64le,
the copying doesn't work because it sets up the pseudo with the address of the
object only after the copying is done.  I've got some ideas to avoid the copy
altogether.  I'll keep you posted.  Thanks for now,

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

--- Comment #4 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Ok, it looks like that idea worked, at least on ppc64 and ppc64el; it's
available in the current git branch aoliva/pr64164.  Would you please give it a
try on pa when you have a chance?  Thanks in advance,

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

--- Comment #5 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Author: aoliva
Date: Fri Aug 14 18:51:50 2015
New Revision: 226901

URL: https://gcc.gnu.org/viewcvs?rev=226901&root=gcc&view=rev
Log:
[PR64164] Drop copyrename, use coalescible partition as base when optimizing.

for  gcc/ChangeLog

        PR rtl-optimization/64164
        PR bootstrap/66978
        PR middle-end/66983
        PR rtl-optimization/67000
        PR middle-end/67034
        PR middle-end/67035
        * Makefile.in (OBJS): Drop tree-ssa-copyrename.o.
        * tree-ssa-copyrename.c: Removed.
        * opts.c (default_options_table): Drop -ftree-copyrename.  Add
        -ftree-coalesce-vars.
        * passes.def: Drop all occurrences of pass_rename_ssa_copies.
        * common.opt (ftree-copyrename): Ignore.
        (ftree-coalesce-inlined-vars): Likewise.
        * doc/invoke.texi: Remove the ignored options above.
        * gimple-expr.h (gimple_can_coalesce_p): Move declaration
        * tree-ssa-coalesce.h: ... here.
        * tree-ssa-uncprop.c: Include tree-ssa-coalesce.h and other
        headers required by it.
        * gimple-expr.c (gimple_can_coalesce_p): Allow coalescing
        across variables when flag_tree_coalesce_vars.  Check register
        use and promoted modes to allow coalescing.  Do not coalesce
        maybe-byref parms with SSA_NAMEs of other variables, or
        anonymous SSA_NAMEs.  Moved to tree-ssa-coalesce.c.
        * tree-ssa-live.c (struct tree_int_map_hasher): Move along
        with its member functions to tree-ssa-coalesce.c.
        (var_map_base_init): Likewise.  Renamed to
        compute_samebase_partition_bases.
        (partition_view_normal): Drop want_bases parameter.
        (partition_view_bitmap): Likewise.
        * tree-ssa-live.h: Adjust declarations.
        * tree-ssa-coalesce.c: Include explow.h and cfgexpand.h.
        (build_ssa_conflict_graph): Process PARM_ and RESULT_DECLs's
        default defs at the entry point.
        (dump_part_var_map): New.
        (compute_optimized_partition_bases): New, called by...
        (coalesce_ssa_name): ... when flag_tree_coalesce_vars, instead
        of compute_samebase_partition_bases.  Adjust.
        * alias.c (nonoverlapping_memrefs_p): Disregard gimple-regs.
        * cfgexpand.c (leader_merge, parm_maybe_byref_p): New.
        (ssa_default_def_partition): New.
        (get_rtl_for_parm_ssa_default_def): New.
        (align_local_variable, add_stack_var): Support anonymous SSA
        names.
        (defer_stack_allocation): Likewise.  Declare earlier.
        (set_rtl): Merge exprs and attrs, even for MEMs and non-SSA
        vars.  Update DECL_RTL for PARM_DECLs and RESULT_DECLs too.
        Do no record deferred-allocation marker in
        SA.partition_to_pseudo.
        (expand_stack_vars): Adjust check for the marker in it.
        (expand_one_stack_var_at): Handle anonymous SSA_NAMEs.  Drop
        redundant MEM attr setting.
        (expand_one_stack_var_1): Handle anonymous SSA_NAMEs.  Renamed
        from...
        (expand_one_stack_var): ... this.  New wrapper to check and
        skip already expanded SSA partitions.
        (record_alignment_for_reg_var): New, factored out of...
        (expand_one_var): ... this.
        (expand_one_ssa_partition): New.
        (adjust_one_expanded_partition_var): New.
        (expand_one_register_var): Check and skip already expanded SSA
        partitions.
        (expand_used_vars): Don't create DECLs for anonymous SSA
        names.  Expand all SSA partitions, then adjust all SSA names.
        (pass::execute): Replace the loops that set
        SA.partition_to_pseudo from partition leaders and cleared
        DECL_RTL for multi-location variables, and that which used to
        rename vars and set attrs, with one that clears DECL_RTL and
        checks that PARMs and RESULTs default_defs match DECL_RTL.
        * cfgexpand.h (get_rtl_for_parm_ssa_default_def): Declare.
        * emit-rtl.c: Include stor-layout.h.
        (set_reg_attrs_for_parm): Handle NULL decl.
        (set_reg_attrs_for_decl_rtl): Take mode from expression if
        it's not a DECL.
        * stmt.c (emit_case_decision_tree): Pass it the SSA_NAME
        rather than its possibly-NULL DECL.
        * explow.c (promote_ssa_mode): New.
        * explow.h (promote_ssa_mode): Declare.
        * expr.c (expand_expr_real_1): Handle anonymous SSA_NAMEs.
        (read_complex_part): Export.
        * expr.h (read_complex_part): Declare.
        * cfgexpand.h (parm_maybe_byref_p): Declare.
        * function.c: Include cfgexpand.h.
        (use_register_for_decl): Handle SSA_NAMEs, anonymous or not.
        (use_register_for_parm_decl): Wrapper for the above to
        special-case the result_ptr.
        (rtl_for_parm): Ditto for get_rtl_for_parm_ssa_default_def.
        (split_complex_args): Take assign_parm_data_all argument.
        Pass it to rtl_for_parm.  Set up rtl and context for split
        args.  Reset complex parm before fetching its default decl
        rtl.
        (assign_parms_unsplit_complex): Use the default-def complex
        parm rtl if it matches the components.
        (assign_parms_augmented_arg_list): Adjust.
        (maybe_reset_rtl_for_parm): Reset DECL_RTL of parms with
        multiple locations.  Recognize split complex args.
        (assign_parm_adjust_stack_rtl): Add all and parm arguments,
        for rtl_for_parm.  For SSA-assigned parms, zero stack_parm.
        (assign_parm_setup_block): Prefer SSA-assigned location, and
        fill in its address if the memory location of a maybe-byref
        parm was not assigned by cfgexpand.
        (assign_parm_setup_reg): Likewise.  Adjust its mode as
        needed.  Use entry_parm for equiv if stack_parm is NULL.  Make
        sure passed_pointer parms don't need conversion.  Copy address
        or value as needed.
        (assign_parm_setup_stack): Prefer SSA-assigned location.
        (assign_parms): Maybe reset DECL_RTL of params.  Adjust stack
        rtl before testing for pointer bounds.  Special-case result_ptr.
        (expand_function_start): Maybe reset DECL_RTL of result.
        Prefer SSA-assigned location for result and static chain.
        Factor out DECL_RESULT and SET_DECL_RTL.  Convert static chain
        to Pmode if needed, from H.J. Lu  <hongjiu.lu@intel.com>.
        * tree-outof-ssa.c (insert_value_copy_on_edge): Handle
        anonymous SSA names.  Use promote_ssa_mode.
        (get_temp_reg): Likewise.
        (remove_ssa_form): Adjust.
        * stor-layout.c (layout_decl): Don't set mem attributes of
        non-MEMs.
        * var-tracking.c (dataflow_set_clear_at_call): Take call_insn
        and get its reg_usage for reg invalidation.
        (compute_bb_dataflow): Pass it insn.
        (emit_notes_in_bb): Likewise.

for  gcc/testsuite/ChangeLog

        * gcc.dg/guality/pr54200.c: Add -fno-tree-coalesce-vars.
        * gcc.dg/ssp-1.c: Make counter a register.
        * gcc.dg/ssp-2.c: Likewise.
        * gcc.dg/torture/parm-coalesce.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/parm-coalesce.c
Removed:
    trunk/gcc/tree-ssa-copyrename.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/alias.c
    trunk/gcc/cfgexpand.c
    trunk/gcc/cfgexpand.h
    trunk/gcc/common.opt
    trunk/gcc/doc/invoke.texi
    trunk/gcc/emit-rtl.c
    trunk/gcc/explow.c
    trunk/gcc/explow.h
    trunk/gcc/expr.c
    trunk/gcc/expr.h
    trunk/gcc/function.c
    trunk/gcc/gimple-expr.c
    trunk/gcc/gimple-expr.h
    trunk/gcc/opts.c
    trunk/gcc/passes.def
    trunk/gcc/stmt.c
    trunk/gcc/stor-layout.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/guality/pr54200.c
    trunk/gcc/testsuite/gcc.dg/ssp-1.c
    trunk/gcc/testsuite/gcc.dg/ssp-2.c
    trunk/gcc/tree-outof-ssa.c
    trunk/gcc/tree-ssa-coalesce.c
    trunk/gcc/tree-ssa-coalesce.h
    trunk/gcc/tree-ssa-live.c
    trunk/gcc/tree-ssa-live.h
    trunk/gcc/tree-ssa-uncprop.c
    trunk/gcc/var-tracking.c

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Fixed

[Bug middle-end/67034] [6 Regression] FAIL: gcc.c-torture/compile/pr39928-1.c

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67034
Bug 67034 depends on bug 67227, which changed state.

Bug 67227 Summary: [6 regression] comparison failure in ada/par.o
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67227

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED