public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/67055] [5/6 Regression] Segmentation fault in fold_builtin_alloca_with_align in tree-ssa-ccp.c
Date: Wed, 05 Aug 2015 07:59:00 -0000	[thread overview]
Message-ID: <bug-67055-4-YyDvR5ep2p@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67055-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67055

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
2118      threshold = (unsigned HOST_WIDE_INT)PARAM_VALUE
(PARAM_LARGE_STACK_FRAME);
2119      /* In case the alloca is located at function entry, it has the same
lifetime
2120         as a declared array, so we allow a larger size.  */
2121      block = gimple_block (stmt);
2122      if (!(cfun->after_inlining
2123            && TREE_CODE (BLOCK_SUPERCONTEXT (block)) == FUNCTION_DECL))
2124        threshold /= 10;
2125      if (size > threshold)
2126        return NULL_TREE;
2127
(gdb) p stmt
$2 = <gimple_call 0x7ffff6a57d80>
(gdb) p debug_gimple_stmt (stmt)
# .MEM_11 = VDEF <.MEM_10>
retAddr.2_7 = __builtin_alloca_with_align (128, 64);
$3 = void

so the fix looks obvious (well, in case the alloca_with_align really is
supposed to have no BLOCK which looks pessimizing).

Looks like we've come the

      if (gimple_block (stmt))
        {
... remap block tree ...
        }
      else
        remap_blocks_to_null (DECL_INITIAL (fn), id);

path during inlining.  So the call we inline wasn't associated with any BLOCK.
That's

retval.11_5 = operator new [] (_2(D), _3(D)); [tail call]

which is created from cgraph_node::expand_thunk.  Indeed thunks do not have
any associated BLOCK.

Testing fix.


  parent reply	other threads:[~2015-08-05  7:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 10:49 [Bug c++/67055] New: " balder@yahoo-inc.com
2015-07-29 11:08 ` [Bug c++/67055] " trippels at gcc dot gnu.org
2015-07-29 11:43 ` balder@yahoo-inc.com
2015-07-29 11:45 ` balder@yahoo-inc.com
2015-07-29 11:48 ` balder@yahoo-inc.com
2015-07-29 12:21 ` [Bug tree-optimization/67055] 5/6 Regression] " trippels at gcc dot gnu.org
2015-07-29 12:51 ` [Bug tree-optimization/67055] [5/6 " trippels at gcc dot gnu.org
2015-07-29 12:52 ` trippels at gcc dot gnu.org
2015-07-29 13:01 ` rguenth at gcc dot gnu.org
2015-08-05  4:24 ` hp at gcc dot gnu.org
2015-08-05  7:59 ` rguenth at gcc dot gnu.org [this message]
2015-08-25  7:41 ` [Bug tree-optimization/67055] [5 " trippels at gcc dot gnu.org
2015-09-10 15:51 ` trippels at gcc dot gnu.org
2015-09-21  9:57 ` rguenth at gcc dot gnu.org
2015-09-21  9:57 ` rguenth at gcc dot gnu.org
2015-09-25  8:03 ` trippels at gcc dot gnu.org
2015-10-17 10:08 ` ebotcazou at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-67055-4-YyDvR5ep2p@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).