[Bug bootstrap/67066] New: libstdc++-v3/src/filesystem/dir.cc fails to compile, preventing bootstrapping with libstdcxx-filesystem-ts

[Bug bootstrap/67066] New: libstdc++-v3/src/filesystem/dir.cc fails to compile, preventing bootstrapping with libstdcxx-filesystem-ts

[egall at gwmail dot gwu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

            Bug ID: 67066
           Summary: libstdc++-v3/src/filesystem/dir.cc fails to compile,
                    preventing bootstrapping with libstdcxx-filesystem-ts
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: egall at gwmail dot gwu.edu
  Target Milestone: ---
              Host: x86_64-apple-darwin10.8.0
            Target: x86_64-apple-darwin10.8.0
             Build: x86_64-apple-darwin10.8.0

Created attachment 36091
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36091&action=edit
compiler error output

The error messages are kind of long, so I'll be attaching them. 

My version info:
$ /Users/ericgallager/gcc-git/my_oddly_named_builddir/./gcc/xgcc -v 
Using built-in specs.
COLLECT_GCC=/Users/ericgallager/gcc-git/my_oddly_named_builddir/./gcc/xgcc
Target: x86_64-apple-darwin10.8.0
Configured with: ../configure --enable-libada --enable-libssp
--enable-bootstrap --enable-lto --enable-stage1-languages=all --enable-objc-gc
--enable-vtable-verify --enable-maintainer-mode --disable-werror
--enable-host-shared --enable-languages=c,c++,java,jit,lto,objc,obj-c++
--enable-stage1-checking=all --enable-libstdcxx-time -C --enable-multilib
--enable-multiarch --enable-__cxa_atexit --enable-tls --with-system-libunwind
--enable-secureplt --enable-frame-pointer
--enable-version-specific-runtime-libs --enable-plugin --enable-cxx
--enable-assert --enable-fat --enable-portable-binary --enable-browser-plugin
--enable-gconf-peer --enable-libgcj-debug --enable-gc-debug
--enable-interpreter --enable-aot-compile-rpm --enable-java-home --with-x
--enable-collections --enable-gstreamer-peer --enable-xmlj --enable-qt-peer
--enable-gmp --enable-debug --enable-local-sockets --enable-concept-checks
--without-isl AUTOCONF=autoconf264 AUTOHEADER=autoheader264
AUTOM4TE=autom4te264 AUTORECONF=autoreconf264 AUTOSCAN=autoscan264
AUTOUPDATE=autoupdate264 IFNAMES=ifnames264
Thread model: posix
gcc version 6.0.0 20150604 (experimental) (GCC)

Passing the '--disable-libstdcxx-filesystem-ts' flag (and some less-strict
stage1-checking options) to configure allows the build to proceed past this
point.

[Bug bootstrap/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile, preventing bootstrapping with libstdcxx-filesystem-ts

[egall at gwmail dot gwu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #1 from Eric Gallager <egall at gwmail dot gwu.edu> ---
Created attachment 36092
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36092&action=edit
(compressed) preprocessed source

[Bug bootstrap/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile, preventing bootstrapping with libstdcxx-filesystem-ts

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Don't use --enable-concept-checks

It enforces C++03 semantics, so doesn't really make much sense these days.
Maybe I'll remove the option.

[Bug bootstrap/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile, preventing bootstrapping with libstdcxx-filesystem-ts

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Are you playing "use as many configure options as possible"?

Most of those options are on by default anyway, others don't do anything.

I'm pretty sure --enable-libstdcxx-time is redundant on darwin.

--enable-multiarch is for Debian

Where did you get that command, and if it's causing so much trouble why not try
simplifying it?

[Bug libstdc++/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile with --enable-concept-checks

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-07-30
          Component|bootstrap                   |libstdc++
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
            Summary|libstdc++-v3/src/filesystem |libstdc++-v3/src/filesystem
                   |/dir.cc fails to compile,   |/dir.cc fails to compile
                   |preventing bootstrapping    |with
                   |with                        |--enable-concept-checks
                   |libstdcxx-filesystem-ts     |
     Ever confirmed|0                           |1
           Severity|normal                      |minor

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The attached errors show that --enable-concept-checks is completely
incompatible with the Filesystem library, because it relies on using
std::vector in C++14 code and the concept checks enforce C++03 rules.

Enabling those checks at build time basically says you want a C++ standard
library that only supports C++03, in which case you can't use the C++
Filesystem library which is based on C++14.

I can make the build work by disabling the concept checks while building
libstdc++fs.a but you still won't be able to use the resulting library unless
you also disable them when using it.

So you might as well just not configure them to be enabled.

[Bug libstdc++/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile with --enable-concept-checks

[egall at gwmail dot gwu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #5 from Eric Gallager <egall at gwmail dot gwu.edu> ---
(In reply to Jonathan Wakely from comment #3)
> Are you playing "use as many configure options as possible"?

Yeah, basically (as many interesting-looking ones as possible, at least). I can
confirm that removing the --enable-concept-checks flag works.

[Bug libstdc++/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile with --enable-concept-checks

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Tue Aug 18 18:04:32 2015
New Revision: 226984

URL: https://gcc.gnu.org/viewcvs?rev=226984&root=gcc&view=rev
Log:
        PR libstdc++/67066
        * doc/xml/manual/configure.xml (manual.intro.setup.configure): Add
        caveats for --enable-concept-checks. Improve link text.
        * doc/xml/manual/diagnostics.xml (std.diagnostics.concept_checking):
        Clarify caveats.
        * doc/html/*: Regenerate.
        * include/bits/stl_deque.h (deque): Only use concept checks in C++03.
        * include/bits/stl_stack.h (stack): Likewise.
        * include/bits/stl_vector.h (vector): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/doc/html/manual/concept_checking.html
    trunk/libstdc++-v3/doc/html/manual/configure.html
    trunk/libstdc++-v3/doc/html/manual/status.html
    trunk/libstdc++-v3/doc/xml/manual/configure.xml
    trunk/libstdc++-v3/doc/xml/manual/diagnostics.xml
    trunk/libstdc++-v3/include/bits/stl_deque.h
    trunk/libstdc++-v3/include/bits/stl_stack.h
    trunk/libstdc++-v3/include/bits/stl_vector.h

[Bug libstdc++/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile with --enable-concept-checks

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |6.0

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk.

The filesystem library is now enabled on the gcc-5-branch too, but I'm not
making this change there. Just don't use --enable-concept-checks in combination
with the filesystem library (better yet, don't use --enable-concept-checks at
all).

[Bug libstdc++/67066] libstdc++-v3/src/filesystem/dir.cc fails to compile with --enable-concept-checks

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67066

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I don't think the --help output is the right place to explain it. My preference
would be to simply deprecate the option anyway.