From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id A26F2385BF93; Tue, 25 Jan 2022 17:47:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A26F2385BF93 From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/67102] Parallel build fails in libffi/configure Date: Tue, 25 Jan 2022 17:47:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Version: unknown X-Bugzilla-Keywords: build, patch X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 17:47:25 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D67102 --- Comment #6 from CVS Commits --- The master branch has been updated by Thomas Schwinge : https://gcc.gnu.org/g:aeac414923aa1e87986c7fc6f9b921d89a9b86cf commit r12-6861-gaeac414923aa1e87986c7fc6f9b921d89a9b86cf Author: Thomas Schwinge Date: Tue Jan 25 18:44:02 2022 +0100 Revert "Fix PR 67102: Add libstdc++ dependancy to libffi" [PR67102] This reverts commit db1a65d9364fe72c2fff65fb2dec051728b6f3fa. On 2021-09-17T01:01:39-0700, Andrew Pinski via Gcc-patches wrote: > On Fri, Sep 17, 2021 at 12:46 AM Thomas Schwinge wrote: >> On 2021-09-15T13:56:37-0700, apinski--- via Gcc-patches wrote: >> > The error message is obvious -funconfigured-libstdc++-v3 is used >> > on the g++ command line. So we just add the dependancy. >> >> > --- a/Makefile.def >> > +++ b/Makefile.def >> > @@ -592,6 +592,7 @@ dependencies =3D { module=3Dconfigure-target-f= astjar; on=3Dconfigure-target-zlib; }; >> > dependencies =3D { module=3Dall-target-fastjar; on=3Dall-target-z= lib; }; >> > dependencies =3D { module=3Dconfigure-target-libgo; on=3Dconfigure-target-libffi; }; >> > dependencies =3D { module=3Dconfigure-target-libgo; on=3Dall-target-libstdc++-v3; }; >> > +dependencies =3D { module=3Dconfigure-target-libffi; on=3Dall-target-libstdc++-v3; }; >> > dependencies =3D { module=3Dall-target-libgo; on=3Dall-target-lib= backtrace; }; >> > dependencies =3D { module=3Dall-target-libgo; on=3Dall-target-lib= ffi; }; >> > dependencies =3D { module=3Dall-target-libgo; on=3Dall-target-lib= atomic; }; >> >> I'm confused, because given that this 'Makefile.def' change only has= the >> following effect: >> >> > --- a/Makefile.in >> > +++ b/Makefile.in >> > @@ -61261,6 +61261,7 @@ all-bison: maybe-all-intl >> > all-flex: maybe-all-intl >> > all-m4: maybe-all-intl >> > configure-target-libgo: maybe-all-target-libstdc++-v3 >> > +configure-target-libffi: maybe-all-target-libstdc++-v3 >> > configure-target-liboffloadmic: maybe-configure-target-libgomp >> > all-target-liboffloadmic: maybe-all-target-libgomp >> > configure-target-newlib: maybe-all-binutils >> >> ... isn't that actually a no-op, because we already had such a dependency >> listed? Now twice: >> >> $ grep -n -F 'configure-target-libffi: maybe-all-target-libstdc++-v3' -- Makefile.in >> 61264:configure-target-libffi: maybe-all-target-libstdc++-v3 >> 61372:configure-target-libffi: maybe-all-target-libstdc++-v3 >> >> Compared to the existing one, the one you've added is additionally >> restricted by '@unless gcc-bootstrap'. >> >> I noticed this as I remembered that on our og[...] development branc= hes >> we have a patch in the opposite direction: get rid of this dependency via >> removing 'lang_env_dependencies =3D { module=3Dlibffi; cxx=3Dtrue; }= ;' from >> 'Makefile.def'. See >> >> "Disable libstdc++ dependency for libffi". (Maciej CCed in case you have >> any further thoughts on that.) > > Oh, I see what happened now, the old bug was actually fixed by r6-5415 > which added cxx=3Dtrue. > So yes my patch is actually not needed and can be reverted. > I tried to look to see if there was a dependency was there but for > some reason I did not see it.=