[Bug rtl-optimization/67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86

[Bug rtl-optimization/67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86
   Target Milestone|---                         |6.0
>From gcc-bugs-return-493974-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 03 17:36:15 2015
Return-Path: <gcc-bugs-return-493974-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 106195 invoked by alias); 3 Aug 2015 17:36:15 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 106172 invoked by uid 48); 3 Aug 2015 17:36:11 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/67103] New: [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86
Date: Mon, 03 Aug 2015 17:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-67103-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg00116.txt.bz2
Content-length: 1240

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg103

            Bug ID: 67103
           Summary: [6 Regression]: gcc.target/i386/cmov2.c and
                    gcc.target/i386/cmov3.c FAIL on x86
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ubizjak at gmail dot com
  Target Milestone: ---

Revision r226491 :

[RTL-ifcvt] Improve conditional select ops on immediates

        * ifcvt.c (noce_try_store_flag_constants): Make logic of the case
        when diff == STORE_FLAG_VALUE or diff == -STORE_FLAG_VALUE more
        explicit.  Prefer to add the flag whenever possible.
        (noce_process_if_block): Try noce_try_store_flag_constants before
        noce_try_cmove.

        * gcc.target/aarch64/csel_bfx_1.c: New test.
        * gcc.target/aarch64/csel_imms_inc_1.c: Likewise.

introduced following testsuite failures on x86:

FAIL: gcc.target/i386/cmov2.c scan-assembler sbb
FAIL: gcc.target/i386/cmov3.c scan-assembler cmov[^3]

The report and a discussion is at [1].

[1] https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00056.html

[Bug rtl-optimization/67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-08-03
                 CC|                            |ktkachov at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |ktkachov at gcc dot gnu.org
     Ever confirmed|0                           |1
      Known to fail|                            |6.0

--- Comment #1 from ktkachov at gcc dot gnu.org ---
Mine.

[Bug rtl-optimization/67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103

--- Comment #2 from ktkachov at gcc dot gnu.org ---
Author: ktkachov
Date: Thu Aug 13 09:11:13 2015
New Revision: 226853

URL: https://gcc.gnu.org/viewcvs?rev=226853&root=gcc&view=rev
Log:
[RTL-ifcvt] Improve conditional select ops on immediates (fix failing x86_64
cmov tests)

        PR rtl-optimization/67103
        * ifcvt.c (noce_try_store_flag_constants): Move
        x = (-(test != 0) & (b - a)) + a transformation to...
        (noce_try_cmove): ... Here.  Try it if normal conditional
        move fails.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ifcvt.c

[Bug rtl-optimization/67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from ktkachov at gcc dot gnu.org ---
Fixed.