[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #2 from kargl at gcc dot gnu.org ---
Created attachment 36144
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36144&action=edit
patch

Patched built and tested with OP's code.
Regression test passed.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #4 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Sat, Aug 08, 2015 at 05:50:03PM +0000, fxcoudert at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140
> 
> Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |fxcoudert at gcc dot gnu.org
> 
> --- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
> (In reply to kargl from comment #2)
> > Patched built and tested with OP's code.
> > Regression test passed.
> 
> Patch approved for trunk, with the following testcase (just double-check that
> it passes!):
> 

Thanks! I'll take of this later today.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #5 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Mon Aug 10 17:42:00 2015
New Revision: 226764

URL: https://gcc.gnu.org/viewcvs?rev=226764&root=gcc&view=rev
Log:
2015-08-10  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR libfortran/67140
        * gfortran.map: Add _gfortran_mvbits_i16.
        * intrinsics/mvbits.c: Generate mvbits for c_int128_t.

2015-08-10  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>

        PR libfortran/67140
        * gfortran.dg/pr67140.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr67140.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/gfortran.map
    trunk/libgfortran/intrinsics/mvbits.c

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from kargl at gcc dot gnu.org ---
Fixed on trunk.  

The GFORTRAN_1.6 section of the symbol map where I've inserted
the _gfortan_mvbits_i16 symbol does not exist in 5-branch.  If
the other functions in this section are backported, then this
function can also be backported.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to kargl from comment #6)
> Fixed on trunk.  
> 
> The GFORTRAN_1.6 section of the symbol map where I've inserted
> the _gfortan_mvbits_i16 symbol does not exist in 5-branch.  If
> the other functions in this section are backported, then this
> function can also be backported.

On Linux/x86, I got

../../../src-trunk/libgfortran/intrinsics/mvbits.c:87:16: error: unknown type
name ‘GFC_INTEGER_16’
 #  define TYPE GFC_INTEGER_16
                ^
../../../src-trunk/libgfortran/intrinsics/mvbits.c:36:29: note: in expansion of
macro ‘TYPE’
 extern void SUB_NAME (const TYPE *, const int *, const int *, TYPE *,
>From gcc-bugs-return-494525-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 10 21:33:54 2015
Return-Path: <gcc-bugs-return-494525-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 87838 invoked by alias); 10 Aug 2015 21:33:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 87785 invoked by uid 55); 10 Aug 2015 21:33:50 -0000
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16
Date: Mon, 10 Aug 2015 21:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libfortran
X-Bugzilla-Version: 4.8.4
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sgk at troutmask dot apl.washington.edu
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: kargl at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67140-4-VEApqtIaBS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67140-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67140-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg00667.txt.bz2
Content-length: 1541

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg140

--- Comment #8 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Aug 10, 2015 at 09:24:53PM +0000, hjl.tools at gmail dot com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?idg140
>
> --- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
> (In reply to kargl from comment #6)
> > Fixed on trunk.
> >
> > The GFORTRAN_1.6 section of the symbol map where I've inserted
> > the _gfortan_mvbits_i16 symbol does not exist in 5-branch.  If
> > the other functions in this section are backported, then this
> > function can also be backported.
>
> On Linux/x86, I got
>
> ../../../src-trunk/libgfortran/intrinsics/mvbits.c:87:16: error: unknown type
> name ???GFC_INTEGER_16???
>  #  define TYPE GFC_INTEGER_16
>                 ^
> ../../../src-trunk/libgfortran/intrinsics/mvbits.c:36:29: note: in expansion of
> macro ???TYPE???
>  extern void SUB_NAME (const TYPE *, const int *, const int *, TYPE *,
>

Sorry about that.  Can you tst this diff?

Index: intrinsics/mvbits.c
==================================================================--- intrinsics/mvbits.c (revision 226764)
+++ intrinsics/mvbits.c (working copy)
@@ -84,6 +84,7 @@ SUB_NAME (const TYPE *from, const int *f
 #  undef TYPE
 #  undef UTYPE

+#if defined (HAVE_GFC_INTEGER_16)
 #  define TYPE GFC_INTEGER_16
 #  define UTYPE GFC_UINTEGER_16
 #  define SUB_NAME mvbits_i16
@@ -92,3 +93,4 @@ SUB_NAME (const TYPE *from, const int *f
 #  undef TYPE
 #  undef UTYPE
 #endif
+#endif

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Steve Kargl from comment #8)
> Sorry about that.  Can you tst this diff?
> 
> Index: intrinsics/mvbits.c
> ===================================================================
> --- intrinsics/mvbits.c (revision 226764)
> +++ intrinsics/mvbits.c (working copy)
> @@ -84,6 +84,7 @@ SUB_NAME (const TYPE *from, const int *f
>  #  undef TYPE
>  #  undef UTYPE
>  
> +#if defined (HAVE_GFC_INTEGER_16)
>  #  define TYPE GFC_INTEGER_16
>  #  define UTYPE GFC_UINTEGER_16
>  #  define SUB_NAME mvbits_i16
> @@ -92,3 +93,4 @@ SUB_NAME (const TYPE *from, const int *f
>  #  undef TYPE
>  #  undef UTYPE
>  #endif
> +#endif

It builds on x86.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #10 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Aug 10, 2015 at 09:40:51PM +0000, hjl.tools at gmail dot com wrote:
> > 
> > Index: intrinsics/mvbits.c
> > ===================================================================
> > --- intrinsics/mvbits.c (revision 226764)
> > +++ intrinsics/mvbits.c (working copy)
> > @@ -84,6 +84,7 @@ SUB_NAME (const TYPE *from, const int *f
> >  #  undef TYPE
> >  #  undef UTYPE
> >  
> > +#if defined (HAVE_GFC_INTEGER_16)
> >  #  define TYPE GFC_INTEGER_16
> >  #  define UTYPE GFC_UINTEGER_16
> >  #  define SUB_NAME mvbits_i16
> > @@ -92,3 +93,4 @@ SUB_NAME (const TYPE *from, const int *f
> >  #  undef TYPE
> >  #  undef UTYPE
> >  #endif
> > +#endif
> 
> It builds on x86.
> 

Thanks.  I'll commit a fix in a few moments.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #12 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Mon Aug 10 21:45:01 2015
New Revision: 226769

URL: https://gcc.gnu.org/viewcvs?rev=226769&root=gcc&view=rev
Log:
2015-08-10  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR libfortran/67140
        * intrinsics/mvbits.c: Fix build for paltforms without c_int128_t.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/intrinsics/mvbits.c

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from kargl at gcc dot gnu.org ---
Reclose.

[Bug libfortran/67140] undefined reference to _gfortran_mvbits_i16

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67140

--- Comment #13 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to kargl from comment #6)
> The GFORTRAN_1.6 section of the symbol map where I've inserted
> the _gfortan_mvbits_i16 symbol does not exist in 5-branch.  If
> the other functions in this section are backported, then this
> function can also be backported.

No a regression, not that critical, so not sure it warrants a backport.