[Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle

[Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67156

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
What target is this on?  Because debugging information generate should not
change the code generation.

[Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle

[dilyan.palauzov at aegee dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67156

--- Comment #2 from Дилян Палаузов <dilyan.palauzov at aegee dot org> ---
It is x86_64-pc-linux-gnu == host == target == build.

To what I see in the root Makefile (copied below) at the end of the build files
in stage2 and stage3 are compared with `cmp', which fails, if one file has
debugging information and the other does not, even if both files have identical
text/data/bss sections.
---
do-compare = cmp --ignore-initial=16 $$f1 $$f2

compare:
        @r=`${PWD_COMMAND}`; export r; \
        s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
        if test -f stage2-lean; then \
          echo Cannot compare object files as stage 2 was deleted.; \
          exit 0; \
        fi; \
        : $(MAKE); $(stage); \
        rm -f .bad_compare; \
        echo Comparing stages 2 and 3; \
        sed=`echo stage3 | sed 's,^stage,,;s,.,.,g'`; \
        files=`find stage3-* -name "*$(objext)" -print | \                      
                 sed -n s,^stage$$sed-,,p`; \
        for file in $${files}; do \
          f1=$$r/stage2-$$file; f2=$$r/stage3-$$file; \
          if test ! -f $$f1; then continue; fi; \
          $(do-compare) > /dev/null 2>&1; \
          if test $$? -eq 1; then \
            case $$file in \
              gcc/cc*-checksum$(objext) | gcc/ada/*tools/*) \
                echo warning: $$file differs ;; \
              *) \
                echo $$file differs >> .bad_compare ;; \
            esac; \
          fi; \
        done; \
        if [ -f .bad_compare ]; then \
          echo "Bootstrap comparison failure!"; \
          cat .bad_compare; \
          exit 1; \
        else \
          echo Comparison successful.; \
        fi; \
        $(STAMP) compare
        if $(LEAN); then \
          rm -rf stage2-*; \
          $(STAMP) stage2-lean; \
        fi
>From gcc-bugs-return-494412-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 08 14:35:35 2015
Return-Path: <gcc-bugs-return-494412-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 45981 invoked by alias); 8 Aug 2015 14:35:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 45954 invoked by uid 48); 8 Aug 2015 14:35:31 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle
Date: Sat, 08 Aug 2015 14:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67156-4-keekewLGsm@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67156-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67156-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg00554.txt.bz2
Content-length: 311

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg156

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It should have stripped out the debugging info before doing the cmp.

That is do-compare gets to be:
do-compare = $(SHELL) $(srcdir)/contrib/compare-debug $$f1 $$f2
>From bootstrap-debug.mk.

[Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67156

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |trippels at gcc dot gnu.org
         Resolution|---                         |INVALID

--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Of course the object files are stripped before the comparison.
See: contrib/compare-debug script.

You should open a new bug with the list of files that differ.

[Bug bootstrap/67156] config/bootstrap-debug.mk: STAGE2_CFLAGS += -gtoggle

[dilyan.palauzov at aegee dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67156

Дилян Палаузов <dilyan.palauzov at aegee dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |---

--- Comment #5 from Дилян Палаузов <dilyan.palauzov at aegee dot org> ---
If do-compare in /Makefile.in is substituted with "$(SHELL)
$(srcdir)/contrib/compare-debug $$f1 $$f2" from "config/bootstrap-debug-big.mk"
or "config/bootstrap-debug-lib.mk" or "config/bootstrap-debug.mk", then
comparing files ignores debug information.  However in my case, do-compare is
substituted with "cmp --ignore-initial=16 $$f1 $$f2" from config/acx.m4 .
Effectively the latter executes
  gcc_cv_prog_cmp_skip='cmp --ignore-initial=16 $$f1 $$f2'
and ./configure contains:

configure-5349-
configure-5350-
configure-5351-$as_echo_n "checking how to compare bootstrapped objects... "
>&6; }
configure:5352:if test "${gcc_cv_prog_cmp_skip+set}" = set; then :
configure-5353-  $as_echo_n "(cached) " >&6
configure-5354-else
configure-5355-   echo abfoo >t1
configure-5356-  echo cdfoo >t2
configure:5357:  gcc_cv_prog_cmp_skip='tail +16c $$f1 > tmp-foo1; tail +16c
$$f2 > tmp-foo2; cmp tmp-foo1 tmp-foo2'
configure-5358-  if cmp t1 t2 2 2 > /dev/null 2>&1; then
configure-5359-    if cmp t1 t2 1 1 > /dev/null 2>&1; then
configure-5360-      :
configure-5361-    else
configure:5362:      gcc_cv_prog_cmp_skip='cmp $$f1 $$f2 16 16'
configure-5363-    fi
configure-5364-  fi
configure-5365-  if cmp --ignore-initial=2 t1 t2 > /dev/null 2>&1; then
configure-5366-    if cmp --ignore-initial=1 t1 t2 > /dev/null 2>&1; then
configure-5367-      :
configure-5368-    else
configure:5369:      gcc_cv_prog_cmp_skip='cmp --ignore-initial=16 $$f1 $$f2'
configure-5370-    fi
configure-5371-  fi
configure-5372-  rm t1 t2
configure-5373-
configure-5374-fi
configure:5375:{ $as_echo "$as_me:${as_lineno-$LINENO}: result:
$gcc_cv_prog_cmp_skip" >&5
configure:5376:$as_echo "$gcc_cv_prog_cmp_skip" >&6; }
configure:5377:do_compare="$gcc_cv_prog_cmp_skip"
configure-5378-

after ./configure config.log contains:

configure:5350: checking how to compare bootstrapped objects
configure:5375: result: cmp --ignore-initial=16 $$f1 $$f2
[...]
do_compare='cmp --ignore-initial=16 $$f1 $$f2'

and config.status contains:
S["do_compare"]="cmp --ignore-initial=16 $$f1 $$f2"

So the problem is why do_compare is cmp and not contrib/compare-debug .
>From gcc-bugs-return-494422-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 08 15:46:22 2015
Return-Path: <gcc-bugs-return-494422-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 84247 invoked by alias); 8 Aug 2015 15:46:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 84206 invoked by uid 48); 8 Aug 2015 15:46:18 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/65151] [SH][4.9 Regression] Internal compiler error when trying to build libav 11.2 on sh4
Date: Sat, 08 Aug 2015 15:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-65151-4-a4v6T7Nk12@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65151-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65151-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg00564.txt.bz2
Content-length: 391

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide151

--- Comment #14 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Thomas Petazzoni from comment #11)
> (In reply to Jakub Jelinek from comment #10)
> > GCC 4.9.3 has been released.
>
> This problem still occurs with GCC 4.9.3, as far as I can see.

The patch in c#7 hasn't been applied.  Thus the bug/problem is still there.