[Bug go/67284] New: libgo fails to build on trunk r227015 / *-linux-gnu

[Bug go/67284] New: libgo fails to build on trunk r227015 / *-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

            Bug ID: 67284
           Summary: libgo fails to build on trunk r227015 / *-linux-gnu
           Product: gcc
           Version: 5.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: doko at gcc dot gnu.org
                CC: cmang at google dot com
  Target Milestone: ---

libgo ftbfs on the trunk r227015

powerpc64le-linux-gnu:

../../../src/libgo/go/encoding/gob/decode.go: In function
'gob.decIgnoreOpFor.pN20_encoding_gob.Decoder':
../../../src/libgo/go/encoding/gob/decode.go:843:1: internal compiler error: in
operator[], at vec.h:714
 func (dec *Decoder) decIgnoreOpFor(wireId typeId) decOp {
 ^


x86_64-linux-gnu (32bit multilib), aarch64-linux-gnu, i686-linux-gnu,
powerpc-linux-gnu:

../../../../src/libgo/go/encoding/gob/decode.go: In function
'gob.decIgnoreOpFor.pN20_encoding_gob.Decoder':
../../../../src/libgo/go/encoding/gob/decode.go:843:1: internal compiler error:
in operator[], at vec.h:714
 func (dec *Decoder) decIgnoreOpFor(wireId typeId) decOp {
 ^
0xacea17 vec<edge_def*, va_gc, vl_embed>::operator[](unsigned int)
        ../../src/gcc/vec.h:714
0xacea17 extract_true_false_edges_from_block(basic_block_def*, edge_def**,
edge_def**)
        ../../src/gcc/tree-cfg.c:8456
0xad71b1 gimple_verify_flow_info
        ../../src/gcc/tree-cfg.c:5260
0x6f2a35 verify_flow_info()
        ../../src/gcc/cfghooks.c:260
0xae7141 cleanup_tree_cfg_noloop
        ../../src/gcc/tree-cfgcleanup.c:739
0xae7141 cleanup_tree_cfg()
        ../../src/gcc/tree-cfgcleanup.c:788
0x9db3f4 execute_function_todo
        ../../src/gcc/passes.c:1900
0x9dbd03 execute_todo
        ../../src/gcc/passes.c:2005
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-snapshot/README.Bugs> for instructions.
Makefile:5201: recipe for target 'encoding/gob.lo' failed
make[10]: *** [encoding/gob.lo] Error 1
make[10]: Leaving directory '/«PKGBUILDDIR»/build/x86_64-linux-gnu/32/libgo'
Makefile:4058: recipe for target 'all-recursive' failed
make[9]: *** [all-recursive] Error 1
>From gcc-bugs-return-495233-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Aug 19 23:55:40 2015
Return-Path: <gcc-bugs-return-495233-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16651 invoked by alias); 19 Aug 2015 23:55:40 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16619 invoked by uid 48); 19 Aug 2015 23:55:36 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/67279] -fsanitize=undefined spurious error: initializer element is not constant
Date: Wed, 19 Aug 2015 23:55:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67279-4-yxbFE8bLnq@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67279-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67279-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg01375.txt.bz2
Content-length: 647

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67279

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #4)
> A possible solution could be to give a warning enabled by default (about 1
> << 31 being undefined) and to NOT sanitize expressions that are required to
> be constants (since anyway the compiler will not accept them).

Indeed, Clang doesn't instrument static initializers. This is a bug on the
C/C++ FEs instrumentation.

I wonder what happens with global static and static const? They do not seem to
be instrumented by the sanitizer.
>From gcc-bugs-return-495234-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Aug 20 01:46:27 2015
Return-Path: <gcc-bugs-return-495234-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 46908 invoked by alias); 20 Aug 2015 01:46:27 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 46853 invoked by uid 55); 20 Aug 2015 01:46:22 -0000
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/66957] [4.9/5/6 Regression] incorrect "is protected within this context" error
Date: Thu, 20 Aug 2015 01:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 5.1.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jason at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66957-4-YYvwg6buLX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66957-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66957-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg01376.txt.bz2
Content-length: 1051

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf957

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Thu Aug 20 01:45:49 2015
New Revision: 227023

URL: https://gcc.gnu.org/viewcvs?rev"7023&root=gcc&view=rev
Log:
        PR c++/66957
        * search.c (protected_accessible_p): Remove redundant access_in_type.
        Add otype parm instead of walking binfo.
        (friend_accessible_p): Check SCOPE itself.  Handle class
        templates.  Pass through otype.
        (dfs_accessible_post): Handle all accessibility cases.
        (dfs_accessible_pre): New.
        (accessible_p): Use it.  Don't check protected access here.  Pass
        decl and otype to dfs_walk.
        (member_declared_in_type, dfs_access_in_type_pre): New.
        (access_in_type): Use dfs_access_in_type_pre.
        * friend.c (add_friend): Fix multiple friends with the same name.

Added:
    trunk/gcc/testsuite/g++.dg/inherit/access9.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/friend.c
    trunk/gcc/cp/search.c

[Bug tree-optimization/67284] libgo fails to build on trunk r227015 / *-linux-gnu

[miyuki at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

Mikhail Maltsev <miyuki at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|powerpc64le-linux-gnu       |powerpc64le-linux-gnu,
                   |                            |x64_64-pc-linux-gnu
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-08-21
                 CC|                            |miyuki at gcc dot gnu.org
          Component|go                          |tree-optimization
           Assignee|ian at airs dot com                |unassigned at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Mikhail Maltsev <miyuki at gcc dot gnu.org> ---
Reduced testcase:

$ cat test.go
package a

type Decoder struct {
        wireType map[int32]*int32
}

func (Decoder) ignoreMap(keyOp, elemOp func())

var decIgnoreOpMap map[int32]func()

func (dec Decoder) decIgnoreOpFor(wireId int32) func() {
        var op func()
        wire := dec.wireType
        if wire != nil {
                keyId := *dec.wireType[wireId]
                elemId := *dec.wireType[wireId]
                keyOp := dec.decIgnoreOpFor(keyId)
                elemOp := dec.decIgnoreOpFor(elemId)
                op = func() {
                        dec.ignoreMap(keyOp, elemOp)
                }
        }
        return op
}

$ ./go1 -O2 test.go
test.go: In function 'a.decIgnoreOpFor.N12_go.a.Decoder':
test.go:11:1: internal compiler error: in operator[], at vec.h:714
 func (dec Decoder) decIgnoreOpFor(wireId int32) func() {
 ^
0x85bcee vec<edge_def*, va_gc, vl_embed>::operator[](unsigned int)
        /home/miyuki/gcc/src/gcc/vec.h:714

[Bug tree-optimization/67284] [6 regression] libgo fails to build on trunk r227015 / *-linux-gnu

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|powerpc64le-linux-gnu,      |powerpc64le-linux-gnu,
                   |x64_64-pc-linux-gnu         |x64_64-pc-linux-gnu,
                   |                            |aarch64-*
            Version|5.2.1                       |6.0
             Blocks|                            |67133
   Target Milestone|---                         |6.0
            Summary|libgo fails to build on     |[6 regression] libgo fails
                   |trunk r227015 / *-linux-gnu |to build on trunk r227015 /
                   |                            |*-linux-gnu


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67133
[Bug 67133] [6 Regression] ICE at -Os and above on x86_64-linux-gnu in
gimple_op, at gimple.h:2274

[Bug tree-optimization/67284] [6 regression] libgo fails to build on trunk r227015 / *-linux-gnu

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Looks like

--- a/gcc/gimple-ssa-isolate-paths.c
+++ b/gcc/gimple-ssa-isolate-paths.c
@@ -115,7 +115,8 @@ insert_trap (gimple_stmt_iterator *si_p, tree op)
   else
     gsi_insert_before (si_p, seq, GSI_NEW_STMT);

-  split_block (gimple_bb (new_stmt), new_stmt);
+  edge e = split_block (gimple_bb (new_stmt), new_stmt);
+  remove_edge (e);
   *si_p = gsi_for_stmt (stmt);
 }

fixes it.

[Bug tree-optimization/67284] [6 regression] libgo fails to build on trunk r227015 / *-linux-gnu

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org

[Bug tree-optimization/67284] [6 regression] libgo fails to build on trunk r227015 / *-linux-gnu

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Aug 24 16:06:02 2015
New Revision: 227134

URL: https://gcc.gnu.org/viewcvs?rev=227134&root=gcc&view=rev
Log:
        PR tree-optimization/67284
        * go-gcc.cc (Gcc_backend::define_builtin): Add NORETURN_P parameter.
        Set TREE_THIS_VOLATILE.
        (Gcc_backend::Gcc_backend): Mark __builtin_trap as a noreturn call.
        Pass false to the rest of define_builtin calls.

Modified:
    trunk/gcc/go/ChangeLog
    trunk/gcc/go/go-gcc.cc

[Bug tree-optimization/67284] [6 regression] libgo fails to build on trunk r227015 / *-linux-gnu

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67284

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Should be fixed.