[Bug libstdc++/67374] New: std::cbegin can't call valarray range access functions

[Bug libstdc++/67374] New: std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

            Bug ID: 67374
           Summary: std::cbegin can't call valarray range access functions
           Product: gcc
           Version: 4.9.4
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: redi at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
  Target Milestone: ---

This fails:

#include <valarray>
#include <iterator>

int main()
{
  std::valarray<int> v;
  std::cbegin(v);
}

The problem is that the begin overloads in <valarray> are not declared before
the non-member functions in <bits/range_access.h> so can't be called from
there.

This works:

namespace std {
    template<class _Tp>
      struct valarray;

    template<class _Tp>
    inline _Tp*
    begin(valarray<_Tp>& __va);

  /**
   *  @brief  Return an iterator pointing to the first element of
   *          the const valarray.
   *  @param  __va  valarray.
   */
  template<class _Tp>
    inline const _Tp*
    begin(const valarray<_Tp>& __va);

}

#include <valarray>
#include <iterator>

int main()
{
  std::valarray<int> v;
  std::cbegin(v);
}

[Bug libstdc++/67374] std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-08-27
     Ever confirmed|0                           |1

[Bug libstdc++/67374] std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.9.4                       |5.2.1
   Target Milestone|---                         |5.3
      Known to fail|                            |5.2.0, 6.0

[Bug libstdc++/67374] std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu Aug 27 19:05:19 2015
New Revision: 227274

URL: https://gcc.gnu.org/viewcvs?rev=227274&root=gcc&view=rev
Log:
        PR libstdc++/67374
        * include/bits/range_access.h (valarray, begin, end): Declare.
        * testsuite/26_numerics/valarray/range_access.cc: Test const
        overloads.
        * testsuite/26_numerics/valarray/range_access2.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/26_numerics/valarray/range_access2.cc
      - copied, changed from r227257,
trunk/libstdc++-v3/testsuite/26_numerics/valarray/range_access.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/range_access.h
    trunk/libstdc++-v3/testsuite/26_numerics/valarray/range_access.cc

[Bug libstdc++/67374] std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu Sep  3 15:10:42 2015
New Revision: 227454

URL: https://gcc.gnu.org/viewcvs?rev=227454&root=gcc&view=rev
Log:
Backport libstdc++/67374 fix from mainline

2015-08-27  Jonathan Wakely  <jwakely@redhat.com>

        PR libstdc++/67374
        * include/bits/range_access.h (valarray, begin, end): Declare.
        * testsuite/26_numerics/valarray/range_access.cc: Test const
        overloads.
        * testsuite/26_numerics/valarray/range_access2.cc: New.

Added:
   
branches/gcc-5-branch/libstdc++-v3/testsuite/26_numerics/valarray/range_access2.cc
      - copied, changed from r227453,
branches/gcc-5-branch/libstdc++-v3/testsuite/26_numerics/valarray/range_access.cc
Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/include/bits/range_access.h
   
branches/gcc-5-branch/libstdc++-v3/testsuite/26_numerics/valarray/range_access.cc

[Bug libstdc++/67374] std::cbegin can't call valarray range access functions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67374

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 5.3