[Bug tree-optimization/67381] New: genmatch does not honor the order of patterns

[Bug tree-optimization/67381] New: genmatch does not honor the order of patterns

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

            Bug ID: 67381
           Summary: genmatch does not honor the order of patterns
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: glisse at gcc dot gnu.org
  Target Milestone: ---

(simplify
 (mult (BUILT_IN_SQRT@1 @0) @1)
 @0)
(simplify
 (mult (BUILT_IN_SQRT @0) (BUILT_IN_SQRT @1))
 (BUILT_IN_SQRT (mult @0 @1)))

We can see in the generated files that it first tests if the second argument is
sqrt before checking if both arguments are the same.

See this thread: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01780.html
It causes a failure in gcc.dg/builtins-11.c

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Ah, because it doesn't consider a match to be "same" as a non-match.

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schwab@linux-m68k.org

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 67389 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hs.naveen2u at gmail dot com

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 67404 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
The related bug is PR64084 btw.

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Mon Aug 31 14:00:16 2015
New Revision: 227344

URL: https://gcc.gnu.org/viewcvs?rev=227344&root=gcc&view=rev
Log:
2015-08-31  Richard Biener  <rguenther@suse.de>

        PR middle-end/67381
        * genmatch.c (dt_node::gen_kids): Also treat matches as barrier.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/genmatch.c

[Bug tree-optimization/67381] genmatch does not honor the order of patterns

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67381

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.