[Bug libfortran/67412] New: gfortran.dg/execute_command_line_2.f90 FAILs

[Bug libfortran/67412] New: gfortran.dg/execute_command_line_2.f90 FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

            Bug ID: 67412
           Summary: gfortran.dg/execute_command_line_2.f90 FAILs
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: fxcoudert at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.10

The new gfortran.dg/execute_command_line_2.f90 test FAILs on Solaris 10:

FAIL: gfortran.dg/execute_command_line_2.f90   -O0  execution test
FAIL: gfortran.dg/execute_command_line_2.f90   -O1  execution test
FAIL: gfortran.dg/execute_command_line_2.f90   -O2  execution test
FAIL: gfortran.dg/execute_command_line_2.f90   -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions  execution test
FAIL: gfortran.dg/execute_command_line_2.f90   -O3 -g  execution test
FAIL: gfortran.dg/execute_command_line_2.f90   -Os  execution test

both 32 and 64-bit.  Solaris 11 and 12 are ok.

In the log, I find

spawn [open ...]^M
sh: /nosuchfile: not found

Program aborted. Backtrace:
#0  0xfee7efdf

Running the testcase under gdb reveals that the c == 0 check causes the abort.

I notice that on Solaris 10, system exits with res = 256 (0x0100), while on
Solaris 12 I get res = 32512 (0x7F00).

Trying the essence of the test manually, I see

* Solaris 10 /bin/sh:

  /nosuchfile => exit code 1

* Solaris 10 /bin/ksh:

  /nosuchfile => exit code 127

It seems the old buggy Solaris /bin/sh is the culprit.  According to the
OpenSolaris sources, per default system(3C) uses /bin/sh, but if linked
with values-xpg4.o (which isn't currently used, while the Studio c89 compiler
does), /usr/xpg4/bin/sh is, which is a posix conformant shell and yields
the correct exit code.

I'm uncertain how best to handle this.

  Rainer

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-08-31
     Ever confirmed|0                           |1

--- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to Rainer Orth from comment #0)
> It seems the old buggy Solaris /bin/sh is the culprit.  According to the
> OpenSolaris sources, per default system(3C) uses /bin/sh, but if linked
> with values-xpg4.o (which isn't currently used, while the Studio c89 compiler
> does), /usr/xpg4/bin/sh is, which is a posix conformant shell and yields
> the correct exit code.
> 
> I'm uncertain how best to handle this.

In Fortran terms, this is really a corner case of the Fortran standard
interaction with the system. So I don't think it is a big deal, especially if
it is fixed on newer Solaris versions.

I suggest simply XFAIL-ing the test case with a link to this PR. If that feels
OK to you, the patch is pre-approved. Thanks for reporting the issue!


PS: I saw that sparc/sparcv9 test results show failures for
gfortran.dg/norm2_3.f90. If you find time at some point, could you open a PR
for it and CC me?

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
> (In reply to Rainer Orth from comment #0)
>> It seems the old buggy Solaris /bin/sh is the culprit.  According to the
>> OpenSolaris sources, per default system(3C) uses /bin/sh, but if linked
>> with values-xpg4.o (which isn't currently used, while the Studio c89 compiler
>> does), /usr/xpg4/bin/sh is, which is a posix conformant shell and yields
>> the correct exit code.
>> 
>> I'm uncertain how best to handle this.
>
> In Fortran terms, this is really a corner case of the Fortran standard
> interaction with the system. So I don't think it is a big deal, especially if
> it is fixed on newer Solaris versions.
>
> I suggest simply XFAIL-ing the test case with a link to this PR. If that feels
> OK to you, the patch is pre-approved. Thanks for reporting the issue!

ok, will do.  Besides, I still mean to revisit the values-xpg[46].o
issue: maybe this will fix this bug as a side effect.

> PS: I saw that sparc/sparcv9 test results show failures for
> gfortran.dg/norm2_3.f90. If you find time at some point, could you open a PR
> for it and CC me?

I know, but only on Solaris 12.  Also, there's
gfortran.dg/large_real_kind_2.F90 that fails at -O0 only.  I still mean
to investigate what's going on there.

        Rainer

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

--- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #2)
> I know, but only on Solaris 12.  Also, there's
> gfortran.dg/large_real_kind_2.F90 that fails at -O0 only.  I still mean
> to investigate what's going on there.

CC me when you do: I'm the contact person for floating point and quad prec
stuff in the Fortran team :)

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
> (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #2)
>> I know, but only on Solaris 12.  Also, there's
>> gfortran.dg/large_real_kind_2.F90 that fails at -O0 only.  I still mean
>> to investigate what's going on there.
>
> CC me when you do: I'm the contact person for floating point and quad prec
> stuff in the Fortran team :)

Done now (PRs fortran/67419 and fortran/67420), no investigation beyond
the location of the aborts.

Thanks.
        Rainer

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
Author: ro
Date: Tue Sep  1 11:50:19 2015
New Revision: 227367

URL: https://gcc.gnu.org/viewcvs?rev=227367&root=gcc&view=rev
Log:
XFAIL gfortran.dg/execute_command_line_2.f90 (PR libfortran/67412)

        PR libfortran/67412
        * gfortran.dg/execute_command_line_2.f90: XFAIL execution on
        *-*-solaris2.10.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/execute_command_line_2.f90

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |SUSPENDED
           Assignee|unassigned at gcc dot gnu.org      |ro at gcc dot gnu.org

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
Suspended; might be fixed as a side-effect of PR target/40411.

  Rainer

[Bug libfortran/67412] gfortran.dg/execute_command_line_2.f90 FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67412

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
> (In reply to Rainer Orth from comment #0)
>> It seems the old buggy Solaris /bin/sh is the culprit.  According to the
>> OpenSolaris sources, per default system(3C) uses /bin/sh, but if linked
>> with values-xpg4.o (which isn't currently used, while the Studio c89 compiler
>> does), /usr/xpg4/bin/sh is, which is a posix conformant shell and yields
>> the correct exit code.
>> 
>> I'm uncertain how best to handle this.
>
> In Fortran terms, this is really a corner case of the Fortran standard
> interaction with the system. So I don't think it is a big deal, especially if
> it is fixed on newer Solaris versions.
>
> I suggest simply XFAIL-ing the test case with a link to this PR. If that feels
> OK to you, the patch is pre-approved. Thanks for reporting the issue!

I'm fine with that: working around bugs of the prehistoric Solaris 10
/bin/sh doesn't exactly seem like a winning proposition to me ;-)

Patch installed as pre-approved.

Thanks.
        Rainer