public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67429] [5/6 Regression] Missing part of error messages.
Date: Fri, 04 Sep 2015 18:38:00 -0000	[thread overview]
Message-ID: <bug-67429-4-AY6gZ1QgfI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67429-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67429

--- Comment #16 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Fri Sep  4 18:37:50 2015
New Revision: 227500

URL: https://gcc.gnu.org/viewcvs?rev=227500&root=gcc&view=rev
Log:
2015-09-04  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR fortran/67429
        * error.c (gfc_clear_pp_buffer): Reset last_location, otherwise
        caret lines might be skipped when actually giving a diagnostic.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/error.c
>From gcc-bugs-return-496397-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 04 18:38:07 2015
Return-Path: <gcc-bugs-return-496397-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 41824 invoked by alias); 4 Sep 2015 18:38:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 41768 invoked by uid 48); 4 Sep 2015 18:38:04 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/60725] [-Wreturn-type] false positive in trivial switch
Date: Fri, 04 Sep 2015 18:38:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60725-4-TXZf8b4moC@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60725-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60725-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg00375.txt.bz2
Content-length: 828

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60725

--- Comment #6 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Martin Sebor from comment #5)
> Not to complicate things too much, but reaching the closing } of a non-void
> function is valid in C.  What is not valid (i.e., has undefined behavior) is
> calling such a function and using its return value when none was provided
> (as in the program in comment #3).  The program in the Description, however,
> has well-defined behavior because f1's return value isn't used.

Good point. I don't know whether it is possible for the sanitizers to
distinguish between the two cases. 

Pretty sure it is not possible for the warning code, since at the time of
warning we know nothing of the callers (not even if there are any callers).
>From gcc-bugs-return-496399-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 04 18:41:44 2015
Return-Path: <gcc-bugs-return-496399-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 50754 invoked by alias); 4 Sep 2015 18:41:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 50705 invoked by uid 55); 4 Sep 2015 18:41:40 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67429] [5/6 Regression] Missing part of error messages.
Date: Fri, 04 Sep 2015 18:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67429-4-ArXZP8nGLk@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67429-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67429-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg00377.txt.bz2
Content-length: 600

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67429

--- Comment #17 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Fri Sep  4 18:41:08 2015
New Revision: 227501

URL: https://gcc.gnu.org/viewcvs?rev=227501&root=gcc&view=rev
Log:
2015-09-04  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR fortran/67429
        * error.c (gfc_clear_pp_buffer): Reset last_location, otherwise
        caret lines might be skipped when actually giving a diagnostic.

Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/error.c
>From gcc-bugs-return-496400-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 04 18:43:59 2015
Return-Path: <gcc-bugs-return-496400-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 65874 invoked by alias); 4 Sep 2015 18:43:58 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 65827 invoked by uid 48); 4 Sep 2015 18:43:55 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67429] [5/6 Regression] Missing part of error messages.
Date: Fri, 04 Sep 2015 18:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-67429-4-0XxDcVm9Qt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67429-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67429-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg00378.txt.bz2
Content-length: 521

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg429

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #18 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed on trunk and 5-branch. Thanks for raising the PR, Dominique, and thanks
for a quick fix, Manuel.

Paul


      parent reply	other threads:[~2015-09-04 18:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 19:55 [Bug fortran/67429] New: " dominiq at lps dot ens.fr
2015-09-01 20:00 ` [Bug fortran/67429] " kargl at gcc dot gnu.org
2015-09-01 20:05 ` dominiq at lps dot ens.fr
2015-09-01 20:13 ` sgk at troutmask dot apl.washington.edu
2015-09-01 20:24 ` dominiq at lps dot ens.fr
2015-09-01 20:46 ` sgk at troutmask dot apl.washington.edu
2015-09-01 21:04 ` pault at gcc dot gnu.org
2015-09-01 21:10 ` pault at gcc dot gnu.org
2015-09-01 22:17 ` dominiq at lps dot ens.fr
2015-09-02  0:30 ` manu at gcc dot gnu.org
2015-09-02  8:56 ` dominiq at lps dot ens.fr
2015-09-02  9:05 ` dominiq at lps dot ens.fr
2015-09-02  9:16 ` rguenth at gcc dot gnu.org
2015-09-02 10:42 ` dominiq at lps dot ens.fr
2015-09-02 18:23 ` pault at gcc dot gnu.org
2015-09-02 18:48 ` manu at gcc dot gnu.org
2015-09-04 18:38 ` pault at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-67429-4-AY6gZ1QgfI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).