public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xuejuncao at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/67433] ?: expression returns unexpected value when condition is a bool variable which memory is not true/false
Date: Wed, 02 Sep 2015 08:11:00 -0000 [thread overview]
Message-ID: <bug-67433-4-BOoFkE7Uai@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67433-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67433
--- Comment #3 from xuejuncao <xuejuncao at gmail dot com> ---
(In reply to Andrew Pinski from comment #2)
> Bool can only be 0 or 1, any other value causes undefined behavior.
but it seems like a trap, the below code will not work fine, and will make
program abort.
(expect to write "1/0" that only takes 1 byte, but write 2 bytes when value is
negative)
https://github.com/google/protobuf/blob/master/src/google/protobuf/wire_format_lite_inl.h
inline void WireFormatLite::WriteBoolNoTag(bool value,
io::CodedOutputStream* output) {
output->WriteVarint32(value ? 1 : 0);
}
next prev parent reply other threads:[~2015-09-02 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-67433-4@http.gcc.gnu.org/bugzilla/>
2015-09-02 7:53 ` xuejuncao at gmail dot com
2015-09-02 7:58 ` pinskia at gcc dot gnu.org
2015-09-02 8:11 ` xuejuncao at gmail dot com [this message]
2015-09-02 8:20 ` xuejuncao at gmail dot com
2015-09-02 8:21 ` pinskia at gcc dot gnu.org
2015-09-02 8:22 ` pinskia at gcc dot gnu.org
2015-09-02 8:33 ` pinskia at gcc dot gnu.org
2015-09-02 9:17 ` trippels at gcc dot gnu.org
2015-09-02 10:15 ` xuejuncao at gmail dot com
2015-09-02 10:20 ` rguenth at gcc dot gnu.org
2015-09-02 10:59 ` xuejuncao at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-67433-4-BOoFkE7Uai@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).