public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sthlm58 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/67434] std::chrono::duration acts like static even if instantiated every time
Date: Thu, 03 Sep 2015 11:55:00 -0000	[thread overview]
Message-ID: <bug-67434-4-ucmC5JtVEP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67434-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67434

--- Comment #2 from sthlm58 at gmail dot com ---
(In reply to Jonathan Wakely from comment #1)
> (In reply to Michal Kucharski from comment #0)
> > std::chrono::duration<double> benchmark( ) 
> > {
> >   std::random_device rd;
> > 
> >   std::chrono::duration<double> total;
> 
> You have not initialized this variable.
> 
> >   
> >   for (int i = 0; i < 100; i++) 
> >   {
> >      auto t1 = std::chrono::high_resolution_clock::now();
> >      auto t2 = std::chrono::high_resolution_clock::now();
> >      total += std::chrono::duration_cast<std::chrono::duration<double>>(t2 -
> > t1);
> 
> This has undefined behaviour because you are performing addition on an
> uninitialized value. You could have found this with valgrind.

In other words, here 'total' was default-initialized (hence unspecified) thus
causing undefined behavior. It it were value-initialized e.g. with '{}' the
problem would not happen.


      parent reply	other threads:[~2015-09-03 11:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 11:15 [Bug libstdc++/67434] New: " sthlm58 at gmail dot com
2015-09-02 11:28 ` [Bug libstdc++/67434] " redi at gcc dot gnu.org
2015-09-03 11:55 ` sthlm58 at gmail dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-67434-4-ucmC5JtVEP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).