[Bug target/67439] ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[Bug target/67439] ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alan.lawrence at arm dot com,
                   |                            |ktkachov at gcc dot gnu.org

--- Comment #1 from ktkachov at gcc dot gnu.org ---
Is -mrestrict-it needed to reproduce this?

[Bug target/67439] ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[alalaw01 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

alalaw01 at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-09-03
                 CC|                            |alalaw01 at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from alalaw01 at gcc dot gnu.org ---
I can reproduce the ICE with -mthumb, both "-mfloat-abi=hard -mfpu=neon" and
"-mfloat-abi=soft", but only with -mrestrict-it in both cases.
"-mfloat-abi=hard -mfpu=neon-fp16" is OK with and without -mrestrict-it.

I note the movhf patterns in vfp.md are only usable with neon-fp16; in other
cases, we appear to be using arm32_movhf in arm.md.

[Bug target/67439] ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.9.4, 5.2.1, 6.0

--- Comment #3 from ktkachov at gcc dot gnu.org ---
Ok, I think I see the problem here.
*arm32_movhf should not just have a !arm_restrict_it in its predicate, it
should disable the alternatives in a smarter way.
I'll see what I can do.

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Target|arm-unknown-linux-gnueabi   |arm*
           Assignee|unassigned at gcc dot gnu.org      |ktkachov at gcc dot gnu.org
            Summary|ICE: unrecognizable insn    |[4.9/5/6 Regression]ICE:
                   |compiling arm-fp16          |unrecognizable insn
                   |testcases with              |compiling arm-fp16
                   |-march=armv7-a and          |testcases with
                   |-mrestrict-it               |-march=armv7-a and
                   |                            |-mrestrict-it

--- Comment #4 from ktkachov at gcc dot gnu.org ---
Mine.

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

--- Comment #5 from ktkachov at gcc dot gnu.org ---
-mrestrict-it was introduced in 4.9 but it's enabled by default for
-march=armv8-a -mthumb. So, while -mrestrict-it did not exist for 4.8, this is
a regression from 4.8 as far as compiling with -march=armv8-a -mthumb is
concerned

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

--- Comment #6 from ktkachov at gcc dot gnu.org ---
Author: ktkachov
Date: Thu Sep 10 10:43:43 2015
New Revision: 227630

URL: https://gcc.gnu.org/viewcvs?rev=227630&root=gcc&view=rev
Log:
[ARM] PR 67439: Allow matching of *arm32_movhf when -mrestrict-it is on

        PR target/67439
        * config/arm/arm.md (*arm32_movhf): Remove !arm_restrict_it from
        predicate.  Set predicable_short_it attr to "no".

        * gcc.target/arm/pr67439_1.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/arm/pr67439_1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.md
    trunk/gcc/testsuite/ChangeLog

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

--- Comment #7 from ktkachov at gcc dot gnu.org ---
Fixed for trunk.
Will backport to 5 and 4.9 in a few days

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

--- Comment #8 from ktkachov at gcc dot gnu.org ---
Author: ktkachov
Date: Wed Sep 23 10:36:48 2015
New Revision: 228039

URL: https://gcc.gnu.org/viewcvs?rev=228039&root=gcc&view=rev
Log:
[ARM] PR 67439: Allow matching of *arm32_movhf when -mrestrict-it is on

        Backport from mainline
        2015-09-10  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

        PR target/67439
        * config/arm/arm.md (*arm32_movhf): Remove !arm_restrict_it from
        predicate.  Set predicable_short_it attr to "no".

        PR target/67439
        * gcc.target/arm/pr67439_1.c: New test.


Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.target/arm/pr67439_1.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/arm/arm.md
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/67439] [4.9/5/6 Regression]ICE: unrecognizable insn compiling arm-fp16 testcases with -march=armv7-a and -mrestrict-it

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67439

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.4