public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c/67495] New: #pragma omp atomic ICEs @ 2015-09-08 14:25 jakub at gcc dot gnu.org 2015-09-08 14:25 ` [Bug c/67495] " jakub at gcc dot gnu.org ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-08 14:25 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 Bug ID: 67495 Summary: #pragma omp atomic ICEs Product: gcc Version: 5.2.1 Status: UNCONFIRMED Keywords: ice-on-invalid-code, openmp Severity: normal Priority: P3 Component: c Assignee: jakub at gcc dot gnu.org Reporter: jakub at gcc dot gnu.org Target Milestone: --- int a, b, c; void foo (void) { #pragma omp atomic capture a = (float)a + b;/* { dg-do error "invalid operator" } */ #pragma omp atomic read (float) a = b;/* { dg-do error "lvalue required" } */ #pragma omp atomic write (float) a = b;/* { dg-do error "lvalue required" } */ #pragma omp atomic read a = (float) b;/* { dg-do error "lvalue required" } */ #pragma omp atomic capture (float) a = b += c;/* { dg-do error "lvalue required" } */ #pragma omp atomic capture { a += b; (float) c = a; }/* { dg-do error "lvalue required" } */ #pragma omp atomic capture { a += b; c = (float) a; }/* { dg-do error "uses two different expressions for memory" } */ #pragma omp atomic capture a = (int)a + b;/* { dg-do error "invalid operator" } */ #pragma omp atomic read (int) a = b;/* { dg-do error "lvalue required" } */ #pragma omp atomic write (int) a = b;/* { dg-do error "lvalue required" } */ #pragma omp atomic read a = (int) b;/* { dg-do error "lvalue required" } */ #pragma omp atomic capture (int) a = b += c;/* { dg-do error "lvalue required" } */ #pragma omp atomic capture { a += b; (int) c = a; }/* { dg-do error "lvalue required" } */ #pragma omp atomic capture { a += b; c = (int) a; }/* { dg-do error "lvalue required" } */ } shows various ICEs, the common problem is that the C FE (unlike the C++ one) relies on c_parser_unary_expression to be called only from c_parser_cast_expression or from places which guarantee that there isn't a cast expression in the source code (that is the case of sizeof or __alignof__). c_parser_omp_atomic uses c_parser_unary_expression in lots of places, and does not guarantee that. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67495] #pragma omp atomic ICEs 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org @ 2015-09-08 14:25 ` jakub at gcc dot gnu.org 2015-09-08 14:38 ` jakub at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-08 14:25 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67495] #pragma omp atomic ICEs 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org 2015-09-08 14:25 ` [Bug c/67495] " jakub at gcc dot gnu.org @ 2015-09-08 14:38 ` jakub at gcc dot gnu.org 2015-09-09 7:23 ` jakub at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-08 14:38 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 36306 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36306&action=edit gcc6-pr67495.patch Untested fix. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67495] #pragma omp atomic ICEs 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org 2015-09-08 14:25 ` [Bug c/67495] " jakub at gcc dot gnu.org 2015-09-08 14:38 ` jakub at gcc dot gnu.org @ 2015-09-09 7:23 ` jakub at gcc dot gnu.org 2015-09-09 7:27 ` jakub at gcc dot gnu.org 2015-09-10 15:10 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-09 7:23 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 --- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Author: jakub Date: Wed Sep 9 07:23:11 2015 New Revision: 227576 URL: https://gcc.gnu.org/viewcvs?rev=227576&root=gcc&view=rev Log: PR c/67495 * c-parser.c (c_parser_omp_atomic): Use c_parser_cast_expression instead of c_parser_unary_expression. If the result is !lvalue_p, wrap the result of c_fully_fold into NON_LVALUE_EXPR. * gcc.dg/gomp/pr67495.c: New test. Added: trunk/gcc/testsuite/gcc.dg/gomp/pr67495.c Modified: trunk/gcc/c/ChangeLog trunk/gcc/c/c-parser.c trunk/gcc/testsuite/ChangeLog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67495] #pragma omp atomic ICEs 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org ` (2 preceding siblings ...) 2015-09-09 7:23 ` jakub at gcc dot gnu.org @ 2015-09-09 7:27 ` jakub at gcc dot gnu.org 2015-09-10 15:10 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-09 7:27 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Author: jakub Date: Wed Sep 9 07:27:15 2015 New Revision: 227580 URL: https://gcc.gnu.org/viewcvs?rev=227580&root=gcc&view=rev Log: PR c/67495 * c-parser.c (c_parser_omp_atomic): Use c_parser_cast_expression instead of c_parser_unary_expression. If the result is !lvalue_p, wrap the result of c_fully_fold into NON_LVALUE_EXPR. * gcc.dg/gomp/pr67495.c: New test. Added: branches/gcc-5-branch/gcc/testsuite/gcc.dg/gomp/pr67495.c Modified: branches/gcc-5-branch/gcc/c/ChangeLog branches/gcc-5-branch/gcc/c/c-parser.c branches/gcc-5-branch/gcc/testsuite/ChangeLog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67495] #pragma omp atomic ICEs 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org ` (3 preceding siblings ...) 2015-09-09 7:27 ` jakub at gcc dot gnu.org @ 2015-09-10 15:10 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2015-09-10 15:10 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67495 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Fixed for 5.3+. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-10 15:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-09-08 14:25 [Bug c/67495] New: #pragma omp atomic ICEs jakub at gcc dot gnu.org 2015-09-08 14:25 ` [Bug c/67495] " jakub at gcc dot gnu.org 2015-09-08 14:38 ` jakub at gcc dot gnu.org 2015-09-09 7:23 ` jakub at gcc dot gnu.org 2015-09-09 7:27 ` jakub at gcc dot gnu.org 2015-09-10 15:10 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).