public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL
Date: Fri, 25 Sep 2015 14:24:00 -0000 [thread overview]
Message-ID: <bug-67567-4-U2MhvTqdAT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567
--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Fri Sep 25 14:24:11 2015
New Revision: 228131
URL: https://gcc.gnu.org/viewcvs?rev=228131&root=gcc&view=rev
Log:
PR pretty-print/67567 do not pass NULL as a string
Fortran passes NULL where a non-null string is expected by the pretty-printer,
which causes a sanitizer warning. This could have been found earlier by using
gcc_checking_assert. Even if the assertion is false, the result is just an
incomplete diagnostic, thus it seems more user-friendly to assert only when
checking. I do not have any idea how to properly fix the Fortran bug, thus this
patch simply works-around it.
gcc/fortran/ChangeLog:
2015-09-25 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR pretty-print/67567
* resolve.c (resolve_fl_procedure): Work-around when iface->module
== NULL.
gcc/ChangeLog:
2015-09-25 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR pretty-print/67567
* pretty-print.c (pp_string): Add gcc_checking_assert.
* pretty-print.h (output_buffer_append_r): Likewise.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/resolve.c
trunk/gcc/pretty-print.c
trunk/gcc/pretty-print.h
>From gcc-bugs-return-498043-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:36:45 2015
Return-Path: <gcc-bugs-return-498043-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 70153 invoked by alias); 25 Sep 2015 14:36:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 70103 invoked by uid 48); 25 Sep 2015 14:36:40 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL
Date: Fri, 25 Sep 2015 14:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: minor
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords cc
Message-ID: <bug-67567-4-riTKffEQ9g@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02021.txt.bz2
Content-length: 762
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |diagnostic
CC|manu at gcc dot gnu.org |fxcoudert at gcc dot gnu.org,
| |paul.richard.thomas at gmail dot c
| |om
--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
This is a Fortran only issue now. Related to the submodules work apparently:
https://gcc.gnu.org/ml/fortran/2015-09/msg00094.html
>From gcc-bugs-return-498045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:44:32 2015
Return-Path: <gcc-bugs-return-498045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 99833 invoked by alias); 25 Sep 2015 14:44:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 99739 invoked by uid 48); 25 Sep 2015 14:44:25 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL
Date: Fri, 25 Sep 2015 14:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: minor
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-67567-4-4KLSOD69gP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02023.txt.bz2
Content-length: 620
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pault at gcc dot gnu.org
--- Comment #6 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #5)
> This is a Fortran only issue now. Related to the submodules work apparently:
>
> https://gcc.gnu.org/ml/fortran/2015-09/msg00094.html
Thanks Manuel,
I'll get onto it.
Paul
>From gcc-bugs-return-498044-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:44:32 2015
Return-Path: <gcc-bugs-return-498044-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 99824 invoked by alias); 25 Sep 2015 14:44:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 99733 invoked by uid 48); 25 Sep 2015 14:44:25 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/67675] [SH] Improve __builtin_strcmp alignment test
Date: Fri, 25 Sep 2015 14:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-67675-4-uh8s8ZWz15@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67675-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67675-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02022.txt.bz2
Content-length: 429
https://gcc.gnu.org/bugzilla/show_bug.cgi?idg675
Oleg Endo <olegendo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Fixed on trunk.
next prev parent reply other threads:[~2015-09-25 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 6:11 [Bug fortran/67567] New: pretty-print.h sanitizer detects NULL pointer passed to obstack_grow zeccav at gmail dot com
2015-09-14 10:14 ` [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL manu at gcc dot gnu.org
2015-09-14 14:27 ` zeccav at gmail dot com
2015-09-14 16:24 ` manu at gcc dot gnu.org
2015-09-25 14:24 ` manu at gcc dot gnu.org [this message]
2015-09-26 18:04 ` pault at gcc dot gnu.org
2015-09-26 18:11 ` paul.richard.thomas at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-67567-4-U2MhvTqdAT@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).