[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-09-14
                 CC|                            |manu at gcc dot gnu.org
            Summary|pretty-print.h sanitizer    |resolve.c: gfc_error called
                   |detects NULL pointer passed |with iface->module == NULL
                   |to obstack_grow             |
     Ever confirmed|0                           |1

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #0)
> but I believe it best to fix it by prefixing the statement with "if(length)"

That would hide the real bug, which is that:

          gfc_error ("%s between the MODULE PROCEDURE declaration "
                     "in module %s and the declaration at %L in "
                     "SUBMODULE %s", errmsg, iface->module,
                     &sym->declared_at, sym->ns->proc_name->name);

is called with iface->module == NULL.

(I think you are doing a nice job at finding and reporting all these sanitizer
issues, but it would be better to figure out the real causes in order to
implement the best solution, and for that you need to master GDB. Otherwise,
developers eager to close as many issues as fast as possible may end up slowing
down the compiler with unnecessary checks while hiding real bugs).
>From gcc-bugs-return-497146-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 14 10:22:02 2015
Return-Path: <gcc-bugs-return-497146-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 111046 invoked by alias); 14 Sep 2015 10:22:02 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 110804 invoked by uid 48); 14 Sep 2015 10:21:57 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/67569] erroneous compiler error message
Date: Mon, 14 Sep 2015 10:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: WORKSFORME
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc resolution
Message-ID: <bug-67569-4-tOTkjLXJYp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67569-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67569-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01124.txt.bz2
Content-length: 712

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67569

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mpolacek at gcc dot gnu.org
         Resolution|---                         |WORKSFORME

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Can't reproduce:

h1.c: In function ‘main’:
h1.c:5:6: error: invalid operands to binary - (have ‘int *’ and ‘float’)

Also, gcc 4.8 is not supported anymore.
>From gcc-bugs-return-497147-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 14 10:41:02 2015
Return-Path: <gcc-bugs-return-497147-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 62711 invoked by alias); 14 Sep 2015 10:41:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 62668 invoked by uid 48); 14 Sep 2015 10:40:58 -0000
From: "werner at beroux dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/67571] Error: open CFI at the end of file; missing .cfi_endproc directive
Date: Mon, 14 Sep 2015 10:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: werner at beroux dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: INVALID
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67571-4-eidTAu45Cu@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67571-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67571-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01125.txt.bz2
Content-length: 301

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg571

--- Comment #2 from werner at beroux dot com ---
It worked on gcc (Debian 4.9.2-2).

Also I tried on two machines with pretty different spec. I'm not excluding the
memory issue, just saying it used to work on those two machines and now it
doesn't.