[Bug fortran/67567] New: pretty-print.h sanitizer detects NULL pointer passed to obstack_grow

[Bug fortran/67567] New: pretty-print.h sanitizer detects NULL pointer passed to obstack_grow

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

            Bug ID: 67567
           Summary: pretty-print.h sanitizer detects NULL pointer passed
                    to obstack_grow
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zeccav at gmail dot com
  Target Milestone: ---

While running make check-fortran on submodule_4.f08 the sanitizer complains
that in pretty-print.h:142

obstack_grow (buff->obstack, start, length);

the pointer start == NULL

Most probably length == 0

but I believe it best to fix it by prefixing the statement with "if(length)"

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-09-14
                 CC|                            |manu at gcc dot gnu.org
            Summary|pretty-print.h sanitizer    |resolve.c: gfc_error called
                   |detects NULL pointer passed |with iface->module == NULL
                   |to obstack_grow             |
     Ever confirmed|0                           |1

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #0)
> but I believe it best to fix it by prefixing the statement with "if(length)"

That would hide the real bug, which is that:

          gfc_error ("%s between the MODULE PROCEDURE declaration "
                     "in module %s and the declaration at %L in "
                     "SUBMODULE %s", errmsg, iface->module,
                     &sym->declared_at, sym->ns->proc_name->name);

is called with iface->module == NULL.

(I think you are doing a nice job at finding and reporting all these sanitizer
issues, but it would be better to figure out the real causes in order to
implement the best solution, and for that you need to master GDB. Otherwise,
developers eager to close as many issues as fast as possible may end up slowing
down the compiler with unnecessary checks while hiding real bugs).
>From gcc-bugs-return-497146-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 14 10:22:02 2015
Return-Path: <gcc-bugs-return-497146-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 111046 invoked by alias); 14 Sep 2015 10:22:02 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 110804 invoked by uid 48); 14 Sep 2015 10:21:57 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/67569] erroneous compiler error message
Date: Mon, 14 Sep 2015 10:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: WORKSFORME
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc resolution
Message-ID: <bug-67569-4-tOTkjLXJYp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67569-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67569-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01124.txt.bz2
Content-length: 712

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67569

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mpolacek at gcc dot gnu.org
         Resolution|---                         |WORKSFORME

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Can't reproduce:

h1.c: In function ‘main’:
h1.c:5:6: error: invalid operands to binary - (have ‘int *’ and ‘float’)

Also, gcc 4.8 is not supported anymore.
>From gcc-bugs-return-497147-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 14 10:41:02 2015
Return-Path: <gcc-bugs-return-497147-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 62711 invoked by alias); 14 Sep 2015 10:41:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 62668 invoked by uid 48); 14 Sep 2015 10:40:58 -0000
From: "werner at beroux dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/67571] Error: open CFI at the end of file; missing .cfi_endproc directive
Date: Mon, 14 Sep 2015 10:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: werner at beroux dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: INVALID
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67571-4-eidTAu45Cu@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67571-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67571-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01125.txt.bz2
Content-length: 301

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg571

--- Comment #2 from werner at beroux dot com ---
It worked on gcc (Debian 4.9.2-2).

Also I tried on two machines with pretty different spec. I'm not excluding the
memory issue, just saying it used to work on those two machines and now it
doesn't.

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

--- Comment #2 from Vittorio Zecca <zeccav at gmail dot com> ---
Unfortunately I do not master gdb and gcc internals enough for that.
The check costs two instructions on my x86-64.

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

--- Comment #3 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Vittorio Zecca from comment #2)
> Unfortunately I do not master gdb and gcc internals enough for that.
> The check costs two instructions on my x86-64.

Two instructions that we do not need to execute! :)

In this case, the worst part is that it will hide a bug in error reporting. It
will print something like:

Error: X between the MODULE PROCEDURE declaration in module  and the
declaration at (1) in SUBMODULE Y

which is wrong.
>From gcc-bugs-return-497201-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 14 16:25:30 2015
Return-Path: <gcc-bugs-return-497201-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 118000 invoked by alias); 14 Sep 2015 16:25:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 117965 invoked by uid 48); 14 Sep 2015 16:25:26 -0000
From: "cctsai57 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/67576] New: expression of typeid( expression ) is evaluated twice
Date: Mon, 14 Sep 2015 16:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cctsai57 at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-67576-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01179.txt.bz2
Content-length: 1300

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg576

            Bug ID: 67576
           Summary: expression of typeid( expression ) is evaluated twice
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: cctsai57 at gmail dot com
  Target Milestone: ---

#include <typeinfo>

struct Base { virtual void foo() {} }; // polymorphic

int main()
{
  Base b;
  Base *ary[] = { &b, &b, &b};

  int iter = 0;
  typeid(*ary[iter++]);
  if (iter != 1)        // should be 1
    __builtin_abort();  // but 2

  return iter;
}


Compiler version:4.9.x, 5.x, 6.0

Description:
The above simplified code would get a wrong `iter' value after typeid
statement.
It seems to evaluate `iter++' twice.

I found that the code has not worked since the following fix:

commit cdb704aa83247f82d7b9aae934639a6be2e6681b
Author: jason <jason@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Apr 9 18:11:38 2013 +0000

        PR c++/25466
        * rtti.c (build_typeid): Check the address of the argument
        rather than looking for an INDIRECT_REF.

    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@197644
138bc75d-0d04-0410-961f-82ee72b054a4

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Fri Sep 25 14:24:11 2015
New Revision: 228131

URL: https://gcc.gnu.org/viewcvs?rev=228131&root=gcc&view=rev
Log:
PR pretty-print/67567 do not pass NULL as a string

Fortran passes NULL where a non-null string is expected by the pretty-printer,
which causes a sanitizer warning. This could have been found earlier by using
gcc_checking_assert. Even if the assertion is false, the result is just an
incomplete diagnostic, thus it seems more user-friendly to assert only when
checking. I do not have any idea how to properly fix the Fortran bug, thus this
patch simply works-around it.

gcc/fortran/ChangeLog:

2015-09-25  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR pretty-print/67567
        * resolve.c (resolve_fl_procedure): Work-around when iface->module
        == NULL.

gcc/ChangeLog:

2015-09-25  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR pretty-print/67567
        * pretty-print.c (pp_string): Add gcc_checking_assert.
        * pretty-print.h (output_buffer_append_r): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/pretty-print.c
    trunk/gcc/pretty-print.h
>From gcc-bugs-return-498043-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:36:45 2015
Return-Path: <gcc-bugs-return-498043-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 70153 invoked by alias); 25 Sep 2015 14:36:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 70103 invoked by uid 48); 25 Sep 2015 14:36:40 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL
Date: Fri, 25 Sep 2015 14:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: minor
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords cc
Message-ID: <bug-67567-4-riTKffEQ9g@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02021.txt.bz2
Content-length: 762

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
                 CC|manu at gcc dot gnu.org            |fxcoudert at gcc dot gnu.org,
                   |                            |paul.richard.thomas at gmail dot c
                   |                            |om

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
This is a Fortran only issue now. Related to the submodules work apparently:

https://gcc.gnu.org/ml/fortran/2015-09/msg00094.html
>From gcc-bugs-return-498045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:44:32 2015
Return-Path: <gcc-bugs-return-498045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 99833 invoked by alias); 25 Sep 2015 14:44:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 99739 invoked by uid 48); 25 Sep 2015 14:44:25 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL
Date: Fri, 25 Sep 2015 14:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: minor
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-67567-4-4KLSOD69gP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67567-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02023.txt.bz2
Content-length: 620

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org

--- Comment #6 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #5)
> This is a Fortran only issue now. Related to the submodules work apparently:
> 
> https://gcc.gnu.org/ml/fortran/2015-09/msg00094.html

Thanks Manuel,

I'll get onto it.

Paul
>From gcc-bugs-return-498044-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Sep 25 14:44:32 2015
Return-Path: <gcc-bugs-return-498044-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 99824 invoked by alias); 25 Sep 2015 14:44:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 99733 invoked by uid 48); 25 Sep 2015 14:44:25 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/67675] [SH] Improve __builtin_strcmp alignment test
Date: Fri, 25 Sep 2015 14:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-67675-4-uh8s8ZWz15@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67675-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67675-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02022.txt.bz2
Content-length: 429

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg675

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Fixed on trunk.

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Paul Thomas <pault at gcc dot gnu.org> ---
Dear Manuel,

It has been fixed. I would be grateful if you did not put comments like that in
the source code. The PR is quite sufficient!

Thanks for getting to the cause of this problem. Ultimately, it was due to a
change in the way that submodule files are named and was missed because the
testcase does not check the complete messages.

Cheers y muchas gracias!

Paul

[Bug fortran/67567] resolve.c: gfc_error called with iface->module == NULL

[paul.richard.thomas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67567

--- Comment #9 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> ---
Fixed as 'obvious' in revision: 228169.

Cheers

Paul

2013-09-26  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/67567
    * resolve.c (resolve_fl_procedure): For module procedures, take
    the parent module name and the submodule name from the name of
    the namespace.