* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
@ 2015-09-16 10:17 ` trippels at gcc dot gnu.org
2015-09-16 11:38 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-09-16 10:17 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4625 bytes --]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-09-16
Ever confirmed|0 |1
--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
The instrumented compiler is obviously miscompiled.
trippels@gcc2-power8 libgcc % cat unwind-dw2.i
void _Unwind_Backtrace() { __builtin_unwind_init(); }
trippels@gcc2-power8 libgcc % /home/trippels/gcc_build_dir_/./gcc/xgcc
-B/home/trippels/gcc_build_dir_/./gcc/
-B/usr/local/powerpc64le-unknown-linux-gnu/bin/
-B/usr/local/powerpc64le-unknown-linux-gnu/lib/ -c -g -O2 unwind-dw2.i
unwind-dw2.i: In function ‘_Unwind_Backtrace’:
unwind-dw2.i:1:1: internal compiler error: in dwarf2out_frame_debug_expr, at
dwarf2cfi.c:1901
>From gcc-bugs-return-497321-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Sep 16 10:35:10 2015
Return-Path: <gcc-bugs-return-497321-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 14743 invoked by alias); 16 Sep 2015 10:35:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 14689 invoked by uid 48); 16 Sep 2015 10:35:04 -0000
From: "jgreenhalgh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66785] internal compiler error in record_operand_use
Date: Wed, 16 Sep 2015 10:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jgreenhalgh at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.isobsolete cc attachments.created
Message-ID: <bug-66785-4-lrZzt4qjkw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66785-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66785-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg01299.txt.bz2
Content-length: 1709
https://gcc.gnu.org/bugzilla/show_bug.cgi?idf785
James Greenhalgh <jgreenhalgh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35920|0 |1
is obsolete| |
CC| |jgreenhalgh at gcc dot gnu.org
--- Comment #1 from James Greenhalgh <jgreenhalgh at gcc dot gnu.org> ---
Created attachment 36341
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id6341&actioníit
Reduced testcase without Undefined Behaviour
Confirmed with the testcase updated to avoid Undefined Behaviour.
It isn't immediately clear what is going wrong here, the ICE occurs before any
of the cortex-a57-fma-steering analysis kicks in, which implies an issue in the
generic register rename analysis code. The assert trips on this line:
gcc_assert (cur_operand->n_chains < MAX_REGS_PER_ADDRESS);
When handling this rtx:
(insn 403 78 417 4 (set (mem:XI (post_inc:DI (reg:DI 17 x17 [orig:205
ivtmp.18 ] [205])) [4 MEM[(float *)vectp_pretmp.12_54]+0 S64 A32])
(unspec:XI [
(reg:XI 32 v0 [orig:165 vect_array.14 ] [165])
(unspec:V4SF [
(const_int 0 [0])
] UNSPEC_VSTRUCTDUMMY)
] UNSPEC_ST4)) error.c:20 2372 {aarch64_simd_st4v4sf}
(expr_list:REG_INC (reg:DI 17 x17 [orig:205 ivtmp.18 ] [205])
(nil)))
In this case n_chains is either 2 or 3 and MAX_REGS_PER_ADDRESS for aarch64 is
set to 2, so we trip the assert.
I don't know regrename at all, so I'm not sure how we get in to this situation.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
2015-09-16 10:17 ` [Bug bootstrap/67597] " trippels at gcc dot gnu.org
@ 2015-09-16 11:38 ` rguenth at gcc dot gnu.org
2015-09-16 13:32 ` trippels at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-09-16 11:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |6.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
2015-09-16 10:17 ` [Bug bootstrap/67597] " trippels at gcc dot gnu.org
2015-09-16 11:38 ` rguenth at gcc dot gnu.org
@ 2015-09-16 13:32 ` trippels at gcc dot gnu.org
2015-09-17 9:17 ` aoliva at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-09-16 13:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |wrong-code
CC| |aoliva at gcc dot gnu.org
--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Started with r226901.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
` (2 preceding siblings ...)
2015-09-16 13:32 ` trippels at gcc dot gnu.org
@ 2015-09-17 9:17 ` aoliva at gcc dot gnu.org
2015-09-17 10:43 ` trippels at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aoliva at gcc dot gnu.org @ 2015-09-17 9:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
Alexandre Oliva <aoliva at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |aoliva at gcc dot gnu.org
--- Comment #4 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Mine. AFAICT this is fixed in the git branch aoliva/pr64164, that moves rtl
allocation of parms and results back to assign_parms.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
` (3 preceding siblings ...)
2015-09-17 9:17 ` aoliva at gcc dot gnu.org
@ 2015-09-17 10:43 ` trippels at gcc dot gnu.org
2015-09-27 9:02 ` aoliva at gcc dot gnu.org
2015-09-27 12:13 ` trippels at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-09-17 10:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Alexandre Oliva from comment #4)
> Mine. AFAICT this is fixed in the git branch aoliva/pr64164, that moves rtl
> allocation of parms and results back to assign_parms.
Thanks. I can confirm that aoliva/pr64164 branch fixes the issue.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
` (4 preceding siblings ...)
2015-09-17 10:43 ` trippels at gcc dot gnu.org
@ 2015-09-27 9:02 ` aoliva at gcc dot gnu.org
2015-09-27 12:13 ` trippels at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: aoliva at gcc dot gnu.org @ 2015-09-27 9:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
--- Comment #6 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Author: aoliva
Date: Sun Sep 27 09:02:00 2015
New Revision: 228175
URL: https://gcc.gnu.org/viewcvs?rev=228175&root=gcc&view=rev
Log:
revert to assign_parms assignments using default defs
Revert the fragile and complicated changes to assign_parms designed to
enable it to use RTL assigments chosen by cfgexpand, and instead have
cfgexpand use the RTL assignments by assign_parms, keying them off of
the default defs that are now necessarily introduced for each parm and
result. The possible lack of a default def was already a problem, and
the fallbacks in place were not enough, as shown by PR67312. We now
have checking asserts in set_rtl that verify that we're assigning to
each var a piece of RTL that matches the expectations set forth by
use_register_for_decl.
for gcc/ChangeLog
PR rtl-optimization/64164
PR tree-optimization/67312
PR middle-end/67340
PR middle-end/67490
PR bootstrap/67597
* cfgexpand.c (parm_in_stack_slot_p): Remove.
(ssa_default_def_partition): Remove.
(get_rtl_for_parm_ssa_default_def): Remove.
(set_rtl): Check that RTL assignments match expectations.
Loop on SUBREGs, CONCATs and PARALLELs subexprs. Set only the
default def location for params and results. Record SSA names
or types in REG and MEM attrs, respectively.
(set_parm_rtl): New.
(expand_one_ssa_partition): Drop logic that assigned MEMs with
unassigned addresses.
(adjust_one_expanded_partition_var): Don't accept NULL RTL on
deferred stack alloc vars.
(expand_used_vars): Skip partitions holding parm default defs.
Move adjust_one_expanded_partition_var loop...
(pass_expand::execute): ... here. Drop redundant assert.
Adjust comments before the final loop over all ssa names.
Require assigned rtl of parms and results to match exactly.
Reset its attributes to match them, not any other variables in
the same partition.
(expand_debug_expr): Use entry value for PARM's default defs
only iff they have zero nondebug uses.
* cfgexpand.h (parm_in_stack_slot_p): Remove.
(get_rtl_for_parm_ssa_default_def): Remove.
(set_parm_rtl): Declare.
* doc/invoke.texi: Improve wording.
* explow.c (promote_decl_mode): Fix promote_function_mode for
result decls not by reference.
(promote_ssa_mode): Disregard BLKmode from promote_decl, and
bypass TYPE_MODE to get the actual vector mode.
* function.c: Include tree-dfa.h. Revert 2015-08-14's and
2015-08-19's changes as follows. Drop include of
basic-block.h and df.h.
(rtl_for_parm): Remove.
(maybe_reset_rtl_for_parm): Remove.
(parm_in_unassigned_mem_p): Remove.
(use_register_for_decl): Add logic for RESULT_DECLs matching
assign_parms' behavior.
(split_complex_args): Revert.
(assign_parms_augmented_arg_list): Revert. Add comment
referencing the logic above.
(assign_parm_adjust_stack_rtl): Revert.
(assign_parm_setup_block): Revert. Use set_parm_rtl instead
of SET_DECL_RTL. Set up a REG if the parm demands so.
(assign_parm_setup_reg): Revert. Consolidated SET_DECL_RTL
calls into a single set_parm_rtl. Set up a temporary RTL
temporarily for expand_assignment.
(assign_parm_setup_stack): Revert. Use set_parm_rtl.
(assign_parms_unsplit_complex): Revert. Use set_parm_rtl.
(assign_bounds): Revert.
(assign_parms): Revert. Use set_parm_rtl.
(allocate_struct_function): Relayout result and parms of
non-abstruct functions.
(expand_function_start): Revert. Use set_parm_rtl. If the
result is not a hard reg, create a pseudo from the promoted
mode of the default def. Promote static chain mode.
* tree-outof-ssa.c (remove_ssa_form): Drop unused
partition_has_default_def. Set up
partitions_for_parm_default_defs.
(finish_out_of_ssa): Remove partition_has_default_def.
Release partitions_for_parm_default_defs.
* tree-outof-ssa.h (struct ssaexpand): Remove
partition_has_default_def. Add
partitions_for_parm_default_defs.
* tree-ssa-coalesce.c: Include tree-dfa.h, tm_p.h and
stor-layout.h.
(build_ssa_conflict_graph): Fix conflict-detection of default
defs of even unused default defs of params and results.
(for_all_parms): New.
(create_default_def): New.
(register_default_def): New.
(coalesce_with_default): New.
(create_outofssa_var_map): Create default defs for all parms
and results, and register their partitions. Add GIMPLE_RETURN
operands as coalesce candidates with results. Add default
defs of each parm or result as coalesce candidates with its
other defs. Mark each result def, and each default def of
parms, as used_in_copy.
(gimple_can_coalesce_p): Call it. Call use_register_for_decl
with the ssa names, even anonymous ones. Drop
parm_in_stack_slot_p calls. Require same signedness and
alignment.
(coalesce_ssa_name): Add coalesce candidates for all defs of
each parm and result, even unused ones.
(parm_default_def_partition_arg): New type.
(set_parm_default_def_partition): New.
(get_parm_default_def_partitions): New.
* tree-ssa-coalesce.h (get_parm_default_def_partitions): New.
* tree-ssa-live.c (partition_view_init): Regard unused defs of
parms and results as used.
(verify_live_on_entry): Don't error out just because they're
not live.
for gcc/testsuite/ChangeLog
PR rtl-optimization/64164
PR tree-optimization/67312
* gcc.dg/pr67312.c: New. From Zdenek Sojka.
* gcc.target/i386/stackalign/return-4.c: Add -O.
Added:
trunk/gcc/testsuite/gcc.dg/pr67312.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cfgexpand.c
trunk/gcc/cfgexpand.h
trunk/gcc/doc/invoke.texi
trunk/gcc/explow.c
trunk/gcc/function.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.target/i386/stackalign/return-4.c
trunk/gcc/tree-outof-ssa.c
trunk/gcc/tree-outof-ssa.h
trunk/gcc/tree-ssa-coalesce.c
trunk/gcc/tree-ssa-coalesce.h
trunk/gcc/tree-ssa-live.c
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug bootstrap/67597] [6 Regression] profiledbootstrap failure on ppc64le
2015-09-16 5:26 [Bug bootstrap/67597] New: [6 Regression] profiledbootstrap failure on ppc64le trippels at gcc dot gnu.org
` (5 preceding siblings ...)
2015-09-27 9:02 ` aoliva at gcc dot gnu.org
@ 2015-09-27 12:13 ` trippels at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: trippels at gcc dot gnu.org @ 2015-09-27 12:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67597
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
fixed
^ permalink raw reply [flat|nested] 8+ messages in thread