public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/67675] [SH] Improve __builtin_strcmp alignment test Date: Tue, 22 Sep 2015 01:57:00 -0000 [thread overview] Message-ID: <bug-67675-4-KMAOYPKkRE@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-67675-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67675 Oleg Endo <olegendo at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2015-09-22 Ever confirmed|0 |1 --- Comment #1 from Oleg Endo <olegendo at gcc dot gnu.org> --- This fixes it: Index: gcc/config/sh/sh-mem.cc =================================================================== --- gcc/config/sh/sh-mem.cc (revision 227970) +++ gcc/config/sh/sh-mem.cc (working copy) @@ -224,11 +224,10 @@ rtx_code_label *L_loop_long = gen_label_rtx (); rtx_code_label *L_end_loop_long = gen_label_rtx (); - int align = INTVAL (operands[3]); + const unsigned int addr1_alignment = MEM_ALIGN (operands[1]) / BITS_PER_UNIT; + const unsigned int addr2_alignment = MEM_ALIGN (operands[2]) / BITS_PER_UNIT; - emit_move_insn (tmp0, const0_rtx); - - if (align < 4) + if (addr1_alignment < 4 && addr2_alignment < 4) { emit_insn (gen_iorsi3 (tmp1, s1_addr, s2_addr)); emit_insn (gen_tstsi_t (tmp1, GEN_INT (3))); @@ -235,6 +234,18 @@ jump = emit_jump_insn (gen_branch_false (L_loop_byte)); add_int_reg_note (jump, REG_BR_PROB, prob_likely); } + else if (addr1_alignment < 4 && addr2_alignment >= 4) + { + emit_insn (gen_tstsi_t (s1_addr, GEN_INT (3))); + jump = emit_jump_insn (gen_branch_false (L_loop_byte)); + add_int_reg_note (jump, REG_BR_PROB, prob_likely); + } + else if (addr1_alignment >= 4 && addr2_alignment < 4) + { + emit_insn (gen_tstsi_t (s2_addr, GEN_INT (3))); + jump = emit_jump_insn (gen_branch_false (L_loop_byte)); + add_int_reg_note (jump, REG_BR_PROB, prob_likely); + } addr1 = adjust_automodify_address (addr1, SImode, s1_addr, 0); addr2 = adjust_automodify_address (addr2, SImode, s2_addr, 0);
next prev parent reply other threads:[~2015-09-22 1:57 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-22 1:22 [Bug target/67675] New: " olegendo at gcc dot gnu.org 2015-09-22 1:57 ` olegendo at gcc dot gnu.org [this message] 2015-09-22 2:07 ` [Bug target/67675] " olegendo at gcc dot gnu.org 2015-09-25 13:09 ` olegendo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-67675-4-KMAOYPKkRE@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).