[Bug libstdc++/67747] New: experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[Bug libstdc++/67747] New: experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

            Bug ID: 67747
           Summary: experimental/filesystem/iterators/recursive_directory_
                    iterator.cc FAILs
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: redi at gcc dot gnu.org
  Target Milestone: ---
              Host: *-*-solaris2.*
            Target: *-*-solaris2.*
             Build: *-*-solaris2.*

The 32-bit experimental/filesystem/iterators/recursive_directory_iterator.cc
FAILs
on Solaris 10 to 12, while the 64-bit test is fine, both for a 32-bit and
64-bit
compiler:

Assertion failed: iter->path() == p/"d1", file
/vol/gcc/src/hg/trunk/local/libstdc++-v3/testsuite/experimental/filesystem/iterators/recursive_directory_iterator.cc,
line 52, function test01
Abort

  Rainer

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-09-28
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Could you modify the test to print the values of iter->path() and p/"d1" to
stdout before the assertion on line 52?

e.g.

__builtin_puts( iter->path().native().c_str() );
__builtin_puts( (p/"d1").native().c_str() );

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> Could you modify the test to print the values of iter->path() and p/"d1" to
> stdout before the assertion on line 52?
>
> e.g.
>
> __builtin_puts( iter->path().native().c_str() );
> __builtin_puts( (p/"d1").native().c_str() );

Sure: I get

test.POpqCd/d1øn       üO 
test.POpqCd/d1

i.e. there's some garbage in iter->path()

        Rainer
>From gcc-bugs-return-498216-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 28 15:40:58 2015
Return-Path: <gcc-bugs-return-498216-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 72095 invoked by alias); 28 Sep 2015 15:40:57 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 71963 invoked by uid 48); 28 Sep 2015 15:40:53 -0000
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/67742] 3rd-level restrict ignored
Date: Mon, 28 Sep 2015 15:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67742-4-qwNq6p2VBZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67742-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67742-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-09/txt/msg02194.txt.bz2
Content-length: 251

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg742

--- Comment #2 from vries at gcc dot gnu.org ---
This code pattern is generated for the proposed option
-foffload-alias=<none|pointer|all>
https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02122.html .

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Ah, I need to ensure space for the dirent::d_name field.

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Proposed patch at https://gcc.gnu.org/ml/gcc-patches/2015-09/msg02186.html

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #5 from Christophe Lyon <clyon at gcc dot gnu.org> ---
This testcase fails when compiled for armv5t (works for armv7).

I tried the patch proposed in comment #4, but it does not work for me.

However, the error message I can see in gcc.log is:
*** Error in `./directory_iterator.exe': malloc(): memory corruption:
0x40b787f7 ***^M

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
There's a new patch at https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00106.html
but I don't know if you're seeing something different.

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #7 from Christophe Lyon <clyon at gcc dot gnu.org> ---
I've just tried the patch in comment #6, but it does not fix the problem I'm
seeing on armv5t:
*** Error in `./directory_iterator.exe': malloc(): memory corruption:
0x40b787f7 ***^M

Maybe I should file another bug report, since it's probably a different
problem.

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Oct  2 16:34:34 2015
New Revision: 228404

URL: https://gcc.gnu.org/viewcvs?rev=228404&root=gcc&view=rev
Log:
PR libstdc++/67747 use readdir instead of readdir_r

        PR libstdc++/67747
        * src/filesystem/dir.cc (native_readdir): Remove.
        (_Dir::advance): Use readdir instead of native_readdir.
        (recursive_directory_iterator(const path&, directory_options,
        error_code*)): Use swap instead of reset.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/src/filesystem/dir.cc

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Christophe Lyon from comment #7)
> Maybe I should file another bug report, since it's probably a different
> problem.

Yes please, this bug should be fixed now.

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Wed Oct  7 21:00:50 2015
New Revision: 228584

URL: https://gcc.gnu.org/viewcvs?rev=228584&root=gcc&view=rev
Log:
Backport Filesystem TS fixes from mainline.

        PR libstdc++/67173
        PR libstdc++/67747
        * acinclude.m4 (GLIBCXX_CHECK_FILESYSTEM_DEPS): Check _XOPEN_VERSION
        and PATH_MAX for _GLIBCXX_USE_REALPATH.  Remove _GLIBCXX_ prefix
        from HAVE_STRUCT_DIRENT_D_TYPE.
        * config.h.in: Regenerate.
        * configure: Regenerate.
        * include/bits/locale_conv.h [!_GLIBCXX_USE_WCHAR_T]
        (__do_str_codecvt, __str_codecvt_in, __str_codecvt_out): Enable.
        * include/experimental/fs_dir.h (operator==, operator==):
        Use owner_before instead of pointer equality.
        (directory_iterator(std::shared_ptr<_Dir>, error_code*)): Remove.
        * include/experimental/fs_path.h (operator==, operator==):
        * include/experimental/fs_path.h [!_GLIBCXX_USE_WCHAR_T]
        (path::wstring, path::generic_wstring): Disable.
        * src/filesystem/path.cc (path::_S_convert_loc)
        [!_GLIBCXX_USE_WCHAR_T]: Skip conversion.
        * src/filesystem/Makefile.am: Add cxx11_abi_sources.
        * src/filesystem/Makefile.in: Regenerate.
        * src/filesystem/cow-dir.cc: New.
        * src/filesystem/cow-ops.cc: New.
        * src/filesystem/cow-path.cc: New.
        * src/filesystem/dir.cc: Define macro for new ABI.
        (native_readdir): Remove.
        (_Dir::advance): Use readdir instead of native_readdir.
        (recursive_directory_iterator(const path&, directory_options,
        error_code*)): Use swap instead of reset.
        (ErrorCode): Remove.
        (_Dir::advance): Change ErrorCode parameter to error_code*, add
        directory_options parameter and check it on error.
        (opendir): Rename to open_dir to avoid clashing with macro. Change
        ErrorCode parameter to error_code*.
        (make_shared_dir): Remove.
        (native_readdir) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Don't set errno.
        (directory_iterator(std::shared_ptr<_Dir>, error_code*)): Remove.
        (directory_iterator(const path&, directory_options, error_code*)):
        Pass options to _Dir::advance and create non-end iterator on error.
        (recursive_directory_iterator(const path&, directory_options,
        error_code*)): Clear error_code on ignored error, create non-end
        iterator otherwise.
        (recursive_directory_iterator::increment): Pass _M_options to
        _Dir::advance.
        (recursive_directory_iterator::pop): Likewise.
        * src/filesystem/ops.cc: Define macro for new ABI.
        (canonical) [!_GLIBCXX_USE_REALPATH]: Add alternative implementation.
        (is_dot, is_dotdot): Define new helpers.
        (create_directories): Fix error handling.
        * src/filesystem/path.cc: Define macro for new ABI.
        (path::_S_convert_loc) [!_GLIBCXX_USE_WCHAR_T]: Skip conversion.
        * testsuite/experimental/filesystem/iterators/directory_iterator.cc:
        New.
        * testsuite/experimental/filesystem/iterators/
        recursive_directory_iterator.cc: New.
        * testsuite/experimental/filesystem/operations/canonical.cc: New.
        * testsuite/experimental/filesystem/operations/create_directories.cc:
        New.
        * testsuite/experimental/filesystem/operations/exists.cc: Add more
        tests.
        * testsuite/experimental/filesystem/operations/absolute.cc: Add test
        variables.
        * testsuite/experimental/filesystem/operations/copy.cc: Likewise.
        * testsuite/experimental/filesystem/operations/current_path.cc:
        Likewise.
        * testsuite/experimental/filesystem/operations/file_size.cc: Likewise.
        * testsuite/experimental/filesystem/operations/status.cc: Likewise.
        * testsuite/experimental/filesystem/operations/temp_directory_path.cc:
        Likewise.
        * testsuite/experimental/filesystem/path/assign/assign.cc: Check for
        wchar_t support.
        * testsuite/experimental/filesystem/path/concat/strings.cc: Likewise.
        * testsuite/experimental/filesystem/path/construct/range.cc: Likewise.

Added:
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/cow-dir.cc
      - copied, changed from r228554,
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/exists.cc
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/cow-ops.cc
      - copied, changed from r228554,
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/exists.cc
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/cow-path.cc
      - copied, changed from r228554,
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/exists.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/iterators/
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/iterators/directory_iterator.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/iterators/recursive_directory_iterator.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/canonical.cc
      - copied, changed from r228554,
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/status.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/create_directories.cc
      - copied, changed from r228554,
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/status.cc
Removed:
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/factory/
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/io/
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/native/
Modified:
    branches/gcc-5-branch/libstdc++-v3/ChangeLog
    branches/gcc-5-branch/libstdc++-v3/acinclude.m4
    branches/gcc-5-branch/libstdc++-v3/config.h.in
    branches/gcc-5-branch/libstdc++-v3/configure
    branches/gcc-5-branch/libstdc++-v3/include/bits/locale_conv.h
    branches/gcc-5-branch/libstdc++-v3/include/experimental/fs_dir.h
    branches/gcc-5-branch/libstdc++-v3/include/experimental/fs_path.h
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/Makefile.am
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/Makefile.in
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/dir.cc
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/ops.cc
    branches/gcc-5-branch/libstdc++-v3/src/filesystem/path.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/absolute.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/copy.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/current_path.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/exists.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/file_size.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/status.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/operations/temp_directory_path.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/assign/assign.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/concat/strings.cc
   
branches/gcc-5-branch/libstdc++-v3/testsuite/experimental/filesystem/path/construct/range.cc

[Bug libstdc++/67747] experimental/filesystem/iterators/recursive_directory_iterator.cc FAILs

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67747

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|6.0                         |5.3

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 5.3 too.