public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67758] [GCC 6 regression] ICE on invalid use of COMMON
Date: Tue, 29 Sep 2015 20:24:00 -0000	[thread overview]
Message-ID: <bug-67758-4-axRTY9lM9h@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-67758-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67758

--- Comment #3 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Tue, Sep 29, 2015 at 07:56:16PM +0000, kargl at gcc dot gnu.org wrote:
> 
> troutmask:sgk[204] gfc6 -c r5.f
> f951: internal compiler error: Segmentation fault
> no stack trace because unwind library not available
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <http://gcc.gnu.org/bugs.html> for instructions.

This fixes the regression.

Index: symbol.c
===================================================================
--- symbol.c    (revision 228264)
+++ symbol.c    (working copy)
@@ -3211,6 +3211,8 @@ gfc_restore_last_undo_checkpoint (void)

              while (csym != p)
                {
+                 if (!csym)
+                   goto syntax;
                  cparent = csym;
                  csym = csym->common_next;
                }
@@ -3242,6 +3244,11 @@ gfc_restore_last_undo_checkpoint (void)

   if (!single_undo_checkpoint_p ())
     pop_undo_change_set (latest_undo_chgset);
+
+  return;
+
+syntax:
+   gfc_error ("syntax or semantics issue at %C");
 }

But, the real issue is that the second COMMON is not
allowed to appear in the execution block of a program.
gfortran should probably error out earlier.


  parent reply	other threads:[~2015-09-29 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 10:05 [Bug fortran/67758] New: [GCC 6 regression] ICE on invalid code ienkovich at gcc dot gnu.org
2015-09-29 17:35 ` [Bug fortran/67758] [GCC 6 regression] ICE on invalid use of COMMON dominiq at lps dot ens.fr
2015-09-29 19:56 ` kargl at gcc dot gnu.org
2015-09-29 20:24 ` sgk at troutmask dot apl.washington.edu [this message]
2015-09-29 23:03 ` dominiq at lps dot ens.fr
2015-10-04 12:30 ` mikael at gcc dot gnu.org
2015-10-05 14:56 ` mikael at gcc dot gnu.org
2015-10-16  8:31 ` [Bug fortran/67758] [6 Regression] " rguenth at gcc dot gnu.org
2015-10-18 17:18 ` mikael at gcc dot gnu.org
2015-10-18 18:20 ` mikael at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-67758-4-axRTY9lM9h@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).