[Bug tree-optimization/67794] New: internal compiler error: Segmentation fault

[Bug tree-optimization/67794] New: internal compiler error: Segmentation fault

[jamrial at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

            Bug ID: 67794
           Summary: internal compiler error: Segmentation fault
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jamrial at gmail dot com
  Target Milestone: ---

Created attachment 36432
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36432&action=edit
Preprocessed source as generated by -freport-bug

In file included from /home/jamrial/ffmpeg/libavcodec/motion_est.c:295:0:
/home/jamrial/ffmpeg/libavcodec/motion_est_template.c: In function
‘sab_diamond_search.isra.3’:
/home/jamrial/ffmpeg/libavcodec/motion_est_template.c:679:12: internal compiler
error: Segmentation fault
 static int sab_diamond_search(MpegEncContext * s, int *best, int dmin,
            ^
0xabb4ff crash_signal
     /home/jamrial/gcc-svn/gcc/toplev.c:353
0xbce129 tree_check(tree_node const*, char const*, int, char const*, tree_code)
     /home/jamrial/gcc-svn/gcc/tree.h:3116
0xbce129 has_zero_uses
     /home/jamrial/gcc-svn/gcc/ssa-iterators.h:381
0xbce129 coalesce_with_default
     /home/jamrial/gcc-svn/gcc/tree-ssa-coalesce.c:1003
0xbce129 create_outofssa_var_map
     /home/jamrial/gcc-svn/gcc/tree-ssa-coalesce.c:1202
0xbcedd0 coalesce_ssa_name()
     /home/jamrial/gcc-svn/gcc/tree-ssa-coalesce.c:1736
0xb628fe remove_ssa_form
     /home/jamrial/gcc-svn/gcc/tree-outof-ssa.c:984
0xb628fe rewrite_out_of_ssa(ssaexpand*)
     /home/jamrial/gcc-svn/gcc/tree-outof-ssa.c:1208
0x701490 execute
     /home/jamrial/gcc-svn/gcc/cfgexpand.c:6100


gcc version 6.0.0 20151001 on x86_64-pc-linux-gnu.
This regression was apparently introduced sometime in the last eight days.
>From gcc-bugs-return-498451-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 01 07:17:35 2015
Return-Path: <gcc-bugs-return-498451-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 107835 invoked by alias); 1 Oct 2015 07:17:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 107662 invoked by uid 48); 1 Oct 2015 07:17:22 -0000
From: "schwab@linux-m68k.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/66870] split stack issues on ppc64le and ppc64
Date: Thu, 01 Oct 2015 07:17:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: schwab@linux-m68k.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66870-4-odtVLL8xX6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66870-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66870-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg00006.txt.bz2
Content-length: 414

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf870

--- Comment #24 from Andreas Schwab <schwab@linux-m68k.org> ---
../../gcc/go/gospec.c: In function 'void
lang_specific_driver(cl_decoded_option**, unsigned int*, int*)':
../../gcc/go/gospec.c:161:7: error: 'OPT_m32' was not declared in this scope
  case OPT_m32:
       ^
Makefile:1077: recipe for target 'go/gospec.o' failed
make[3]: *** [go/gospec.o] Error 1

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-10-01
                 CC|                            |trippels at gcc dot gnu.org
            Summary|internal compiler error:    |[6 regression] internal
                   |Segmentation fault          |compiler error:
                   |                            |Segmentation fault
     Ever confirmed|0                           |1

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
int *b;
static void fn1(int *best, int *dmin) {
  int a[64];
  dmin = a;
  __asm__ volatile("" : "+&r"(dmin) : ""(best));
}

__attribute__((always_inline)) static void fn2(int *best) { fn1(best, b); }

void fn3(void) {
  int c[1];
  fn2(c);
}

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org
   Target Milestone|---                         |6.0

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
We fail to have a default-def for a PARM_DECL in this case.  The PARM_DECL was
created by function versioning so eventually the code that makes sure we always
have a default def for PARM_DECLs doesn't trigger (the function is versioned
when already in SSA form).

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
So started with r228175.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |aoliva at gcc dot gnu.org

--- Comment #4 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Created attachment 36454
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36454&action=edit
Patch that removes the crash

This patch fixes the problem by tolerating IPA ESRA's leaving removed
PARM_DECLs alone, instead of replacing them with VAR_DECLs.  I would rather we
used a VAR_DECL instead, because I'm concerned about other places that
distinguish between PARM_DECLs and VAR_DECLs, at least when it comes to
handling their default defs.  I haven't looked into this possibility yet,
though; it might be that other pieces of the compiler rely on the decls
remaining as PARM_DECLs for other purposes.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjambor at suse dot cz

--- Comment #5 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Martin, why doesn't SRA's modify_function use tree_versioning's args_to_skip
infrastructure to remap the function, including its prototype, and instead
makes an (incomplete) work itself?  We end up with cloned PARM_DECLs that
aren't parms at all, which may confuse other parts of the compiler.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu.org
           Assignee|aoliva at gcc dot gnu.org          |jamborm at gcc dot gnu.org

--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> ---
(In reply to Alexandre Oliva from comment #5)
> Martin, why doesn't SRA's modify_function use tree_versioning's args_to_skip
> infrastructure to remap the function

Because it does a few more transformations than just plain removal.
In fact, the plan (very long term, apparently) is to replace
args_to_skip with something akin to IPA-SRA's adjustments so that we
can do all this in truly IPA way.

>, including its prototype, and instead
> makes an (incomplete) work itself?  We end up with cloned PARM_DECLs that
> aren't parms at all, which may confuse other parts of the compiler.

Well, it does that, of course, otherwise it would have never passed
the testsuite, it's just that, ehm, the remapping from PARM_DECLS to
VAR_DECLs is not called when processing GIMPLE_ASMs.

I'll prepare a fix.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

--- Comment #8 from Martin Jambor <jamborm at gcc dot gnu.org> ---
For the record, the patch got into trunk as revision r228654, I made a
mistake in the ChangeLog tag and so it did not appear here.  I am
about to backport it to gcc 5.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

--- Comment #9 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Author: jamborm
Date: Mon Oct 26 14:36:43 2015
New Revision: 229367

URL: https://gcc.gnu.org/viewcvs?rev=229367&root=gcc&view=rev
Log:
Also remap SSA_NAMEs of PARM_DECLs in IPA-SRA

2015-10-26  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/67794
        * tree-sra.c (replace_removed_params_ssa_names): Do not distinguish
        between types of statements but accept original definitions as a
        parameter.
        (ipa_sra_modify_function_body): Use FOR_EACH_SSA_DEF_OPERAND to
        iterate over definitions.

testsuite/
        * gcc.dg/ipa/ipa-sra-10.c: New test.
        * gcc.dg/torture/pr67794.c: Likewise.


Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.dg/ipa/ipa-sra-10.c
    branches/gcc-5-branch/gcc/testsuite/gcc.dg/torture/pr67794.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
    branches/gcc-5-branch/gcc/tree-sra.c

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[renlin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

renlin at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |renlin at gcc dot gnu.org

--- Comment #10 from renlin at gcc dot gnu.org ---
 (In reply to Martin Jambor from comment #9)
> Author: jamborm
> Date: Mon Oct 26 14:36:43 2015
> New Revision: 229367
> 
> URL: https://gcc.gnu.org/viewcvs?rev=229367&root=gcc&view=rev
> Log:
> Also remap SSA_NAMEs of PARM_DECLs in IPA-SRA
> 
> 2015-10-26  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR tree-optimization/67794
> 	* tree-sra.c (replace_removed_params_ssa_names): Do not distinguish
> 	between types of statements but accept original definitions as a
> 	parameter.
> 	(ipa_sra_modify_function_body): Use FOR_EACH_SSA_DEF_OPERAND to
> 	iterate over definitions.
> 
> testsuite/
>         * gcc.dg/ipa/ipa-sra-10.c: New test.
>         * gcc.dg/torture/pr67794.c: Likewise.
> 
> 
> Added:
>     branches/gcc-5-branch/gcc/testsuite/gcc.dg/ipa/ipa-sra-10.c
>     branches/gcc-5-branch/gcc/testsuite/gcc.dg/torture/pr67794.c
> Modified:
>     branches/gcc-5-branch/gcc/ChangeLog
>     branches/gcc-5-branch/gcc/testsuite/ChangeLog
>     branches/gcc-5-branch/gcc/tree-sra.c

Hi Martin,

After the backport patch to branch 5, aarch-none-elf fails to build because of
the following ICEs.

gcc/gcc/tree-sra.c: In function ‘tree_node*
replace_removed_params_ssa_names(tree, gimple_statement_base**,
ipa_parm_adjustment_vec)’:
gcc/gcc/tree-sra.c:4609:39: error: cannot convert ‘gimple_statement_base**’ to
‘gimple’ for argument ‘2’ to ‘tree_node* make_ssa_name(tree, gimple)’
gcc/gcc/tree-sra.c: In function ‘bool
ipa_sra_modify_function_body(ipa_parm_adjustment_vec)’:
gcc/gcc/tree-sra.c:4703:73: error: cannot convert ‘gphi*’ to
‘gimple_statement_base**’ for argument ‘2’ to ‘tree_node*
replace_removed_params_ssa_names(tree, gimple_statement_base**,
ipa_parm_adjustment_vec)’
gcc/gcc/tree-sra.c:4772:23: error: cannot convert ‘gimple’ to
‘gimple_statement_base**’ for argument ‘2’ to ‘tree_node*
replace_removed_params_ssa_names(tree, gimple_statement_base**,
ipa_parm_adjustment_vec)’
>From gcc-bugs-return-500677-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 27 11:32:15 2015
Return-Path: <gcc-bugs-return-500677-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10282 invoked by alias); 27 Oct 2015 11:32:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10236 invoked by uid 48); 27 Oct 2015 11:32:11 -0000
From: "vogt at linux dot vnet.ibm.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/67968] go1: internal compiler error: in write_specific_type_functions, at go/gofrontend/types.cc:1812
Date: Tue, 27 Oct 2015 11:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 5.2.1
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vogt at linux dot vnet.ibm.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67968-4-VOd75L4WSp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67968-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67968-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02232.txt.bz2
Content-length: 225

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg968

--- Comment #12 from Dominik Vogt <vogt at linux dot vnet.ibm.com> ---
The test code also crashes on x86_64 with the current gcc-5-branch and the
gcc-6 development branch.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[renlin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

--- Comment #11 from renlin at gcc dot gnu.org ---
> 
> Hi Martin,
> 
> After the backport patch to branch 5, aarch-none-elf fails to build because
> of the following ICEs.
> 

I mean "aarch64-none-elf" here, sorry for the typo.

[Bug tree-optimization/67794] [6 regression] internal compiler error: Segmentation fault

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67794

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #12 from Christophe Lyon <clyon at gcc dot gnu.org> ---
(In reply to Renlin Li from comment #11)
> > 
> > Hi Martin,
> > 
> > After the backport patch to branch 5, aarch-none-elf fails to build because
> > of the following ICEs.
> > 
> 
> I mean "aarch64-none-elf" here, sorry for the typo.

This was fixed at r229435.