[Bug go/67874] New: fd_unix.go does not build when there is fcntl64 and no fcntl syscall

[Bug go/67874] New: fd_unix.go does not build when there is fcntl64 and no fcntl syscall

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67874

            Bug ID: 67874
           Summary: fd_unix.go does not build when there is fcntl64 and no
                    fcntl syscall
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: pinskia at gcc dot gnu.org
                CC: cmang at google dot com
  Target Milestone: ---
            Target: aarch64-linux-gnu (ilp32)

Since a request from the ARM64 kernel maintainers on the ABI for AARCH64 ILP32
to just use off_t and time_t as 32bit rather than what I originally had it as
64bit, we use the compat syscalls instead which means there is no fcntl syscall
only fcntl64 now.

This breaks building fd_unix.go which depends on SYS_FCNTL being defined but
there is only SYS_FCNTL64 now.

[Bug go/67874] fd_unix.go does not build when there is fcntl64 and no fcntl syscall

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67874

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note I think tilegx32 target might have the same issue as it uses the new
generic syscall interface and there is no fcntl there either.

[Bug go/67874] fd_unix.go does not build when there is fcntl64 and no fcntl syscall

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67874

--- Comment #2 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Wed Oct  7 17:22:08 2015
New Revision: 228576

URL: https://gcc.gnu.org/viewcvs?rev=228576&root=gcc&view=rev
Log:
        PR go/67874
    net, runtime: Call C library fcntl function rather than syscall.Syscall.

    Not all systems define a fcntl syscall; some only have fcntl64.

    Fixes GCC PR go/67874.

    Reviewed-on: https://go-review.googlesource.com/15497

Modified:
    trunk/gcc/go/gofrontend/MERGE
    trunk/libgo/go/net/fd_unix.go
    trunk/libgo/runtime/go-varargs.c

[Bug go/67874] fd_unix.go does not build when there is fcntl64 and no fcntl syscall

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67874

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Ian Lance Taylor <ian at airs dot com> ---
Should be fixed.