From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-499892-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 64451 invoked by alias); 18 Oct 2015 21:44:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 64420 invoked by uid 48); 18 Oct 2015 21:44:12 -0000
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67900] [4.9/5/6 Regression] Interface bug: Binding parameters to C causes a compiler segmentation fault.
Date: Sun, 18 Oct 2015 21:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.1.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mikael at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-67900-4-Wg2qqyoHlM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67900-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67900-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01447.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67900

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #4 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to kargl from comment #2)
> Index: resolve.c
> ===================================================================
> --- resolve.c   (revision 228206)
> +++ resolve.c   (working copy)
> @@ -10702,7 +10702,7 @@ gfc_verify_binding_labels (gfc_symbol *s
>        sym->binding_label = NULL;
>  
>      }
> -  else if (sym->attr.flavor == FL_VARIABLE
> +  else if (sym->attr.flavor == FL_VARIABLE && module
>            && (strcmp (module, gsym->mod_name) != 0
>                || strcmp (sym->name, gsym->sym_name) != 0))
>      {

There is another instance of this a few lines down where the check for module
!= NULL existed at the time this code was introduced at r199120.
So this patch is at least consistent.