[Bug target/67940] New: Wrong stack alignment adjustment

[Bug target/67940] New: Wrong stack alignment adjustment

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67940

            Bug ID: 67940
           Summary: Wrong stack alignment adjustment
           Product: gcc
           Version: 5.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: ubizjak at gmail dot com
  Target Milestone: ---

On gcc-5-branch, i386 has

  if (stack_realign_fp)
    offset = (offset + stack_alignment_needed) & -stack_alignment_needed;
...
         to pass verification of stack_pointer_offset at the end.  */
      m->fs.sp_offset = (m->fs.sp_offset + align_bytes) & -align_bytes;

-1 is missing.

[Bug target/67940] Wrong stack alignment adjustment

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67940

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
This doesn't need a PR. Just commit the (pre-approved) obvious patch.
>From gcc-bugs-return-499357-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 12 17:33:14 2015
Return-Path: <gcc-bugs-return-499357-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 56101 invoked by alias); 12 Oct 2015 17:33:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 56074 invoked by uid 48); 12 Oct 2015 17:33:11 -0000
From: "jsm28 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/59412] __fixunsdfDI triggers wrong inexact exceptions
Date: Mon, 12 Oct 2015 17:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgcc
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jsm28 at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59412-4-UOdOZWrR90@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59412-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59412-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg00912.txt.bz2
Content-length: 471

https://gcc.gnu.org/bugzilla/show_bug.cgi?idY412

--- Comment #1 from Joseph S. Myers <jsm28 at gcc dot gnu.org> ---
Note that in addition to spurious "inexact" exceptions, this division can cause
spurious "underflow" exceptions when converting tiny values to integer 0.
Other spurious exceptions can occur in overflow cases, when only "invalid"
should be raised, and the signed conversions wrapping this function can fail to
raise "invalid" for some overflow cases.

[Bug target/67940] Wrong stack alignment adjustment

[hjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67940

--- Comment #2 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> ---
Author: hjl
Date: Mon Oct 12 17:36:21 2015
New Revision: 228732

URL: https://gcc.gnu.org/viewcvs?rev=228732&root=gcc&view=rev
Log:
Correct x86 backend stack alignment adjustment

Add missing -1 in x86 backend stack alignment adjustment.  Trunk is OK
with ROUND_UP macro.

        PR target/67940
        * config/i386/i386.c (ix86_compute_frame_layout): Correct
        stack alignment adjustment.
        (ix86_expand_prologue): Likewise.

Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/i386/i386.c

[Bug target/67940] Wrong stack alignment adjustment

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67940

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.