[Bug target/67963] New: -march=lakemont generates x87 instructions

[Bug target/67963] New: -march=lakemont generates x87 instructions

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

            Bug ID: 67963
           Summary: -march=lakemont generates x87 instructions
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: julia.koval at intel dot com, ubizjak at gmail dot com
  Target Milestone: ---

[hjl@gnu-6 gcc]$ cat x.c
float
foo (void)
{
  return 0;
}
[hjl@gnu-6 gcc]$ ./xgcc -B./ -march=lakemont -S x.c -m32
[hjl@gnu-6 gcc]$ cat x.s
        .file   "x.c"
        .text
        .globl  foo
        .type   foo, @function
foo:
.LFB0:
        .cfi_startproc
        pushl   %ebp
        .cfi_def_cfa_offset 8
        .cfi_offset 5, -8
        movl    %esp, %ebp
        .cfi_def_cfa_register 5
        fldz
        popl    %ebp
        .cfi_restore 5
        .cfi_def_cfa 4, 4
        ret
        .cfi_endproc
.LFE0:
        .size   foo, .-foo
        .ident  "GCC: (GNU) 6.0.0 20151006 (experimental)"
        .section        .note.GNU-stack,"",@progbits
[hjl@gnu-6 gcc]$ 

We should issue an error if -march=lakemont is used without -miacmu.

[Bug target/67963] -march=lakemont generates x87 instructions

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to H.J. Lu from comment #0)
> We should issue an error if -march=lakemont is used without -miacmu.

We should issue an error if -march=lakemont is used without -mno-80387,
not without -miamcu.

[Bug target/67963] -march=lakemont generates x87 instructions

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to H.J. Lu from comment #1)
> (In reply to H.J. Lu from comment #0)
> > We should issue an error if -march=lakemont is used without -miacmu.
> 
> We should issue an error if -march=lakemont is used without -mno-80387,
> not without -miamcu.

-march=lakemont should imply -mno-80387.

[Bug target/67963] -march=lakemont generates x87 instructions

[julia.koval at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #3 from Yulia Koval <julia.koval at intel dot com> ---
Patch posted at:

https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01369.html

The same test with this patch:

objdump -d test.o

test.o:     file format elf32-i386


Disassembly of section .text:

00000000 <foo>:
   0:   55                      push   %ebp
   1:   89 e5                   mov    %esp,%ebp
   3:   a1 00 00 00 00          mov    0x0,%eax
   8:   5d                      pop    %ebp
   9:   c3                      ret

[Bug target/67963] -march=lakemont generates x87 instructions

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
I have a patch that moves -m80387 to ISA flags.
>From gcc-bugs-return-499610-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 15 10:00:04 2015
Return-Path: <gcc-bugs-return-499610-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 56651 invoked by alias); 15 Oct 2015 10:00:03 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 56515 invoked by uid 48); 15 Oct 2015 09:59:59 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/67513] ASAN: Not optimal shadow value check (unlikely condition checked in fast path)
Date: Thu, 15 Oct 2015 10:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 5.2.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status assigned_to
Message-ID: <bug-67513-4-eEfNjAH5g4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67513-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67513-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01165.txt.bz2
Content-length: 478

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg513

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|mpolacek at gcc dot gnu.org        |unassigned at gcc dot gnu.org

--- Comment #10 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Not actively working on this.

[Bug target/67963] -march=lakemont generates x87 instructions

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #5 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Uroš Bizjak from comment #4)
> I have a patch that moves -m80387 to ISA flags.

Not really. To be attached much simpler patch introduces PTA_NO_80387 and
changes target flags instead.
>From gcc-bugs-return-499617-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 15 11:23:16 2015
Return-Path: <gcc-bugs-return-499617-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 129652 invoked by alias); 15 Oct 2015 11:23:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 129592 invoked by uid 48); 15 Oct 2015 11:23:12 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/67963] -march=lakemont generates x87 instructions
Date: Thu, 15 Oct 2015 11:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-67963-4-spLRk8XkGu@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67963-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67963-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01172.txt.bz2
Content-length: 257

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 36516
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36516&action=edit
Patch that introduces PTA_NO_80387
>From gcc-bugs-return-499618-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 15 11:48:52 2015
Return-Path: <gcc-bugs-return-499618-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 116670 invoked by alias); 15 Oct 2015 11:48:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 116627 invoked by uid 48); 15 Oct 2015 11:48:48 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/65809] [5/6 Regression] FAIL: gcc.dg/debug/pr65771.c -gstabs+* -O* (test for excess errors)
Date: Thu, 15 Oct 2015 11:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: debug
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-65809-4-f9bBtxstOc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65809-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65809-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01173.txt.bz2
Content-length: 573

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide809

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> This PR seems to have been fixed between r224139 (test for excess errors)
> and 224288 (UNSUPPORTED).

Fixed by r228273. Closing as FIXED.

[Bug target/67963] -march=lakemont generates x87 instructions

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36516|0                           |1
        is obsolete|                            |

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 36517
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36517&action=edit
V2 patch that introduces PTA_NO_80387
>From gcc-bugs-return-499622-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 15 12:21:09 2015
Return-Path: <gcc-bugs-return-499622-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32935 invoked by alias); 15 Oct 2015 12:21:09 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32877 invoked by uid 48); 15 Oct 2015 12:21:04 -0000
From: "josephpattara at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61577] [4.9.0] can't compile on hp-ux v3 ia64
Date: Thu, 15 Oct 2015 12:21:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: josephpattara at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61577-4-4rz2DVm0rf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61577-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61577-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01177.txt.bz2
Content-length: 223

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida577

--- Comment #4 from Joseph John <josephpattara at gmail dot com> ---
I tried with source build for 4.9.2 and 4.9.3 but both of them resulted in same
ld relocation error.

[Bug target/67963] -march=lakemont generates x87 instructions

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Uroš Bizjak from comment #7)
> Created attachment 36517 [details]
> V2 patch that introduces PTA_NO_80387

We need some testcases to verify it works on command line as well
as with __attribute__((target("arch=...."))).
>From gcc-bugs-return-499625-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 15 12:31:13 2015
Return-Path: <gcc-bugs-return-499625-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 113033 invoked by alias); 15 Oct 2015 12:31:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 112992 invoked by uid 48); 15 Oct 2015 12:31:09 -0000
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/67975] New: Failure to optimise equality between two call sequences
Date: Thu, 15 Oct 2015 12:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: rsandifo at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-67975-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01180.txt.bz2
Content-length: 928

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg975

            Bug ID: 67975
           Summary: Failure to optimise equality between two call
                    sequences
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rsandifo at gcc dot gnu.org
  Target Milestone: ---

We don't simplify the following test to "return 1", even with fast
math enabled:

int
f1 (double x, double y)
{
  double z1 = __builtin_cos(y<10 ? x : __builtin_tan(x<20 ? x : y));
  double z2 = __builtin_cos(y<10 ? x : __builtin_tan(x<20 ? x : y));
  return z1 == z2;
}

whereas we do for:

int
f1 (double x, double y)
{
  return (__builtin_cos(y<10 ? x : __builtin_tan(x<20 ? x : y))
          == __builtin_cos(y<10 ? x : __builtin_tan(x<20 ? x : y)));
}

[Bug target/67963] -march=lakemont generates x87 instructions

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |6.0

--- Comment #10 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.

[Bug target/67963] -march=lakemont generates x87 instructions

[hjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67963

--- Comment #9 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> ---
Author: hjl
Date: Tue Oct 20 15:12:37 2015
New Revision: 229082

URL: https://gcc.gnu.org/viewcvs?rev=229082&root=gcc&view=rev
Log:
Properly handle -miamcu and -march=lakemont

-miamcu specifies how parameters are passed to functions and how value
is returned from a function.  Inside function,  we can use instructions
supported by -march=XXX.  -miamcu -march=haswell can generate x87, SSE
and AVX instructions as long as the IA MCU psABI is followed.  But since
Lakemont processor doesn't support x87 instructions, we shouldn't
generate x87 instructions with -march=lakemont.  This patch separates
code generation from -miamcu and makes -march=lakemont not to generate
x87 instructions.

gcc/

        PR target/67963
        PR target/67985
        * common/config/i386/i386-common.c (ix86_handle_option): Remove
        OPT_miamcu handling.
        * config/i386/i386.c (PTA_NO_80387): New macro.
        (processor_alias_table): Add PTA_NO_80387 to lakemont.
        (ix86_option_override_internal): Update MASK_80387 from
        PTA_NO_80387.  Don't warn x87/MMX/SSE/AVX for -miamcu.  Warn
        SSE math only if 80387 is supported.  Don't change
        MASK_FLOAT_RETURNS.
        (ix86_valid_target_attribute_tree): Enable FPMATH_387 only if
        80387 is supported.
        * config/i386/i386.h (TARGET_FLOAT_RETURNS_IN_80387): True only
        if TARGET_80387 is true and TARGET_IAMCU is false.
        (TARGET_FLOAT_RETURNS_IN_80387_P): True only if TARGET_80387_P
        is true and TARGET_IAMCU_P is false.

gcc/testsuite/

        PR target/67963
        PR target/67985
        * gcc.target/i386/pr67963-1.c: New test.
        * gcc.target/i386/pr67963-2.c: Likewise.
        * gcc.target/i386/pr67963-3.c: Likewise.
        * gcc.target/i386/pr67985-1.c: Likewise.
        * gcc.target/i386/pr67985-2.c: Likewise.
        * gcc.target/i386/pr67985-3.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr67963-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr67963-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr67963-3.c
    trunk/gcc/testsuite/gcc.target/i386/pr67985-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr67985-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr67985-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/common/config/i386/i386-common.c
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/i386/i386.h
    trunk/gcc/testsuite/ChangeLog