public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
@ 2015-10-14 13:32 jsm28 at gcc dot gnu.org
2015-10-14 13:44 ` [Bug c/67964] " rguenth at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2015-10-14 13:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
Bug ID: 67964
Summary: [4.9/5/6 Regression] Multiple attributes wrongly
accepted without commas
Product: gcc
Version: 6.0
Status: UNCONFIRMED
Keywords: accepts-invalid
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: jsm28 at gcc dot gnu.org
Target Milestone: ---
GCC wrongly accepts:
extern int foo (void) __attribute__ ((const const));
Multiple attributes inside a single __attribute__ (()) should be required to be
separated by commas, so ((const, const)). Bug introduced in 4.1 with the new C
parser.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67964] [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
2015-10-14 13:44 ` [Bug c/67964] " rguenth at gcc dot gnu.org
@ 2015-10-14 13:44 ` rguenth at gcc dot gnu.org
2015-10-20 13:25 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-10-14 13:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-10-14
Target Milestone|4.9.4 |6.0
Ever confirmed|0 |1
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed. No need to fix on branches.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67964] [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
@ 2015-10-14 13:44 ` rguenth at gcc dot gnu.org
2015-10-14 13:44 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-10-14 13:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.9.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67964] [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
2015-10-14 13:44 ` [Bug c/67964] " rguenth at gcc dot gnu.org
2015-10-14 13:44 ` rguenth at gcc dot gnu.org
@ 2015-10-20 13:25 ` mpolacek at gcc dot gnu.org
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-10-20 13:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mpolacek at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Taking.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67964] [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
` (3 preceding siblings ...)
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
@ 2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-10-20 16:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Oct 20 16:53:45 2015
New Revision: 229091
URL: https://gcc.gnu.org/viewcvs?rev=229091&root=gcc&view=rev
Log:
PR c/67964
* c-parser.c (c_parser_attributes): Break out of the loop if the
token after an attribute isn't a comma.
* gcc.dg/pr67964.c: New test.
Added:
trunk/gcc/testsuite/gcc.dg/pr67964.c
Modified:
trunk/gcc/c/ChangeLog
trunk/gcc/c/c-parser.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/67964] [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
` (2 preceding siblings ...)
2015-10-20 13:25 ` mpolacek at gcc dot gnu.org
@ 2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2015-10-20 16:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67964
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed. Not backporting this patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-20 16:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-14 13:32 [Bug c/67964] New: [4.9/5/6 Regression] Multiple attributes wrongly accepted without commas jsm28 at gcc dot gnu.org
2015-10-14 13:44 ` [Bug c/67964] " rguenth at gcc dot gnu.org
2015-10-14 13:44 ` rguenth at gcc dot gnu.org
2015-10-20 13:25 ` mpolacek at gcc dot gnu.org
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
2015-10-20 16:54 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).