[Bug target/68018] New: [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[Bug target/68018] New: [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

            Bug ID: 68018
           Summary: [6 Regression] ICE: in ix86_compute_frame_layout, at
                    config/i386/i386.c:11308 with -mstackrealign
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---

Created attachment 36539
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36539&action=edit
reduced testcase

Compiler output:
$ gcc -O -mabi=ms -mstackrealign testcase.c 
testcase.c: In function 'fn1':
testcase.c:7:1: internal compiler error: in ix86_compute_frame_layout, at
config/i386/i386.c:11308
 }
 ^
0xe73ea0 ix86_compute_frame_layout
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.c:11308
0xe97196 ix86_expand_prologue()
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.c:12578
0x10453ba gen_prologue()
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.md:12282
0xe704b8 target_gen_prologue
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.md:18335
0x89a5af thread_prologue_and_epilogue_insns()
        /mnt/svn/gcc-trunk/gcc/function.c:5972
0x89b1f2 rest_of_handle_thread_prologue_and_epilogue
        /mnt/svn/gcc-trunk/gcc/function.c:6523
0x89b1f2 execute
        /mnt/svn/gcc-trunk/gcc/function.c:6565
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

$ gcc -v                                    
Using built-in specs.
COLLECT_GCC=/mnt/svn/gcc-trunk/binary-latest/bin/gcc
COLLECT_LTO_WRAPPER=/mnt/svn/gcc-trunk/binary-228793-lto-fortran-checking-yes-rtl-df/libexec/gcc/x86_64-pc-linux-gnu/6.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /mnt/svn/gcc-trunk//configure --enable-checking=yes,rtl,df
--enable-languages=c,c++,lto,fortran
--prefix=/mnt/svn/gcc-trunk/binary-228793-lto-fortran-checking-yes-rtl-df/
--without-cloog --without-ppl --without-isl
Thread model: posix
gcc version 6.0.0 20151014 (experimental) (GCC) 

Tested revisions:
r228793 - ICE
5_branch r228441 - OK

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
Some parts of gcc still assume that MS_ABI stack is always aligned to 128bits.

Proposed patch:

--cut here--
@@ -11283,7 +11296,8 @@ ix86_compute_frame_layout (struct ix86_frame *fram
      function prologues and leaf.  */
   if ((TARGET_64BIT_MS_ABI && crtl->preferred_stack_boundary < 128)
       && (!crtl->is_leaf || cfun->calls_alloca != 0
-          || ix86_current_function_calls_tls_descriptor))
+         || ix86_current_function_calls_tls_descriptor
+         || ix86_incoming_stack_boundary < 128))
     {
       crtl->preferred_stack_boundary = 128;
       crtl->stack_alignment_needed = 128;
--cut here--
>From gcc-bugs-return-499973-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 19 21:09:57 2015
Return-Path: <gcc-bugs-return-499973-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 4086 invoked by alias); 19 Oct 2015 21:09:57 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4047 invoked by uid 55); 19 Oct 2015 21:09:53 -0000
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/68019] ICE on rank mismatch of implied-shape array of user-defined type
Date: Mon, 19 Oct 2015 21:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.2.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: kargl at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: kargl at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-68019-4-0h8ck1W03y@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-68019-4@http.gcc.gnu.org/bugzilla/>
References: <bug-68019-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01528.txt.bz2
Content-length: 701

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh019

--- Comment #2 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Mon Oct 19 21:09:21 2015
New Revision: 229003

URL: https://gcc.gnu.org/viewcvs?rev"9003&root=gcc&view=rev
Log:
2015-10-19  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/68019
        * decl.c (add_init_expr_to_sym): Remove an assert() to allow an error
        message to be issued.

2015-10-19  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/68019
        * gfortran.dg/pr68019.f90: new test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr68019.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #2 from Zdenek Sojka <zsojka at seznam dot cz> ---
I am also seeing this (or another in ix86_compute_frame_layout) ICE when
running the gfortran testsuite. Again with -mstackrealing. I will post the
testcase when I get home.

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Zdenek Sojka from comment #2)
> I am also seeing this (or another in ix86_compute_frame_layout) ICE when
> running the gfortran testsuite. Again with -mstackrealing. I will post the
> testcase when I get home.

-mstackrealign is a new functionality on MS_ABI targets, and there are some
places in the compiler that assume that these targets are always aligned to
16bytes. This alignment is in fact mandated by ABI, and all deviations can be
considered ABI violations. However, we can relax this restriction in order to
handle rough applications that misalign the stack, but this should in general
be an exception, not the rule.

That said, even if -mstackrealign can be declared as unsupported on MS_ABI
targets, the infrastructure handles realignment just fine also for MS_ABI
targets, we just need to enable correct code paths when incoming stack boundary
is less than 16 bytes. This is exactly what the patch in comment #1 does.

BTW: I'm not in the position to test MS_ABI targets thoroughly, so I'd ask you
to please conduct your tests with the patch from Comment #1.
>From gcc-bugs-return-500007-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 20 08:25:33 2015
Return-Path: <gcc-bugs-return-500007-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 37905 invoked by alias); 20 Oct 2015 08:25:31 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 37860 invoked by uid 48); 20 Oct 2015 08:25:24 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/68017] [5 Regression] ICE on valid code at -O3 with -g enabled on x86_64-linux-gnu: cannot update SSA form
Date: Tue, 20 Oct 2015 08:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on assigned_to short_desc everconfirmed
Message-ID: <bug-68017-4-d07BYp4oRE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-68017-4@http.gcc.gnu.org/bugzilla/>
References: <bug-68017-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01562.txt.bz2
Content-length: 1458

https://gcc.gnu.org/bugzilla/show_bug.cgi?idh017

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-10-20
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
            Summary|ICE on valid code at -O3    |[5 Regression] ICE on valid
                   |with -g enabled on          |code at -O3 with -g enabled
                   |x86_64-linux-gnu: cannot    |on x86_64-linux-gnu: cannot
                   |update SSA form             |update SSA form
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  tailcall does

  /* Remove the code after call_gsi that will become unreachable.  The
     possibly unreachable code in other blocks is removed later in
     cfg cleanup.  */
  gsi = t->call_gsi;
  gsi_next (&gsi);
  while (!gsi_end_p (gsi))
    {
      gimple *t = gsi_stmt (gsi);
      /* Do not remove the return statement, so that redirect_edge_and_branch
         sees how the block ends.  */
      if (gimple_code (t) == GIMPLE_RETURN)
        break;

      gsi_remove (&gsi, true);
      release_defs (t);
    }

but for proper debug handling it needs to remove the stmts backwards.

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #4 from uros at gcc dot gnu.org ---
Author: uros
Date: Wed Oct 21 08:43:44 2015
New Revision: 229120

URL: https://gcc.gnu.org/viewcvs?rev=229120&root=gcc&view=rev
Log:
        PR target/68018
        * config/i386/i386.c (ix86_compute_frame_layout): Realign the stack
        for 64-bit MS_ABI targets also when default incoming stack boundary
        is overriden.

testsuite/ChangeLog:

        PR target/68018
        * gcc.target/i386/pr68018.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr68018.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #5 from Zdenek Sojka <zsojka at seznam dot cz> ---
I did a test run with r229094 + the patch applied, and there are no ICEs. All
the ICEs archived from older runs are gone, and no new ones are introduced (eg.
everything that failed in the past now compiles fine). I can only test for
ICEs, not for exec failures.

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

--- Comment #6 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu Oct 22 06:52:00 2015
New Revision: 229162

URL: https://gcc.gnu.org/viewcvs?rev=229162&root=gcc&view=rev
Log:
        Backport from mainline
        2015-10-21  Uros Bizjak  <ubizjak@gmail.com>

        PR target/68018
        * config/i386/i386.c (ix86_compute_frame_layout): Realign the stack
        for 64-bit MS_ABI targets also when default incoming stack boundary
        is overriden.

testsuite/ChangeLog:

        Backport from mainline
        2015-10-21  Uros Bizjak  <ubizjak@gmail.com>

        PR target/68018
        * gcc.target/i386/pr68018.c: New test.
        Backport from mainline
        2015-10-21  Uros Bizjak  <ubizjak@gmail.com>

        PR target/68018
        * config/i386/i386.c (ix86_compute_frame_layout): Realign the stack
        for 64-bit MS_ABI targets also when default incoming stack boundary
        is overriden.

testsuite/ChangeLog:

        Backport from mainline
        2015-10-21  Uros Bizjak  <ubizjak@gmail.com>

        PR target/68018
        * gcc.target/i386/pr68018.c: New test.


Added:
    branches/gcc-5-branch/gcc/testsuite/gcc.target/i386/pr68018.c
Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/config/i386/i386.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/68018] [6 Regression] ICE: in ix86_compute_frame_layout, at config/i386/i386.c:11308 with -mstackrealign

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68018

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|6.0                         |5.3

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-500251-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 22 08:12:39 2015
Return-Path: <gcc-bugs-return-500251-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 66890 invoked by alias); 22 Oct 2015 08:12:38 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 65298 invoked by uid 48); 22 Oct 2015 08:12:35 -0000
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/67989] [REGRESSION] g++ ICE on armel valid code
Date: Thu, 22 Oct 2015 08:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 5.2.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo.carlini at oracle dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-67989-4-pO1QCVvBzZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67989-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67989-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg01806.txt.bz2
Content-length: 585

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg989

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
For the record: given the actual error, can't be one of my two C++ front-end
patches. I'm also pretty sure isn't a C++ front-end issue at all.

Richard, sorry for bothering, can you have a look?