[Bug bootstrap/68041] New: [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[Bug bootstrap/68041] New: [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

            Bug ID: 68041
           Summary: [6 Regression] Bootstrap broken on
                    x86_64-apple-darwin14 at revision r229119
           Product: gcc
           Version: 6.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: chefmax at gcc dot gnu.org, iains at gcc dot gnu.org,
                    rguenth at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-apple-darwin14
            Target: x86_64-apple-darwin14
             Build: x86_64-apple-darwin14

Bootstrap broken on x86_64-apple-darwin14 at revision r229119 (likely r229111):

...
libtool: link:  /opt/gcc/build_w/./gcc/xgcc -shared-libgcc
-B/opt/gcc/build_w/./gcc -nostdinc++
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/src
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/src/.libs
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/libsupc++/.libs
-B/opt/gcc/gcc6w/x86_64-apple-darwin14.5.0/bin/
-B/opt/gcc/gcc6w/x86_64-apple-darwin14.5.0/lib/ -isystem
/opt/gcc/gcc6w/x86_64-apple-darwin14.5.0/include -isystem
/opt/gcc/gcc6w/x86_64-apple-darwin14.5.0/sys-include    -dynamiclib
-Wl,-undefined -Wl,dynamic_lookup -o .libs/libasan.3.dylib 
.libs/asan_activation.o .libs/asan_allocator.o .libs/asan_debugging.o
.libs/asan_fake_stack.o .libs/asan_flags.o .libs/asan_globals.o
.libs/asan_interceptors.o .libs/asan_linux.o .libs/asan_mac.o
.libs/asan_malloc_linux.o .libs/asan_malloc_mac.o .libs/asan_malloc_win.o
.libs/asan_new_delete.o .libs/asan_poisoning.o .libs/asan_posix.o
.libs/asan_report.o .libs/asan_rtl.o .libs/asan_stack.o .libs/asan_stats.o
.libs/asan_suppressions.o .libs/asan_thread.o .libs/asan_win.o
.libs/asan_win_dll_thunk.o .libs/asan_win_dynamic_runtime_thunk.o  
-Wl,-force_load,../sanitizer_common/.libs/libsanitizer_common.a
-Wl,-force_load,../lsan/.libs/libsanitizer_lsan.a 
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/src/.libs
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/src
-L/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libstdc++-v3/libsupc++/.libs -lrt
-lpthread -ldl ../../libstdc++-v3/src/.libs/libstdc++.dylib -lm   
-install_name  /opt/gcc/gcc6w/lib/libasan.3.dylib -compatibility_version 4
-current_version 4.0 -Wl,-single_module
ld: library not found for -lrt
collect2: error: ld returned 1 exit status
Makefile:446: recipe for target 'libasan.la' failed
make[4]: *** [libasan.la] Error 1
make[4]: Leaving directory
'/opt/gcc/build_w/x86_64-apple-darwin14.5.0/libsanitizer/asan'
...

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #1 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Yes, this is mine.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #2 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Created attachment 36555
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36555&action=edit
First version of the fix.

Dominique, I'm sorry about that. Could you please try attached patch? There may
be other errors for Darwin in libsanitizer build (I didn't make proper testing
because of lack of target) and it would be great to fix them here too.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-10-21
     Ever confirmed|0                           |1

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Created attachment 36555 [details]
> First version of the fix.
>
> Dominique, I'm sorry about that. Could you please try attached patch?
> There may be other errors for Darwin in libsanitizer build (I didn't
> make proper testing because of lack of target) and it would be great
> to fix them here too.

Thanks for the quick answer. Bootstrap with the patch in progress, allow for ~2
hours.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
With the patch in comment 2, bootstrap completed without any problem.

Preliminary tests for g++ and asan

                === g++ Summary for unix/-m64 ===

# of expected passes            1007
# of unexpected failures        14
# of unsupported tests          179

                === g++ Summary ===

# of expected passes            2021
# of unexpected failures        21
# of unsupported tests          358

the failures are

FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O0  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O1  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O2  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O3 -g  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -Os  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O2 -flto
-flto-partition=none  output pattern test
FAIL: c-c++-common/asan/sanity-check-pure-c-1.c   -O2 -flto  output pattern
test

for both -m32 and -m64, and

FAIL: c-c++-common/asan/memcmp-1.c   -O0  output pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -O1  output pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -O2  output pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -O3 -g  output pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -Os  output pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -O2 -flto -flto-partition=none  output
pattern test
FAIL: c-c++-common/asan/memcmp-1.c   -O2 -flto  output pattern test

for -m64 only.

How many lines of the output do you need to adjust the regexps?

Further tests for ubsan and gcc in progress.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Further tests for ubsan and gcc in progress.

g++/ubsan

                === g++ Summary for unix/-m64 ===

# of expected passes            2950
# of expected failures          49
# of unsupported tests          175

                === g++ Summary ===

# of expected passes            5837
# of expected failures          98
# of unsupported tests          371

gcc/asan (same failures as for g++/asan)

                === gcc Summary for unix/-m64 ===

# of expected passes            904
# of unexpected failures        14
# of unsupported tests          156

                === gcc Summary ===

# of expected passes            1815
# of unexpected failures        21
# of unsupported tests          312

gcc/ubsan

                === gcc Summary for unix/-m64 ===

# of expected passes            2346
# of unsupported tests          157

                === gcc Summary ===

# of expected passes            4629
# of unsupported tests          335

> Thanks! These tests passed before, right? So, could you share more
> details about these tests output (perhaps open a new bug with sanitizer
> label)?

I'll do that later today.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I'll do that later today.

pr68042.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #8 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Created attachment 36556
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36556&action=edit
The patch I've posted to gcc-patches ML for review.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Created attachment 36556 [details]
> The patch I've posted to gcc-patches ML for review.

I have not tested the part "removes -lc++abi flag for UBSan on Darwin" (later
tonight).
Comment from Iain Sandoe on IRC:

 <iains> we don't use libc++ anyway on GCC, so academic
 <iains> i.e. "it seems the right thing to do"

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #10 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #9)
> > Created attachment 36556 [details]
> > The patch I've posted to gcc-patches ML for review.
> 
> I have not tested the part "removes -lc++abi flag for UBSan on Darwin"
> (later tonight).
> Comment from Iain Sandoe on IRC:
> 
>  <iains> we don't use libc++ anyway on GCC, so academic
>  <iains> i.e. "it seems the right thing to do"


The patch was approved by Mike in ML
(https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02127.html).

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #11 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Author: chefmax
Date: Thu Oct 22 09:47:17 2015
New Revision: 229168

URL: https://gcc.gnu.org/viewcvs?rev=229168&root=gcc&view=rev
Log:
Fix bootstrap on x86_64-apple-darwin14 after r229119.

libsanitizer/

        PR bootstrap/68041
        * configure.ac (link_sanitizer_common): Link against librt only if it
        contains shm_open, required by sanitizers.
        (CXX_ABI_NEEDED): Remove variable.
        * configure: Regenerate.
        * ubsan/Makefile.am (libubsan_la_LIBADD): Do not add -lc++abi anymore.
        * ubsan/Makefile.in: Regenerate.


Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/configure
    trunk/libsanitizer/configure.ac
    trunk/libsanitizer/ubsan/Makefile.am
    trunk/libsanitizer/ubsan/Makefile.in

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

--- Comment #12 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Should be fixed on trunk. Dominique, let me know if the issue still occurs.

[Bug bootstrap/68041] [6 Regression] Bootstrap broken on x86_64-apple-darwin14 at revision r229119

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68041

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Should be fixed on trunk. Dominique, let me know if the issue still occurs.

Bootstrap of revision r229173 just completed without any problem. Thanks for
the quick fix. Closing.