public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/68065] Size calculations for VLAs can overflow
Date: Tue, 27 Oct 2015 00:15:00 -0000	[thread overview]
Message-ID: <bug-68065-4-EGDudzsiLI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-68065-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68065

--- Comment #6 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Tue, 27 Oct 2015, ch3root at openwall dot com wrote:

> > VLA size overflow, however, is undefined behavior at runtime, not compile
> > time, hence a matter for ubsan.
> 
> VLA size overflow is very similar to overflow in "new". Shouldn't it be 
> handled in a similar way?

I'm thinking of it as essentially like stack overflow, where it's 
traditionally been the user's job to bound their stack allocations.  I 
think ubsan should enable all of (VLA size overflow checks, stack checking 
for fixed-size allocations to ensure the amount of stack space allocated 
in one go is small enough that overflow is guaranteed to be detected, 
similar checks for variable size allocations whether from VLAs or alloca).  
Of course separate options for various cases may make sense as well.


  parent reply	other threads:[~2015-10-27  0:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  8:36 [Bug c/68065] New: " ch3root at openwall dot com
2015-10-23  9:22 ` [Bug c/68065] " pinskia at gcc dot gnu.org
2015-10-23 16:22 ` joseph at codesourcery dot com
2015-10-27  0:06 ` ch3root at openwall dot com
2015-10-27  0:15 ` joseph at codesourcery dot com [this message]
2015-10-27 14:25 ` ch3root at openwall dot com
2015-10-27 17:09 ` joseph at codesourcery dot com
2015-10-27 18:29 ` danielmicay at gmail dot com
2015-10-28 11:28 ` ch3root at openwall dot com
2015-10-28 13:15 ` joseph at codesourcery dot com
2015-10-28 16:35 ` ebotcazou at gcc dot gnu.org
2015-10-28 23:30 ` ch3root at openwall dot com
2015-10-28 23:38 ` joseph at codesourcery dot com
2015-10-28 23:43 ` ch3root at openwall dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-68065-4-EGDudzsiLI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).