public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "ch3root at openwall dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/68065] New: Size calculations for VLAs can overflow Date: Fri, 23 Oct 2015 08:36:00 -0000 [thread overview] Message-ID: <bug-68065-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68065 Bug ID: 68065 Summary: Size calculations for VLAs can overflow Product: gcc Version: 5.2.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: ch3root at openwall dot com Target Milestone: --- The following program crashes while writing to a buffer: #include <stdint.h> #include <stdio.h> int main(void) { size_t size = SIZE_MAX / sizeof(int) + 2; int buf[size]; printf("%zu\n", sizeof(buf)); for (size_t i = 0; i < size; i++) buf[i] = 1; return 0; } (Compile without optimization or make sure the loop is not optimized away.) It would be better to detect an overflow in the size calculation and crash right away, before any harm is done. While at it, size of VLAs could probably be limited to PRTDIFF_MAX to be in line with ordinary arrays.
next reply other threads:[~2015-10-23 8:36 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-23 8:36 ch3root at openwall dot com [this message] 2015-10-23 9:22 ` [Bug c/68065] " pinskia at gcc dot gnu.org 2015-10-23 16:22 ` joseph at codesourcery dot com 2015-10-27 0:06 ` ch3root at openwall dot com 2015-10-27 0:15 ` joseph at codesourcery dot com 2015-10-27 14:25 ` ch3root at openwall dot com 2015-10-27 17:09 ` joseph at codesourcery dot com 2015-10-27 18:29 ` danielmicay at gmail dot com 2015-10-28 11:28 ` ch3root at openwall dot com 2015-10-28 13:15 ` joseph at codesourcery dot com 2015-10-28 16:35 ` ebotcazou at gcc dot gnu.org 2015-10-28 23:30 ` ch3root at openwall dot com 2015-10-28 23:38 ` joseph at codesourcery dot com 2015-10-28 23:43 ` ch3root at openwall dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-68065-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).