public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/68108] [6 regression] erroneous error message 'scalar integer expression expected'
Date: Tue, 27 Oct 2015 10:54:00 -0000 [thread overview]
Message-ID: <bug-68108-4-HggS5DTijL@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-68108-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68108
Mikael Morin <mikael at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mikael at gcc dot gnu.org
--- Comment #3 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to kargl from comment #1)
> Tentative patch
>
> Index: decl.c
> ===================================================================
> --- decl.c (revision 229390)
> +++ decl.c (working copy)
> @@ -754,7 +754,8 @@ char_len_param_value (gfc_expr **expr, b
>
> gfc_reduce_init_expr (e);
>
> - if ((e->ref && e->ref->u.ar.type != AR_ELEMENT)
> + if ((e->ref && e->ref->type == REF_ARRAY
> + && e->ref->u.ar.type != AR_ELEMENT)
> || (!e->ref && e->expr_type == EXPR_ARRAY))
There is another unguarded ref->u.ar access a few lines above.
It doesn't trigger as often, because it's a == condition, but it's still worth
fixing.
Otherwise looks good.
next prev parent reply other threads:[~2015-10-27 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-68108-4@http.gcc.gnu.org/bugzilla/>
2015-10-27 9:51 ` rguenth at gcc dot gnu.org
2015-10-27 10:52 ` mikael at gcc dot gnu.org
2015-10-27 10:54 ` mikael at gcc dot gnu.org [this message]
2015-10-27 13:44 ` sgk at troutmask dot apl.washington.edu
2015-10-27 16:43 ` kargl at gcc dot gnu.org
2015-10-27 16:48 ` kargl at gcc dot gnu.org
2015-10-29 19:38 ` kargl at gcc dot gnu.org
2015-10-29 19:41 ` kargl at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-68108-4-HggS5DTijL@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).