From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 713ED39540E0; Mon,  3 May 2021 17:36:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 713ED39540E0
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/68942] overly strict use of deleted function before
 argument-dependent lookup (ADL)
Date: Mon, 03 May 2021 17:36:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 5.2.1
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-68942-4-AtqGfq4hL2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-68942-4@http.gcc.gnu.org/bugzilla/>
References: <bug-68942-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 03 May 2021 17:36:32 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D68942

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:eef4fa6968ae0682679c27dae06409db3d113d5d

commit r12-391-geef4fa6968ae0682679c27dae06409db3d113d5d
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon May 3 13:35:26 2021 -0400

    c++: mark_used and ADL with template-id [PR100344]

    My r11-295 patch for PR68942 didn't consider that the callee of an
    ADL-eligible function call can be a TEMPLATE_ID_EXPR, and we don't want
    to disable mark_used when substituting into the template arguments of
    this TEMPLATE_ID_EXPR because the arguments are clearly used regardless
    of the outcome of ADL.  In the first testcase below, this oversight
    causes us to trip over the assert in build_call_a for the call to
    find_index<int> because the function no longer had its TREE_USED bit set
    from mark_used.

    So this patch restricts the original fix to disable mark_used only when
    the callee is a FUNCTION_DECL, which seems to be the only case that
    matters for PR68942.  For instance, in the second testcase below we
    already don't mark_used the deleted function specialization even before
    r11-295.

    gcc/cp/ChangeLog:

            PR c++/68942
            PR c++/100344
            * pt.c (tsubst_copy_and_build) <case CALL_EXPR>: Set tf_conv
            only when the callee is a FUNCTION_DECL.

    gcc/testsuite/ChangeLog:

            PR c++/68942
            PR c++/100344
            * g++.dg/template/call8.C: New test.
            * g++.dg/template/koenig12a.C: New test.=