[Bug c/6940] taking sizeof array parameter should trigger a warning

[Bug c/6940] taking sizeof array parameter should trigger a warning

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=6940

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mpolacek at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.10.0

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
On it.

[Bug c/6940] taking sizeof array parameter should trigger a warning

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=6940

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Sun Jul  6 19:00:10 2014
New Revision: 212312

URL: https://gcc.gnu.org/viewcvs?rev=212312&root=gcc&view=rev
Log:
    PR c/6940
    * doc/invoke.texi: Document -Wsizeof-array-argument.
c-family/
    * c.opt (Wsizeof-array-argument): New option.
c/
    * c-decl.c (grokdeclarator): Set C_ARRAY_PARAMETER.
    * c-tree.h (C_ARRAY_PARAMETER): Define.
    * c-typeck.c (c_expr_sizeof_expr): Warn when using sizeof on an array
    function parameter.
cp/
    * cp-tree.h (DECL_ARRAY_PARAMETER_P): Define.
    * decl.c (grokdeclarator): Set DECL_ARRAY_PARAMETER_P.
    * typeck.c (cxx_sizeof_expr): Warn when using sizeof on an array
    function parameter.
testsuite/
    * c-c++-common/Wsizeof-pointer-memaccess1.c: Use
    -Wno-sizeof-array-argument.
    * c-c++-common/Wsizeof-pointer-memaccess2.c: Likewise.
    * g++.dg/warn/Wsizeof-pointer-memaccess-1.C: Likewise.
    * gcc.dg/Wsizeof-pointer-memaccess1.c: Likewise.
    * g++.dg/torture/Wsizeof-pointer-memaccess1.C: Likewise.
    * g++.dg/torture/Wsizeof-pointer-memaccess2.C: Likewise.
    * gcc.dg/torture/Wsizeof-pointer-memaccess1.c: Likewise.
    * c-c++-common/sizeof-array-argument.c: New test.
    * gcc.dg/vla-5.c: Add dg-warnings.
../libgomp/
    * testsuite/libgomp.c/appendix-a/a.29.1.c (f): Add dg-warnings.

Added:
    trunk/gcc/testsuite/c-c++-common/sizeof-array-argument.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c.opt
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-decl.c
    trunk/gcc/c/c-tree.h
    trunk/gcc/c/c-typeck.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/typeck.c
    trunk/gcc/doc/invoke.texi
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/Wsizeof-pointer-memaccess1.c
    trunk/gcc/testsuite/c-c++-common/Wsizeof-pointer-memaccess2.c
    trunk/gcc/testsuite/g++.dg/torture/Wsizeof-pointer-memaccess1.C
    trunk/gcc/testsuite/g++.dg/torture/Wsizeof-pointer-memaccess2.C
    trunk/gcc/testsuite/g++.dg/warn/Wsizeof-pointer-memaccess-1.C
    trunk/gcc/testsuite/gcc.dg/Wsizeof-pointer-memaccess1.c
    trunk/gcc/testsuite/gcc.dg/torture/Wsizeof-pointer-memaccess1.c
    trunk/gcc/testsuite/gcc.dg/vla-5.c
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.c/appendix-a/a.29.1.c

[Bug c/6940] taking sizeof array parameter should trigger a warning

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=6940

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.