public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/70248] constexpr initialization with unspecified equality expression accepted
Date: Thu, 15 Oct 2020 11:24:56 +0000	[thread overview]
Message-ID: <bug-70248-4-5NWGx5dHMm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-70248-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70248

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
In gcc/cp/typeck.c:cp_build_binary_op this warning should be an error during
constant evaluation for EQ_EXPR and NE_EXPR:

      if (complain & tf_warning)
        {
          tree stripped_orig_op0 = tree_strip_any_location_wrapper (orig_op0);
          tree stripped_orig_op1 = tree_strip_any_location_wrapper (orig_op1);
          if ((TREE_CODE (stripped_orig_op0) == STRING_CST
               && !integer_zerop (cp_fully_fold (op1)))
              || (TREE_CODE (stripped_orig_op1) == STRING_CST
                  && !integer_zerop (cp_fully_fold (op0))))
            warning_at (location, OPT_Waddress,
                        "comparison with string literal results in "
                        "unspecified behavior");
        }

And this one for rel ops and spaceships:

      if (TREE_CODE (orig_op0) == STRING_CST
          || TREE_CODE (orig_op1) == STRING_CST)
        {
          if (complain & tf_warning)
            warning_at (location, OPT_Waddress,
                        "comparison with string literal results "
                        "in unspecified behavior");
        }

That only handles the string literals cases though, we also need to reject
pointers to distinct objects at the same places.

  parent reply	other threads:[~2020-10-15 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-70248-4@http.gcc.gnu.org/bugzilla/>
2020-10-15 11:19 ` redi at gcc dot gnu.org
2020-10-15 11:24 ` redi at gcc dot gnu.org [this message]
2020-10-15 15:03 ` mpolacek at gcc dot gnu.org
2023-08-22 18:35 ` pkeir at outlook dot com
2024-01-03 13:00 ` redi at gcc dot gnu.org
2024-01-03 13:01 ` redi at gcc dot gnu.org
2024-01-03 13:07 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-70248-4-5NWGx5dHMm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).