public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aoliva at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/77760] get_time needs to set tm_wday amd tm_yday
Date: Thu, 09 Feb 2023 08:50:06 +0000	[thread overview]
Message-ID: <bug-77760-4-3T168ZyhHq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-77760-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77760

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org

--- Comment #3 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
I'm looking at a case in which __clang__ is defined, despite compiling with
GCC, and "%I...%p" parsing fails because the hack to pass state around doesn't
work when __clang__ is defined.

This got me thinking that there are more than enough bits in struct tm to
encode all of __time_get_state in it, even with redundancy, so that overwritten
fields could get recovered.  I'm thinking that, before calling do_get, get
would transfer its state onto struct tm in such a recoverable way, and, after
calling it, it would restore state from struct tm and remove the extra
out-of-range encodings.  Our do_get, in turn, would extract state from struct
tm, do its current job, and then pack the state back into struct tm.

AFAICT this could be put in in an ABI-compatible way, dropping the hack and
enabling libstdc++-specific do_get specializations to deal with such extended
states, should we document them.

Has anything along these lines already been considered and ruled out?

  parent reply	other threads:[~2023-02-09  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-77760-4@http.gcc.gnu.org/bugzilla/>
2021-12-15 19:43 ` jakub at gcc dot gnu.org
2022-01-10 14:40 ` cvs-commit at gcc dot gnu.org
2023-02-09  8:50 ` aoliva at gcc dot gnu.org [this message]
2023-02-09  9:08 ` jakub at gcc dot gnu.org
2023-02-09 23:40 ` aoliva at gcc dot gnu.org
2023-02-10  3:05 ` redi at gcc dot gnu.org
2023-02-10  8:33 ` jakub at gcc dot gnu.org
2023-02-17  7:54 ` aoliva at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-77760-4-3T168ZyhHq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).